Skip to contentSkip to conversation

2.4.21pre4aa2

DISCUSSION Andrea Arcangeli 2 participants 2 messages Feb 14, 2003 – Feb 15, 2003

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

I released a 2.4.21pre4aa2 but I hadn't time to write a changelog or to test it yet, so be careful. I'll write the changelog but not today.

this should fix a race in ll_rw_block that could explain hanging machines, I believe this race wasn't new and that it affects mainline too, but just made visible by the elevator-lowlatency for a few reasons.

Jeff, uml is way overcomplex to maintain these days, you must drop the non skas mode, there's no value at all in using uml w/o having memory protection for the kernel, it's as secure as running msdos, when it crashes you don't know if it was a buggy app or a kernel bug. So please drop the overdesign and also please make patches that can compile on all architectures, I had to put horrible #ifdefs around the do_mmap_pgoff breakages to avoid breaking everything. I'd appreciate if you could look at the incremental patches that I'm maintaining to make it compile so you see things like cpu() breakages etc.. If you could also verify that it works that would be great thanks, it linked but I can't say it works.

Andrea

#1 lore raw

Re: 2.4.21pre4aa2 - build problems (and patches)

Quoted 3 lines · Andrea Arcangeli

I released a 2.4.21pre4aa2 but I hadn't time to write a changelog or to test it yet, so be careful. I'll write the changelog but not today.

My all-modules build had the following problems.

1) linux/Makefile: bad compiler option?
gcc -D__KERNEL__ -I/data2/usr/local/src/linux-2.4-pre-aa/include -Wall -Wstrict-prototypes -Wno-trigraphs -O2 -fno-strict-aliasing -fno-common -finline-limit=2000 -fomit-frame-pointer -pipe -mpreferred-stack-boundary=2 -march=i686 -malign-functions=4 -DUTS_MACHINE='"i386"' -DKBUILD_BASENAME=version -c -o init/version.o init/version.c
cc1: Invalid option `-finline-limit=2000'
make: *** [init/version.o] Error 1

On Debian 3.0r1 (which is gcc 2.95.4) I had to remove the offending option.

2) the old drivers/char/scx200.c compile failure is still there (will it ever be fixed?)

3) drivers/char/ipmi: same failure as before
gcc -D__KERNEL__ -I/data2/usr/local/src/linux-2.4-pre-aa/include -Wall -Wstrict-prototypes -Wno-trigraphs -O2 -fno-strict-aliasing -fno-common -fomit-frame-pointer -pipe -mpreferred-stack-boundary=2 -march=i686 -malign-functions=4 -DMODULE -DMODVERSIONS -include /data2/usr/local/src/linux-2.4-pre-aa/include/linux/modversions.h -nostdinc -iwithprefix include -DKBUILD_BASENAME=ipmi_watchdog -DEXPORT_SYMTAB -c ipmi_watchdog.c
In file included from ipmi_watchdog.c:38:
/data2/usr/local/src/linux-2.4-pre-aa/include/linux/watchdog.h:17: parse error before `__u32' /data2/usr/local/src/linux-2.4-pre-aa/include/linux/watchdog.h:17:
warning: no semicolon at end of struct or union /data2/usr/local/src/linux-2.4-pre-aa/include/linux/watchdog.h:18:
warning: type defaults to int' in declaration of firmware_version' /data2/usr/local/src/linux-2.4-pre-aa/include/linux/watchdog.h:18:
warning: data definition has no type or storage class /data2/usr/local/src/linux-2.4-pre-aa/include/linux/watchdog.h:19: parse error before `identity' /data2/usr/local/src/linux-2.4-pre-aa/include/linux/watchdog.h:19:
warning: type defaults to int' in declaration of identity' /data2/usr/local/src/linux-2.4-pre-aa/include/linux/watchdog.h:19:
warning: data definition has no type or storage class /data2/usr/local/src/linux-2.4-pre-aa/include/linux/watchdog.h:20: parse error before `}'
ipmi_watchdog.c:452: variable `ident' has initializer but incomplete type
ipmi_watchdog.c:454: warning: excess elements in struct initializer ipmi_watchdog.c:454: warning: (near initialization for ident') ipmi_watchdog.c:455: warning: excess elements in struct initializer ipmi_watchdog.c:455: warning: (near initialization for ident') ipmi_watchdog.c:457: warning: excess elements in struct initializer ipmi_watchdog.c:457: warning: (near initialization for ident') ipmi_watchdog.c: In function ipmi_ioctl':
ipmi_watchdog.c:466: sizeof applied to an incomplete type ipmi_watchdog.c:467: sizeof applied to an incomplete type ipmi_watchdog.c:467: sizeof applied to an incomplete type ipmi_watchdog.c:467: sizeof applied to an incomplete type make[3]: *** [ipmi_watchdog.o] Error 1
make[3]: Leaving directory `/data2/usr/local/src/linux-2.4-pre-aa/drivers/char/ipmi'

I included types.h in watchdog.h.

4) drivers/ieee1394: same failure as before
gcc -D__KERNEL__ -I/data2/usr/local/src/linux-2.4-pre-aa/include -Wall -Wstrict-prototypes -Wno-trigraphs -O2 -fno-strict-aliasing -fno-common -fomit-frame-pointer -pipe -mpreferred-stack-boundary=2 -march=i686 -malign-functions=4 -DMODULE -DMODVERSIONS -include /data2/usr/local/src/linux-2.4-pre-aa/include/linux/modversions.h -nostdinc -iwithprefix include -DKBUILD_BASENAME=sbp2 -c -o sbp2.o sbp2.c
sbp2.c:1515: conflicting types for sbp2_handle_physdma_write' sbp2.h:508: previous declaration of sbp2_handle_physdma_write' sbp2.c:1531: conflicting types for sbp2_handle_physdma_read' sbp2.h:510: previous declaration of sbp2_handle_physdma_read' make[2]: *** [sbp2.o] Error 1
make[2]: Leaving directory `/data2/usr/local/src/linux-2.4-pre-aa/drivers/ieee1394'

5) Finally, the following unresolved were present. I left it alone.
depmod: *** Unresolved symbols in /lib/modules/2.4.21-pre4-aa2/kernel/drivers/char/ipmi/ipmi_msghandler.o
depmod: panic_notifier_list
depmod: *** Unresolved symbols in /lib/modules/2.4.21-pre4-aa2/kernel/drivers/char/ipmi/ipmi_watchdog.o

depmod:         panic_notifier_list
depmod:         panic_timeout
depmod: *** Unresolved symbols in

/lib/modules/2.4.21-pre4-aa2/kernel/fs/xfs/xfs.o
depmod: start_aggressive_readahead

--
Eyal Lebedinsky ([email protected]) <http://samba.org/eyal/>

Makefile renamed from Makefile.orig +1 -1
@@ -97,7 +97,7 @@
 CPPFLAGS := -D__KERNEL__ -I$(HPATH)
 
 CFLAGS := $(CPPFLAGS) -Wall -Wstrict-prototypes -Wno-trigraphs -O2 \
-	  -fno-strict-aliasing -fno-common -finline-limit=2000
+	  -fno-strict-aliasing -fno-common
 ifndef CONFIG_FRAME_POINTER
 CFLAGS += -fomit-frame-pointer
 endif
drivers/char/Makefile renamed from drivers/char/Makefile.orig +1 -1
@@ -24,7 +24,7 @@
 export-objs     :=	busmouse.o console.o keyboard.o sysrq.o \
 			misc.o pty.o random.o selection.o serial.o \
 			sonypi.o tty_io.o tty_ioctl.o generic_serial.o \
-			au1000_gpio.o hp_psaux.o nvram.o
+			au1000_gpio.o hp_psaux.o nvram.o scx200.o
 
 mod-subdirs	:=	joystick ftape drm drm-4.0 pcmcia
 
data2/usr/local/src/linux-2.4-pre-aa/include/linux/watchdog.h renamed from data2/usr/local/src/linux-2.4-pre-aa/include/linux/watchdog.h.orig +1 -0
@@ -10,6 +10,7 @@
 #define _LINUX_WATCHDOG_H
 
 #include <linux/ioctl.h>
+#include <linux/types.h>
 
 #define	WATCHDOG_IOCTL_BASE	'W'
 
drivers/ieee1394/sbp2.c renamed from drivers/ieee1394/sbp2.c.orig +2 -2
@@ -1511,7 +1511,7 @@
  * physical dma in hardware). Mostly just here for debugging...
  */
 static int sbp2_handle_physdma_write(struct hpsb_host *host, int nodeid, int destid, quadlet_t *data,
-                                     u64 addr, unsigned int length)
+                                     u64 addr, unsigned int length, u16 flags)
 {
 
         /*
@@ -1527,7 +1527,7 @@
  * physical dma in hardware). Mostly just here for debugging...
  */
 static int sbp2_handle_physdma_read(struct hpsb_host *host, int nodeid, quadlet_t *data,
-                                    u64 addr, unsigned int length)
+                                    u64 addr, unsigned int length, u16 flags)
 {
 
         /*