Skip to contentSkip to conversation

REMOTE_DEBUG, DEBUG config cleanup

PATCH In review Jun Sun 2 participants 3 messages Feb 13, 2003 – Feb 18, 2003

Subsystems (2)
lore
Share & tools
lore

Jun Sun

author
#0 lore raw

PATCH 1/1 REMOTE_DEBUG, DEBUG config cleanup

Remove false dependency. Add help info for CONFIG_DEBUG.

Patches for both 2.4 & 2.5.

Jun

Documentation/Configure.help renamed from Documentation/Configure.help.orig +7 -0
diff -Nru linux/Documentation/Configure.help.orig linux/Documentation/Configure.help
@@ -20482,6 +20482,13 @@
   Currently used only by the time services code in the MIPS port.
   Don't turn this on unless you know what you are doing.
 
+Enable run-time debugging
+CONFIG_DEBUG
+  If you say Y here, some debugging macros will do run-time checking.
+  If you say N here, those macros will mostly turn to no-ops.  For
+  MIPS boards only.  See include/asm-mips/debug.h for debuging macros.
+  If unsure, say N.
+
 Remote GDB kernel debugging
 CONFIG_REMOTE_DEBUG
   If you say Y here, it will be possible to remotely debug the MIPS
arch/mips/config-shared.in renamed from arch/mips/config-shared.in.orig +2 -4
diff -Nru linux/arch/mips/config-shared.in.orig linux/arch/mips/config-shared.in
@@ -976,10 +976,8 @@
 
 bool 'Are you using a crosscompiler' CONFIG_CROSSCOMPILE
 bool 'Enable run-time debugging' CONFIG_DEBUG
-if [ "$CONFIG_AU1X00_UART" = "y" -o "$CONFIG_ZS" = "y" -o "$CONFIG_SIBYTE_SB1xxx_SOC" = "y" ]; then
-   dep_bool 'Remote GDB kernel debugging' CONFIG_REMOTE_DEBUG $CONFIG_DEBUG
-   dep_bool '  Console output to GDB' CONFIG_GDB_CONSOLE $CONFIG_REMOTE_DEBUG
-fi
+bool 'Remote GDB kernel debugging' CONFIG_REMOTE_DEBUG
+dep_bool '  Console output to GDB' CONFIG_GDB_CONSOLE $CONFIG_REMOTE_DEBUG
 if [ "$CONFIG_SIBYTE_SB1xxx_SOC" = "y" ]; then
    dep_bool 'Compile for Corelis Debugger' CONFIG_SB1XXX_CORELIS $CONFIG_DEBUG
 fi
arch/mips/Kconfig-shared renamed from arch/mips/Kconfig-shared.orig +7 -1
diff -Nru linux/arch/mips/Kconfig-shared.orig linux/arch/mips/Kconfig-shared
@@ -1547,7 +1547,7 @@
 
 config REMOTE_DEBUG
 	bool "Remote GDB kernel debugging"
-	depends on DEBUG_KERNEL && (AU1000_UART || ZS=y)
+	depends on DEBUG_KERNEL
 	help
 	  If you say Y here, it will be possible to remotely debug the MIPS
 	  kernel using gdb. This enlarges your kernel image disk size by
@@ -1566,6 +1566,12 @@
 config DEBUG
 	bool "Enable run-time debugging"
 	depends on DEBUG_KERNEL
+	help
+	  If you say Y here, some debugging macros will do run-time checking.
+	  If you say N here, those macros will mostly turn to no-ops.  For
+	  MIPS boards only.  See include/asm-mips/debug.h for debuging macros.
+	  If unsure, say N.
+
 
 config MAGIC_SYSRQ
 	bool "Magic SysRq key"
#1 lore raw

Documentation/Configure.help line 20490

Quoted 7 lines · Jun Sun

Remove false dependency. Add help info for CONFIG_DEBUG.

Documentation/Configure.help renamed from Documentation/Configure.help.orig +6 -0
+Enable run-time debugging
+CONFIG_DEBUG
+  If you say Y here, some debugging macros will do run-time checking.
+  If you say N here, those macros will mostly turn to no-ops.  For
+  MIPS boards only.  See include/asm-mips/debug.h for debuging macros.
+  If unsure, say N.

CONFIG_DEBUG is too generic for an option that only applies to mips. Make it CONFIG_MIPS_DEBUG.

author
#2 lore raw

The hope is some other arches might adopt it too. How about CONFIG_RUNTIME_DEBUG?

While we are on the subject, Ralf and I also are thinking to change CONFIG_REMOTE_DEBUG to CONFIG_KGDB. Any objections?

Jun

Quoted 13 lines · Keith Owens

Documentation/Configure.help line 20490

Quoted 7 lines · Jun Sun

Remove false dependency. Add help info for CONFIG_DEBUG.

Documentation/Configure.help renamed from Documentation/Configure.help.orig +6 -0
+Enable run-time debugging
+CONFIG_DEBUG
+  If you say Y here, some debugging macros will do run-time checking.
+  If you say N here, those macros will mostly turn to no-ops.  For
+  MIPS boards only.  See include/asm-mips/debug.h for debuging macros.
+  If unsure, say N.

CONFIG_DEBUG is too generic for an option that only applies to mips. Make it CONFIG_MIPS_DEBUG.