Skip to contentSkip to conversation

2.5.62: /proc/ide/hpt366 returns incomplete data [7/17]

PATCH New Faik Uygur 1 participant 1 message Feb 22, 2003

lore
Share & tools
lore

Faik Uygur

author
#0 lore raw

PATCH 1/1 2.5.62: /proc/ide/hpt366 returns incomplete data [7/17]

This patch fixes the incomplete data return problem of /proc/ide/hpt366. When the number of consecutive read bytes are smaller than the total data in hpt366_get_info(), the second read() returns 0.

drivers/ide/pci/hpt366.c +6 -2
@@ -85,7 +85,7 @@
 	char *chipset_nums[] = {"366", "366",  "368",
 				"370", "370A", "372",
 				"302", "371",  "374" };
-	int i;
+	int i, len;
 
 	p += sprintf(p, "\n                             "
 		"HighPoint HPT366/368/370/372/374\n");
@@ -153,8 +153,12 @@
 		}
 	}
 	p += sprintf(p, "\n");
+
+	/* p - buffer must be less than 4k! */
+	len = (p - buffer) - offset;
+	*addr = buffer + offset;
 	
-	return p-buffer;/* => must be less than 4k! */
+	return len > count ? count : len;
 }
 #endif  /* defined(DISPLAY_HPT366_TIMINGS) && defined(CONFIG_PROC_FS) */