Skip to contentSkip to conversation

s390 (7/13): gcc 3.3 adaptions.

PATCH Arnd Bergmann 2 participants 2 messages Feb 24, 2003 2 messages not in the archive

lore
Share & tools
lore

A message that is not in the archive (sent off-list or not yet received): [email protected]

A message that is not in the archive (sent off-list or not yet received): [email protected]

#2 lore raw
Quoted 4 lines · Richard B. Johnson

I think you must keep these warnings in! There are many bugs that these uncover uncluding loops that don't terminate correctly but seem to work for "most all" cases. These are the hard-to-find bugs that hit you six months after release.

This was my change. Obviously the warning is a good idea in general, but I don't see the point of scrolling through hundreds of lines with the same warning in someone else's code. I actually plan to fix these warnings in arch/s390 and drivers/s390 as well as include/ and make the s390 kernel compile with -Werror, but the rest looks more like a task for the Janitors. Note that before gcc-3.3, -Wsign-compare has not been part of -Wall.

        Arnd <><
#3 lore raw
Quoted 7 lines · Arnd Bergmann
Quoted 4 lines · Richard B. Johnson

I think you must keep these warnings in! There are many bugs that these uncover uncluding loops that don't terminate correctly but seem to work for "most all" cases. These are the hard-to-find bugs that hit you six months after release.

Quoted 8 lines

This was my change. Obviously the warning is a good idea in general, but I don't see the point of scrolling through hundreds of lines with the same warning in someone else's code. I actually plan to fix these warnings in arch/s390 and drivers/s390 as well as include/ and make the s390 kernel compile with -Werror, but the rest looks more like a task for the Janitors. Note that before gcc-3.3, -Wsign-compare has not been part of -Wall.

Yep. There are a lot of things, not part of -Wall. To find 'need coffee' errors, I use:

	-Wall -Werror -Wstrict-prototypes -Wwrite-strings -Wshadow \
	-Wsign-compare -Wno-trigraphs

        plus...
	-fno-builtin -fno-common -fomit-frame-pointer.

I also use -march=1486 so it will boot. Some machines don't like cmov and other stuff the compiler may emit.

Cheers,
Dick Johnson
Penguin : Linux version 2.4.18 on an i686 machine (797.90 BogoMips). Why is the government concerned about the lunatic fringe? Think about it.