Skip to contentSkip to conversation

set_power_state bug

PATCH Applied Arnaud de Bossoreille de Ribou 2 participants 2 messages Feb 28, 2003

lore
Share & tools
lore

Arnaud de Bossoreille de Ribou

author
#0 lore raw

PATCH 1/1 set_power_state bug

Hello,

there's a bug introduced in the 1.25 revision of the file "alsa-kernel/core/control.c" which is fixed with the attached patch.

Please apply :-)

Bye,

Signature · 1 line
Arnaud
core/control.c +3 -2
@@ -714,15 +714,16 @@
 			return -EFAULT;
 		if (!capable(CAP_SYS_ADMIN))
 			return -EPERM;
-		err = -ENOPROTOOPT;
 #ifdef CONFIG_PM
 		if (card->set_power_state) {
 		    snd_power_lock(card);
 		    err = card->set_power_state(card, err);
 		    snd_power_unlock(card);
 		}
-#endif
 		return err;
+#else
+		return -ENOPROTOOPT;
+#endif
 	case SNDRV_CTL_IOCTL_POWER_STATE:
 #ifdef CONFIG_PM
 		return put_user(card->power_state, (int *)arg) ? -EFAULT : 0;
Applied
#1 lore raw
Quoted 4 lines · Arnaud de Bossoreille de Ribou

Hello,

there's a bug introduced in the 1.25 revision of the file "alsa-kernel/core/control.c" which is fixed with the attached patch.

I've applied a better fix to CVS. Thanks for your notice.

Jaroslav

-----
Jaroslav Kysela <[email protected]>
Linux Kernel Sound Maintainer
ALSA Project, SuSE Labs

-------------------------------------------------------
This sf.net email is sponsored by:ThinkGeek
Welcome to geek heaven.
http://thinkgeek.com/sf