taskqueue to workqueue update for riscom8 driver
No, this driver needs to be converted to the new serial core. It's still using cli(), for example.
Signature · 3 lines
"It's not Hollywood. War is real, war is primarily not about defeat or victory, it is about death. I've seen thousands and thousands of dead bodies. Do you think I want to have an academic debate on this subject?" -- Robert Fisk
Quoted 2 lines · Matthew Wilcox
No, this driver needs to be converted to the new serial core. It's still using
cli(), for example.
That's a different issue, isn't it? This patch was just meant to get the drivers in a compilable state... I'll look into the cli() issue, but I don't have any hardware to test...
Signature · 6 lines
Amit Shah
http://amitshah.nav.to/
The most exciting phrase to hear in science, the one that heralds new
discoveries, is not "Eureka!" (I found it!) but "That's funny ..."
-- Isaac AsimovQuoted 7 lines · Amit Shah
Quoted 2 lines · Matthew Wilcox
No, this driver needs to be converted to the new serial core. It's still using
cli(), for example.That's a different issue, isn't it? This patch was just meant to get the drivers in a compilable state... I'll look into the
cli()issue, but I don't have any hardware to test...
So it only compiles on UP. Not terribly interesting.
BTW, I wouldn't necessarily expect it to work. Work queues run in process context; the code you replaced ran in bottom half context. If you're going to do this kind of lame hack, it should be converted to a tasklet, not a work queue.
Signature · 3 lines
"It's not Hollywood. War is real, war is primarily not about defeat or victory, it is about death. I've seen thousands and thousands of dead bodies. Do you think I want to have an academic debate on this subject?" -- Robert Fisk
Quoted 6 lines · Matthew Wilcox
So it only compiles on UP. Not terribly interesting.
BTW, I wouldn't necessarily expect it to work. Work queues run in process context; the code you replaced ran in bottom half context. If you're going to do this kind of lame hack, it should be converted to a tasklet, not a work queue.
A simple grep for cli() in drivers/char reveals that many of those drivers still use cli(), which means even they haven't yet been converted to the new framework.
As for the patch, other drivers, like cyclades, for example, too have been modified in the same manner.... on digging, I found that the original patch that converted the taskqueues to workqueues had also done it the same way.
Amit.
Signature · 6 lines
Amit Shah
http://amitshah.nav.to/
The most exciting phrase to hear in science, the one that heralds new
discoveries, is not "Eureka!" (I found it!) but "That's funny ..."
-- Isaac AsimovQuoted 3 lines · Amit Shah
A simple grep for
cli()indrivers/charreveals that many of those drivers still usecli(), which means even they haven't yet been converted to the new framework.
Yes. Serial drivers still in drivers/char have not been converted to the new serial core. Part of the conversion process moves the drivers to drivers/serial.
Signature · 3 lines
"It's not Hollywood. War is real, war is primarily not about defeat or victory, it is about death. I've seen thousands and thousands of dead bodies. Do you think I want to have an academic debate on this subject?" -- Robert Fisk