add checkstack Makefile target
A message that is not in the archive (sent off-list or not yet received): [email protected]
A message that is not in the archive (sent off-list or not yet received): [email protected]
A message that is not in the archive (sent off-list or not yet received): [email protected]
A message that is not in the archive (sent off-list or not yet received): [email protected]
A message that is not in the archive (sent off-list or not yet received): [email protected]
A message that is not in the archive (sent off-list or not yet received): [email protected]
A message that is not in the archive (sent off-list or not yet received): [email protected]
A message that is not in the archive (sent off-list or not yet received): [email protected]
Quoted 6 lines · Jörn Engel
Yet another version:
- Arch dependent code is reduced to one regular expression.
- Much shorter.
- A tiny bit faster.Still, Keith' code beats the crap out of mine, speed-wise.
Ok, here is another regex for s390, including a changed $line calculation. I didn't have ksymoops around, but this change removes the need for it and should also speed things up.
Arnd <><
checkstack.pl 2003-03-06 02:25:23.000000000 +0100 renamed from checkstack.pl 2003-03-06 02:28:13.000000000 +0100 +10 -6
@@ -31,6 +31,9 @@ } elsif ($arch =~ /^ppc$/) { #c00029f4: 94 21 ff 30 stwu r1,-208(r1) $re = qr/.*(stwu.*r1,-($x{3,5})\(r1\))/o; + } elsif ($arch =~ /^s390x?$/) { + # 11160: a7 fb ff 60 aghi %r15,-160 + $re = qr/.*(ag?hi.*\%r15,-(([0-9]{2}|[3-9])[0-9]{2}))/o; } else { print "wrong or unknown architecture\n"; exit
@@ -46,16 +49,17 @@ # # main() # +$funcre = qr/^$x* \<(.*)\>:$/; while (defined($line = <STDIN>)) { + if ($line =~ m/$funcre/) { + ($func = $line) =~ s/$funcre/\1/; + chomp($func); + } + if ($line =~ m/$re/) { - (my $addr = $line) =~ s/^($x{8}).*/0x\1/o; + (my $addr = $line) =~ s/^([ 0-9a-z]{8}):.*/0x\1/o; chomp($addr); - my $ksymoops = `ksymoops -v vmlinux -m System.map -K -L -O -A $addr | \ - tail -2 | head -1`; - (my $func = $ksymoops) =~ s/^Adhoc [0-9a-f]{8} (<.*>)/\1/; - chomp($func); - my $intro = "$addr $func:"; my $padlen = 56 - length($intro); while ($padlen > 0) {
Quoted 4 lines · Arnd Bergmann
Ok, here is another regex for s390, including a changed $line calculation. I didn't have ksymoops around, but this change removes the need for it and should also speed things up.
Time for allnoconfig went down from 13s to 4s.
Time for allyesconfig went down from 44m to 59s.
Great!
The output is slightly less verbose, but that information wasn't too useful anyway. Thanks a lot!
BTW: Your mailer did something horrible to the patch, and I had to fix it manually. Hope it didn't break anything (i386 looks fine).
And mine appears to do the same. Better send it as an attachment until I fix the cause. :(
Jörn
Signature · 2 lines
Eighty percent of success is showing up. -- Woody Allen
Makefile +4 -0
@@ -908,3 +908,7 @@ descend =$(Q)$(MAKE) -f scripts/Makefile.build obj=$(1) $(2) FORCE: + +checkstack: #vmlinux FORCE + $(OBJDUMP) -d vmlinux | \ + $(PERL) scripts/checkstack.pl $(ARCH)
scripts/checkstack.pl +80 -0
80 lines not on this page · raw message