[2.5] memleak in load_elf_binary?
Hello!
I am still playing with improving memleak detector thing from smatch project.
Seems there is a memleak in fs/binfmt_elf.c::load_elf_binary() in current 2.5 If setup_arg_pages() fails (line 638 in my sources) we do return but not freeing possibly allocated elf_interpreter (line 520) and allocated elf_phdata (line 500) areas.
Is this looking real? At least it looks real for me (I am trying to get number of false positives way down).
Bye,
Oleg
Quoted 5 lines · Oleg Drokin
Hello!
I am still playing with improving memleak detector thing from smatch project.
Quoted 8 lines
Seems there is a memleak in fs/binfmt_elf.c::load_elf_binary() in current 2.5 If
setup_arg_pages()fails (line 638 in my sources) we do return but not freeing possibly allocatedelf_interpreter(line 520) and allocatedelf_phdata(line 500) areas.Is this looking real? At least it looks real for me (I am trying to get number of false positives way down).
Yes, you're right. And there's a second one further down.
Whoever thought of permitting more than one `return' statement in a C function should be shot.
This needs a little thought, as we've already set the new personality and the old executable has been rubbed out.
Hello!
Quoted 8 lines · Andrew Morton
Quoted 7 lines
I am still playing with improving memleak detector thing from smatch project. Seems there is a memleak in fs/binfmt_elf.c::load_elf_binary() in current 2.5 If
setup_arg_pages()fails (line 638 in my sources) we do return but not freeing possibly allocatedelf_interpreter(line 520) and allocatedelf_phdata(line 500) areas.
Is this looking real? At least it looks real for me (I am trying to get number of false positives way down).Yes, you're right. And there's a second one further down.
Ah, hm? Can you be mo precise? I do not see it.
Next return I see is in line 745, and the memory is freed before it.
Bye,
Oleg
Quoted 11 lines · Oleg Drokin
Hello!
Quoted 7 lines · Andrew Morton
Quoted 7 lines
I am still playing with improving memleak detector thing from smatch project. Seems there is a memleak in fs/binfmt_elf.c::load_elf_binary() in current 2.5 If
setup_arg_pages()fails (line 638 in my sources) we do return but not freeing possibly allocatedelf_interpreter(line 520) and allocatedelf_phdata(line 500) areas.
Is this looking real? At least it looks real for me (I am trying to get number of false positives way down).
Quoted 6 lines
Quoted 1 line
Yes, you're right. And there's a second one further down.
Ah, hm? Can you be mo precise? I do not see it.
Next return I see is in line 745, and the memory is freed before it.
It forgets to close the file. It'll be closed anyway by exit so I guess that's OK.
Quoted 3 lines · Andrew Morton
This needs a little thought, as we've already set the new personality and the old executable has been rubbed out.
Actually it looks to be fairly simple to fix. Less simple to test...
Hello!
Quoted 3 lines · Andrew Morton
Quoted 2 lines
This needs a little thought, as we've already set the new personality and the old executable has been rubbed out.
Actually it looks to be fairly simple to fix. Less simple to test...
BTW, I just noticed that 2.4 have absolutely same problem it seems, so you probably want to make fix for it too.
Bye,
Oleg