Skip to contentSkip to conversation

one line fix in arch/i386/Kconfig

RFC In review Paolo Ciarrocchi 3 participants 3 messages Mar 7, 2003

lore
Share & tools
lore
#0 lore raw

RFC 1/1 one line fix in arch/i386/Kconfig

Hi all,
this is the first time I post a patch to the list, therefore I'm really not sure if it is correct, even if it is just a 'one line patch'

If I say that my cpu is not a PentiumIV why
he bothers me about "check for P4 thermal throttling interrupt." ?

This patch show that option only if you select that kind of CPU.

Is it correct ? Does it makes sense ?

Ciao,
Paolo

i386/Kconfig renamed from i386/Kconfig.orig +1 -1
@@ -536,7 +536,7 @@
 
 config X86_MCE_P4THERMAL
 	bool "check for P4 thermal throttling interrupt."
-	depends on X86_MCE && (X86_UP_APIC || SMP)
+	depends on X86_MCE && (X86_UP_APIC || SMP) && MPENTIUM4
 	help
 	  Enabling this feature will cause a message to be printed when the P4
 	  enters thermal throttling.
Signature · 5 lines
______________________________________________
http://www.linuxmail.org/
Now with e-mail forwarding for only US$5.95/yr

Powered by Outblaze
#1 lore raw
Quoted 6 lines · Paolo Ciarrocchi

If I say that my cpu is not a PentiumIV why
he bothers me about "check for P4 thermal throttling interrupt." ?

This patch show that option only if you select that kind of CPU.

Is it correct ? Does it makes sense ?

We want people to be able to build a kernel which will run on many systems but still use CPU specific features.

#2 lore raw
In reply to Paolo Ciarrocchi
Followup to:  <[email protected]>
By author:    "Paolo Ciarrocchi" <[email protected]>
In newsgroup: linux.dev.kernel
Quoted 9 lines

Hi all,
this is the first time I post a patch to the list, therefore I'm really not sure if it is correct, even if it is just a 'one line patch'

If I say that my cpu is not a PentiumIV why
he bothers me about "check for P4 thermal throttling interrupt." ?

Because you might be compiling a kernel for a more baseline CPU, say a 486, but still check for thermal throttle if it's present.

Quoted 3 lines

This patch show that option only if you select that kind of CPU.

Is it correct ? Does it makes sense ?

No.

-hpa

Signature · 3 lines
<[email protected]> at work, <[email protected]> in private!
"Unix gives you enough rope to shoot yourself in the foot."
Architectures needed: ia64 m68k mips64 ppc ppc64 s390 s390x sh v850 x86-64