cpufreq (3/7): remove unneeded code
PATCH 1/1 cpufreq (3/7): remove unneeded code
----- Forwarded message from Dominik Brodowski <[email protected]> -----
From: Dominik Brodowski <[email protected]>
To: [email protected]
Cc: [email protected]
Subject: [PATCH] cpufreq (3/7): remove unneeded code
Date: Fri, 7 Mar 2003 11:09:04 +0100
- no cpufreq driver uses the frequency table helper "setpolicy" any more ("target" is much more appropriate for them anyways) - so remove that helper
- all cpufreq drivers use the advanced registration process, so some compatibility code can safely be removed.
drivers/cpufreq/freq_table.c | 50 ------------------------------------------- include/linux/cpufreq.h | 7 ------ kernel/cpufreq.c | 22 ++++++------------ 3 files changed, 7 insertions(+), 72 deletions(-)
drivers/cpufreq/freq_table.c +0 -50
@@ -77,56 +77,6 @@EXPORT_SYMBOL_GPL (cpufreq_frequency_table_verify); -int cpufreq_frequency_table_setpolicy (struct cpufreq_policy *policy, -struct cpufreq_frequency_table *table, -unsigned int *index) -{ -struct cpufreq_frequency_table optimal = { .index = ~0 , }; -unsigned int i; - -switch (policy->policy) { -case CPUFREQ_POLICY_PERFORMANCE : - optimal.frequency =0 ; -break ; -case CPUFREQ_POLICY_POWERSAVE : - optimal.frequency = ~0 ; -break ; - } - -if (!cpu_online (policy->cpu)) -return -EINVAL ; - -for (i=0 ; (table[i].frequency !=CPUFREQ_TABLE_END ); i++) { -unsigned int freq = table[i].frequency; -if (freq ==CPUFREQ_ENTRY_INVALID ) -continue ; -if ((freq < policy->min) || (freq > policy->max)) -continue ; -switch (policy->policy) { -case CPUFREQ_POLICY_PERFORMANCE : -if (optimal.frequency <= freq) { - optimal.frequency = freq; - optimal.index = i; - } -break ; -case CPUFREQ_POLICY_POWERSAVE : -if (optimal.frequency >= freq) { - optimal.frequency = freq; - optimal.index = i; - } -break ; - } - } -if (optimal.index > i) -return -EINVAL ; - - *index = optimal.index; - -return 0 ; -} -EXPORT_SYMBOL_GPL (cpufreq_frequency_table_setpolicy); - - int cpufreq_frequency_table_target(struct cpufreq_policy *policy, struct cpufreq_frequency_table *table, unsigned int target_freq,
include/linux/cpufreq.h +0 -7
@@ -172,9 +172,6 @@int cpufreq_register_driver (struct cpufreq_driver *driver_data);int cpufreq_unregister_driver (struct cpufreq_driver *driver_data); -/* deprecated */ -#define cpufreq_register (x) cpufreq_register_driver(x) -#define cpufreq_unregister () cpufreq_unregister_driver(NULL)void cpufreq_notify_transition (struct cpufreq_freqs *freqs,unsigned int state);
@@ -297,10 +294,6 @@int cpufreq_frequency_table_verify (struct cpufreq_policy *policy,struct cpufreq_frequency_table *table); -int cpufreq_frequency_table_setpolicy (struct cpufreq_policy *policy, -struct cpufreq_frequency_table *table, -unsigned int *index); - int cpufreq_frequency_table_target(struct cpufreq_policy *policy, struct cpufreq_frequency_table *table, unsigned int target_freq,
kernel/cpufreq.c +7 -15
@@ -798,7 +798,7 @@if (cpufreq_driver)return -EBUSY ; -if (!driver_data || !driver_data->verify || +if (!driver_data || !driver_data->verify || !driver_data->init || ((!driver_data->setpolicy) && (!driver_data->target)))return -EINVAL ;
@@ -806,20 +806,12 @@ cpufreq_driver = driver_data; + cpufreq_driver->policy =kmalloc (NR_CPUS *sizeof (struct cpufreq_policy ),GFP_KERNEL );if (!cpufreq_driver->policy) { -/* then we need per-CPU init */ -if (!cpufreq_driver->init) { -up (&cpufreq_driver_sem); -return -EINVAL ; - } - cpufreq_driver->policy =kmalloc (NR_CPUS *sizeof (struct cpufreq_policy ),GFP_KERNEL ); -if (!cpufreq_driver->policy) { -up (&cpufreq_driver_sem); -return -ENOMEM ; - } -memset (cpufreq_driver->policy,0 ,NR_CPUS *sizeof (struct cpufreq_policy )); +up (&cpufreq_driver_sem); +return -ENOMEM ; } - +memset (cpufreq_driver->policy,0 ,NR_CPUS *sizeof (struct cpufreq_policy ));up (&cpufreq_driver_sem); ret =interface_register (&cpufreq_interface);
@@ -841,8 +833,8 @@ {down (&cpufreq_driver_sem); -if (!cpufreq_driver || - ((driver != cpufreq_driver) && (driver !=NULL ))) {/* compat */ +if (!cpufreq_driver || + (driver != cpufreq_driver)) {up (&cpufreq_driver_sem);return -EINVAL ; }
_______________________________________________
Cpufreq mailing list
[email protected]
http://www.linux.org.uk/mailman/listinfo/cpufreq
----- End forwarded message -----
Signature · 2 lines
Russell King ([email protected]) The developer of ARM Linux http://www.arm.linux.org.uk/personal/aboutme.html