Skip to contentSkip to conversation

include cfi_cmdset_0020 in drivers/mtd/chips/Makefile

PATCH In review Adrian Bunk 2 participants 3 messages Feb 27, 2003 – Mar 11, 2003 Memory technology devices (MTD)

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 include cfi_cmdset_0020 in drivers/mtd/chips/Makefile

2.4.21-pre5 includes drivers/mtd/chips/cfi_cmdset_0020.c but doesn't compile it. The following patch fixes it:

drivers/mtd/chips/Makefile renamed from drivers/mtd/chips/Makefile.old +1 -0
@@ -17,6 +17,7 @@
 obj-$(CONFIG_MTD)		+= chipreg.o
 obj-$(CONFIG_MTD_AMDSTD)	+= amd_flash.o 
 obj-$(CONFIG_MTD_CFI)		+= cfi_probe.o
+obj-$(CONFIG_MTD_CFI_STAA)	+= cfi_cmdset_0020.o
 obj-$(CONFIG_MTD_CFI_AMDSTD)	+= cfi_cmdset_0002.o
 obj-$(CONFIG_MTD_CFI_INTELEXT)	+= cfi_cmdset_0001.o
 obj-$(CONFIG_MTD_GEN_PROBE)	+= gen_probe.o

cu
Adrian

Signature · 4 lines
       "Is there not promise of rain?" Ling Tan asked suddenly out
        of the darkness. There had been need of rain for many days.
       "Only a promise," Lao Er said.
                                       Pearl S. Buck - Dragon Seed
#1 lore raw
Quoted 7 lines · Adrian Bunk

2.4.21-pre5 includes drivers/mtd/chips/cfi_cmdset_0020.c but doesn't compile it. The following patch fixes it:

drivers/mtd/chips/Makefile line 23

Quoted 7 lines
drivers/mtd/chips/Makefile renamed from drivers/mtd/chips/Makefile.old +1 -0
@@ -17,6 +17,7 @@
 obj-$(CONFIG_MTD)		+= chipreg.o
 obj-$(CONFIG_MTD_AMDSTD)	+= amd_flash.o 
 obj-$(CONFIG_MTD_CFI)		+= cfi_probe.o
+obj-$(CONFIG_MTD_CFI_STAA)	+= cfi_cmdset_0020.o
 obj-$(CONFIG_MTD_CFI_AMDSTD)	+= cfi_cmdset_0002.o
 obj-$(CONFIG_MTD_CFI_INTELEXT)	+= cfi_cmdset_0001.o
 obj-$(CONFIG_MTD_GEN_PROBE)	+= gen_probe.o

This is fixed in mtd cvs already.

Just out of curiosity: How did you notice it? Do you actually use that driver?

J�rn

Signature · 3 lines
I can say that I spend most of my time fixing bugs even if I have lots
of new features to implement in mind, but I give bugs more priority.
-- Andrea Arcangeli, 2000
#2 lore raw
Quoted 3 lines · Jörn Engel

...
Just out of curiosity: How did you notice it? Do you actually use that driver?

No, I'm doing compile-only tests (in this case a .config that contains except module support as much as possible) and this problem caused a build failure.

Quoted 1 line

Jörn

cu
Adrian

Signature · 4 lines
       "Is there not promise of rain?" Ling Tan asked suddenly out
        of the darkness. There had been need of rain for many days.
       "Only a promise," Lao Er said.
                                       Pearl S. Buck - Dragon Seed