Skip to contentSkip to conversation

Please revert second addition of stddef.h to list.h

PATCH Matthew Wilcox 2 participants 3 messages Mar 11, 2003 – Mar 15, 2003

lore
Share & tools
lore
#0 lore raw

I read these things on the web so I dunno how to specify a BK command to do what needs to be done, but this cset:

http://www.kernel.org/pub/linux/kernel/v2.5/testing/cset/cset-1.1137.txt

is obviously wrong.

include/linux/list.h +1 -0
diff -Nru a/include/linux/list.h b/include/linux/list.h
@@ -3,6 +3,7 @@
 
 #ifdef __KERNEL__
 
+#include <linux/stddef.h>
 #include <linux/prefetch.h>
 #include <linux/stddef.h>
 #include <asm/system.h>
Signature · 3 lines
"It's not Hollywood.  War is real, war is primarily not about defeat or
victory, it is about death.  I've seen thousands and thousands of dead bodies.
Do you think I want to have an academic debate on this subject?" -- Robert Fisk
#1 lore raw

Hi Mathew,

Quoted 6 lines · Matthew Wilcox

I read these things on the web so I dunno how to specify a BK command to do what needs to be done, but this cset:

http://www.kernel.org/pub/linux/kernel/v2.5/testing/cset/cset-1.1137.txt

is obviously wrong.

Yes, although the original patch itself was correct. Obviously 2 patch sets that are trying to do the same thing have been applied post 2.5.64.

Patch below would fix this...

Regards
Greg

include/linux/list.h Sat Mar 15 22:45:53 2003 renamed from include/linux/list.h.org Sat Mar 15 22:45:47 2003 +0 -1
@@ -5,7 +5,6 @@
 
 #include <linux/stddef.h>
 #include <linux/prefetch.h>
-#include <linux/stddef.h>
 #include <asm/system.h>
 
 /*

------------------------------------------------------------------------
Greg Ungerer -- Chief Software Wizard EMAIL: [email protected]
SnapGear Pty Ltd PHONE: +61 7 3435 2888
825 Stanley St, FAX: +61 7 3891 3630
Woolloongabba, QLD, 4102, Australia WEB: www.SnapGear.com

#2 lore raw
Quoted 5 lines · Greg Ungerer

Yes, although the original patch itself was correct. Obviously 2 patch sets that are trying to do the same thing have been applied post 2.5.64.

Patch below would fix this...

Yes, but you're removing the wrong one. Keeping includes in alphabetical order removes the possibility of this kind of fuck-up.

Signature · 3 lines
"It's not Hollywood.  War is real, war is primarily not about defeat or
victory, it is about death.  I've seen thousands and thousands of dead bodies.
Do you think I want to have an academic debate on this subject?" -- Robert Fisk