Skip to contentSkip to conversation

[2.4] Memleak on error exit path in Aironet 4500 Pcmcia driver

PATCH Oleg Drokin 1 participant 1 message Mar 12, 2003 Network drivers

lore
Share & tools
lore
#0 lore raw

Hello!

There is a memleak on OOM in Aironet 4500 Pcmcia driver, trivial to fix. See the patch.
Found with help of smatch + enhanced unfree script.

Bye,
Oleg

===== drivers/net/pcmcia/aironet4500_cs.c 1.8 vs edited =====

drivers/net/pcmcia/aironet4500_cs.c +7 -1
@@ -282,7 +282,13 @@
 	};
 	memset(dev,0,sizeof(struct net_device));
 	dev->priv = kmalloc(sizeof(struct awc_private), GFP_KERNEL);
-	if (!dev->priv ) {printk(KERN_CRIT "out of mem on dev priv alloc \n"); return NULL;};
+	if (!dev->priv ) {
+		printk(KERN_CRIT "out of mem on dev priv alloc \n");
+                kfree(dev);
+                kfree(link->dev);
+                kfree(link);
+		return NULL;
+	}
 	memset(dev->priv,0,sizeof(struct awc_private));
 	
 //	link->dev->minor = dev->minor;