kiocbClear should use clear_bit instead of set_bit
PATCH 1/1 kiocbClear should use clear_bit instead of set_bit
Just an obvious fix.
The kiocbClearX macros were doing a set_bit !
They should be calling clear_bit.
Ran into this now that I'm actually using kiocbClearKicked.
Regards
Suparna
include/linux/aio.h +3 -3
@@ -37,9 +37,9 @@#define kiocbSetKicked (iocb) set_bit(KIF_KICKED, &(iocb)->ki_flags)#define kiocbSetCancelled (iocb) set_bit(KIF_CANCELLED, &(iocb)->ki_flags) -#define kiocbClearLocked (iocb) set_bit(KIF_LOCKED, &(iocb)->ki_flags) -#define kiocbClearKicked (iocb) set_bit(KIF_KICKED, &(iocb)->ki_flags) -#define kiocbClearCancelled (iocb) set_bit(KIF_CANCELLED, &(iocb)->ki_flags) +#define kiocbClearLocked (iocb) clear_bit(KIF_LOCKED, &(iocb)->ki_flags) +#define kiocbClearKicked (iocb) clear_bit(KIF_KICKED, &(iocb)->ki_flags) +#define kiocbClearCancelled (iocb) clear_bit(KIF_CANCELLED, &(iocb)->ki_flags)#define kiocbIsLocked (iocb) test_bit(0, &(iocb)->ki_flags)#define kiocbIsKicked (iocb) test_bit(1, &(iocb)->ki_flags)
Signature · 3 lines
Suparna Bhattacharya ([email protected]) Linux Technology Center IBM Software Labs, India