initramfs fails for medium sized cpio archives
Subsystems (2)
[ Please cc me on any replies. Thanks! ]
I'm trying to get 2.5.64 to load my initramfs cpio archive and have run into a problem with memory allocation during the unpacking.
It seems that page_writeback_init() does not get called before populate_root(), so total_pages in mm/page-writeback.c is still zero rather than being initialized to nr_free_pagecache_pages().
The symptom is that after about 300 kb of files, balance_dirty_pages() is called. This then calls get_dirty_limits() that computes
unmapped_ratio = 100 - (ps->nr_mapped * 100) / total_pages;
I've added a sanity check in get_dirty_limits() that initialized total_pages if it is still zero and things seem to work, but should some of the memory management modules be initialized first?
The kernel is booting on an Athlon and compiled with gcc 3.2.2. The cpio archive is uClibc based and is about 600 k in size. I created it with the following command:
find . \ | cpio -H crc -ov \ | gzip > ../linux-2.5.64/usr/initramfs_data.cpio.gz
Trammell
Signature · 3 lines
-----|----- [email protected] W 240-283-1700 *>=====[]L\ [email protected] M 505-463-1896 ' -'-`- http://www.swcp.com/~hudson/ KC5RNF
Quoted 5 lines · Trammell Hudson
[ Please cc me on any replies. Thanks! ]
I'm trying to get 2.5.64 to load my initramfs cpio archive and have run into a problem with memory allocation during the unpacking.
This should be fixed in 2.5.65. Please let us know if you still have problems after trying that kernel.
thanks,
greg k-h
Quoted 6 lines · Trammell Hudson
unmapped_ratio = 100 - (ps->nr_mapped * 100) / total_pages;I've added a sanity check in
get_dirty_limits()that initializedtotal_pagesif it is still zero and things seem to work, but should some of the memory management modules be initialized first?
This is fixed in 2.5.65, with the below patch.
Quoted 8 lines
The kernel is booting on an Athlon and compiled with gcc 3.2.2. The cpio archive is uClibc based and is about 600 k in size. I created it with the following command:
find . \ | cpio -H crc -ov \ | gzip > ../linux-2.5.64/usr/initramfs_data.cpio.gz
Neat. Nice to see it working.
include/linux/writeback.h renamed from include/linux/writeback.h~early-writeback-init +1 -0
@@ -79,6 +79,7 @@ extern int dirty_writeback_centisecs;extern int dirty_expire_centisecs; +void page_writeback_init (void );void balance_dirty_pages (struct address_space *mapping);void balance_dirty_pages_ratelimited (struct address_space *mapping);int pdflush_operation (void (*fn)(unsigned long ),unsigned long arg0);
init/main.c renamed from init/main.c~early-writeback-init +3 -0
@@ -35,6 +35,7 @@#include <linux/profile.h> #include <linux/rcupdate.h> #include <linux/moduleparam.h> +#include <linux/writeback.h> #include <asm/io.h> #include <asm/bugs.h>
@@ -443,6 +444,8 @@ asmlinkage void __init start_kernel(voidvfs_caches_init (num_physpages);radix_tree_init ();signals_init (); +/* rootfs populating might need page-writeback */ +page_writeback_init ();populate_rootfs ();#ifdef CONFIG_PROC_FS proc_root_init ();
mm/page-writeback.c renamed from mm/page-writeback.c~early-writeback-init +1 -3
@@ -369,7 +369,7 @@ static struct notifier_block ratelimit_n* dirty memory thresholds: allowing too much dirty highmem pins an excessive * number of buffer_heads. */ -static int __init page_writeback_init (void ) +void __init page_writeback_init (void ) {long buffer_pages =nr_free_buffer_pages ();long correction;
@@ -392,9 +392,7 @@ static int __init page_writeback_init(voadd_timer (&wb_timer);set_ratelimit ();register_cpu_notifier (&ratelimit_nb); -return 0 ; } -module_init (page_writeback_init);int do_writepages (struct address_space *mapping,struct writeback_control *wbc) {
_
Quoted 6 lines · Andrew Morton
Quoted 3 lines · Trammell Hudson
I've added a sanity check in
get_dirty_limits()that initializedtotal_pagesif it is still zero and things seem to work, but should some of the memory management modules be initialized first?This is fixed in 2.5.65, with the below patch.
Thanks. I had missed it in the 2.5.65 change log since it didn't mention initramfs, but now see the "Early page_writeback initialization" entry. The patch does fix the divide by zero error.
Quoted 1 line
[...] Neat. Nice to see it working.
I'm working on a custom system that can only send a single file to the nodes (over a custom interconnect) when they boot, so neither tftping a ramdisk or a PXE boot loader would work for me. Having the initramfs image be bundled into the kernel is a real life saver.
Trammell
Signature · 3 lines
-----|----- [email protected] W 240-283-1700 *>=====[]L\ [email protected] M 505-463-1896 ' -'-`- http://www.swcp.com/~hudson/ KC5RNF