Skip to contentSkip to conversation

current BK boot failure, d_alloc()

DISCUSSION Jens Axboe 2 participants 4 messages Mar 24, 2003 VFS

lore
Share & tools
lore

Jens Axboe

author
#0 lore raw

Hi,

SBF: Simple Boot Flag extension found and enabled.
SBF: Setting boot flags 0x80
Starting balanced_irq
Enabling SEP on CPU 1
Enabling SEP on CPU 0

Program received signal SIGSEGV, Segmentation fault. 0xc016da64 in d_alloc (parent=0x0, name=0xdff8fea8) at include/asm/string.h:196
196 __asm__ __volatile__(
(gdb) bt
#0 0xc016da64 in d_alloc (parent=0x0, name=0xdff8fea8)

    at include/asm/string.h:196
#1  0xc016dd16 in d_alloc_root (root_inode=0xc176ddc4) at
fs/dcache.c:787
#2  0xc014f46b in shmem_fill_super (sb=0xc176ddc4, data=0x1, silent=0)
    at mm/shmem.c:1738
#3  0xc015cabf in get_sb_nodev (fs_type=0x1, flags=-1049174588,
data=0x1, 
    fill_super=0xc014f330 <shmem_fill_super>) at fs/super.c:586
#4  0xc015cc16 in do_kern_mount (fstype=0x1 <Address 0x1 out of bounds>, 
    flags=1, name=0xc02c3547 "tmpfs", data=0x1) at fs/super.c:639
#5  0xc015ccb7 in kern_mount (type=0x1) at fs/super.c:665
#6  0xc0346620 in init_tmpfs () at mm/shmem.c:1887
#7  0xc0338992 in do_initcalls () at init/main.c:486
#8  0xc01050f5 in init (unused=0x0) at init/main.c:551

(gdb) print *(struct qstr *) name
$1 = {name = 0x0, len = 1, hash = 0, name_str = 0xdff8feb4 "\230µÿß\200µÿß"}

craps out in memcpy() due to name->name == NULL

Signature · 1 line
Jens Axboe
author
#1 lore raw
Quoted 28 lines · Jens Axboe

Hi,

SBF: Simple Boot Flag extension found and enabled.
SBF: Setting boot flags 0x80
Starting balanced_irq
Enabling SEP on CPU 1
Enabling SEP on CPU 0

Program received signal SIGSEGV, Segmentation fault. 0xc016da64 in d_alloc (parent=0x0, name=0xdff8fea8) at include/asm/string.h:196
196 __asm__ __volatile__(
(gdb) bt
#0 0xc016da64 in d_alloc (parent=0x0, name=0xdff8fea8)

    at include/asm/string.h:196
#1  0xc016dd16 in d_alloc_root (root_inode=0xc176ddc4) at
fs/dcache.c:787
#2  0xc014f46b in shmem_fill_super (sb=0xc176ddc4, data=0x1, silent=0)
    at mm/shmem.c:1738
#3  0xc015cabf in get_sb_nodev (fs_type=0x1, flags=-1049174588,
data=0x1, 
    fill_super=0xc014f330 <shmem_fill_super>) at fs/super.c:586
#4  0xc015cc16 in do_kern_mount (fstype=0x1 <Address 0x1 out of bounds>, 
    flags=1, name=0xc02c3547 "tmpfs", data=0x1) at fs/super.c:639
#5  0xc015ccb7 in kern_mount (type=0x1) at fs/super.c:665
#6  0xc0346620 in init_tmpfs () at mm/shmem.c:1887
#7  0xc0338992 in do_initcalls () at init/main.c:486
#8  0xc01050f5 in init (unused=0x0) at init/main.c:551
Quoted 4 lines

(gdb) print *(struct qstr *) name
$1 = {name = 0x0, len = 1, hash = 0, name_str = 0xdff8feb4 "\230µÿß\200µÿß"}

craps out in memcpy() due to name->name == NULL

smells like a compiler problem, with the following patch:

===== fs/dcache.c 1.43 vs edited =====

fs/dcache.c +2 -1
@@ -784,7 +784,8 @@
 	struct dentry *res = NULL;
 
 	if (root_inode) {
-		res = d_alloc(NULL, &(const struct qstr) { "/", 1, 0 });
+		struct qstr name = { .name = "/", .len = 1, .hash = 0 };
+		res = d_alloc(NULL, &name);
 		if (res) {
 			res->d_sb = root_inode->i_sb;
 			res->d_parent = res;
Signature · 1 line
Jens Axboe
#2 lore raw
Quoted 4 lines · Jens Axboe
Quoted 3 lines

Hi,

[snip]

Quoted 9 lines
Quoted 1 line

craps out in memcpy() due to name->name == NULL

smells like a compiler problem, with the following patch:

===== fs/dcache.c 1.43 vs edited =====

fs/dcache.c +0 -0
@@ -784,7 +784,8 @@
 	struct dentry *res = NULL;

fs/dcache.c

Quoted 10 lines
fs/dcache.c +2 -2
 
 	if (root_inode) {
-		res = d_alloc(NULL, &(const struct qstr) { "/", 1, 0 });
+		struct qstr name = { .name = "/", .len = 1, .hash = 0 };
+		res = d_alloc(NULL, &name);
 		if (res) {
 			res->d_sb = root_inode->i_sb;
 			res->d_parent = res;
 
--

what compiler, please?

~Randy

author
#3 lore raw
Quoted 23 lines · Randy.Dunlap
Quoted 4 lines · Jens Axboe
Quoted 3 lines

Hi,

[snip]

Quoted 18 lines
Quoted 1 line

craps out in memcpy() due to name->name == NULL

smells like a compiler problem, with the following patch:

===== fs/dcache.c 1.43 vs edited =====

fs/dcache.c +2 -1
@@ -784,7 +784,8 @@
 	struct dentry *res = NULL;
 
 	if (root_inode) {
-		res = d_alloc(NULL, &(const struct qstr) { "/", 1, 0 });
+		struct qstr name = { .name = "/", .len = 1, .hash = 0 };
+		res = d_alloc(NULL, &name);
 		if (res) {
 			res->d_sb = root_inode->i_sb;
 			res->d_parent = res;
Quoted 3 lines
Quoted 1 line

--

what compiler, please?

gcc 3.3 pre-release, I cannot reproduce it in userspace though. I'll try and take a look at the generated code.

Signature · 1 line
Jens Axboe