Skip to contentSkip to conversation

New: typo in ipmi_devintf.c causes kernel compile to fail

Bug 508 In review Martin J. Bligh 4 participants 5 messages Mar 26, 2003 IPMI

lore
Share & tools
lore
#0 lore raw

http://bugme.osdl.org/show_bug.cgi?id=508

Summary: typo in ipmi_devintf.c causes kernel compile to fail
Kernel Version: 2.5.66
Status: NEW
Severity: normal
Owner: [email protected]
Submitter: [email protected]

Distribution:
Hardware Environment: intel x86
Software Environment:
Problem Description: drivers/char/ipmi/ipmi_devintf.c:452 'snprinf' should be 'snprintf'

Steps to reproduce: enable ipmi support and try to build kernel. Adding the missing 't' fixes the problem

#1 lore raw

PATCH 1/1 bug 508: ipmi compile fix

Quoted 2 lines · Martin J. Bligh

Problem Description: drivers/char/ipmi/ipmi_devintf.c:452 'snprinf' should be 'snprintf'

Sheesh, diffing the solution is certainly quicker than filling out the bugzilla entry...

Patch is against 2.5.66. Linus, please apply.

Robert Love

 drivers/char/ipmi/ipmi_devintf.c |    2 +-
 1 files changed, 1 insertion(+), 1 deletion(-)
drivers/char/ipmi/ipmi_devintf.c +1 -1
diff -urN linux-2.5.66/drivers/char/ipmi/ipmi_devintf.c linux/drivers/char/ipmi/ipmi_devintf.c
@@ -449,7 +449,7 @@
 	if (if_num > MAX_DEVICES)
 		return;
 
-	snprinf(name, sizeof(name), "ipmidev/%d", if_num);
+	snprintf(name, sizeof(name), "ipmidev/%d", if_num);
 
 	handles[if_num] = devfs_register(NULL, name, DEVFS_FL_NONE,
 					 ipmi_major, if_num,
#2 lore raw

Re: [patch] bug 508: ipmi compile fix

On 26 Mar 2003 14:14:50 -0500 Robert Love <[email protected]> wrote:

| On Wed, 2003-03-26 at 13:56, Martin J. Bligh wrote:
| 
| > Problem Description: drivers/char/ipmi/ipmi_devintf.c:452
| > 'snprinf' should be 'snprintf'
| 
| Sheesh, diffing the solution is certainly quicker than filling out the
| bugzilla entry...
| 
| Patch is against 2.5.66.  Linus, please apply.

Exactly what I said before I saw your patch. :)

--
~Randy

#3 lore raw

Re: [patch] bug 508: ipmi compile fix

Quoted 4 lines · Randy.Dunlap
| Sheesh, diffing the solution is certainly quicker than filling out the
| bugzilla entry...
| Patch is against 2.5.66.  Linus, please apply.

Exactly what I said before I saw your patch. :)

Then again, trivial one liners do get forgotten..

Dave

#4 lore raw

Re: [patch] bug 508: ipmi compile fix

On Wed, 26 Mar 2003 20:34:35 +0000 Dave Jones <[email protected]> wrote:

| On Wed, Mar 26, 2003 at 12:19:42PM -0800, Randy.Dunlap wrote:
| 
|  > | Sheesh, diffing the solution is certainly quicker than filling out the
|  > | bugzilla entry...
|  > | Patch is against 2.5.66.  Linus, please apply.
|  > Exactly what I said before I saw your patch.  :)
| 
| Then again, trivial one liners do get forgotten..

Yes, good point.

--
~Randy