Ptrace hole / Linux 2.2.25
Subsystems (14)
Vulnerability: CAN-2003-0127
The Linux 2.2 and Linux 2.4 kernels have a flaw in ptrace. This hole allows local users to obtain full privileges. Remote exploitation of this hole is not possible. Linux 2.5 is not believed to be vulnerable.
Linux 2.2.25 has been released to correct Linux 2.2. It contains no other changes. The bug fixes that would have been in 2.2.5pre1 will now appear in 2.2.26pre1. The patch will apply directly to most older 2.2 releases.
A patch for Linux 2.4.20/Linux 2.4.21pre is attached. The patch also subtly changes the PR_SET_DUMPABLE prctl. We believe this is neccessary and that it will not affect any software. The functionality change is specific to unusual debugging situations.
We would like to thank Andrzej Szombierski who found the problem, and wrote an initial patch. Seth Arnold cleaned up the 2.2 change. Arjan van de Ven and Ben LaHaise identified additional problems with the original fix.
Alan
arch/alpha/kernel/entry.S +2 -2
@@ -231,12 +231,12 @@ kernel_clone: .end kernel_clone /* - * kernel_thread(fn, arg, clone_flags) + * arch_kernel_thread(fn, arg, clone_flags) */ .align 3 .globl kernel_thread .ent kernel_thread -kernel_thread: +arch_kernel_thread: ldgp $29,0($27) /* we can be called from a module */ .frame $30, 4*8, $26 subq $30,4*8,$30
arch/arm/kernel/process.c +1 -1
@@ -366,7 +366,7 @@ void dump_thread(struct pt_regs * regs,* a system call from a "real" process, but the process memory space will * not be free'd until both the parent and the child have exited. */ -pid_t kernel_thread (int (*fn)(void *),void *arg,unsigned long flags) +pid_t arch_kernel_thread (int (*fn)(void *),void *arg,unsigned long flags) {pid_t __ret;
arch/cris/kernel/entry.S +3 -3
@@ -736,12 +736,12 @@ hw_bp_trig_ptr: * the grosser the code, at least with the gcc version in cris-dist-1.13. */ -/* int kernel_thread(int (*fn)(void *), void * arg, unsigned long flags) */ +/* int arch_kernel_thread(int (*fn)(void *), void * arg, unsigned long flags) */ /* r10 r11 r12 */ .text - .global kernel_thread -kernel_thread: + .global arch_kernel_thread +arch_kernel_thread: /* Save ARG for later. */ move.d $r11, $r13
arch/i386/kernel/process.c +2 -1
@@ -495,7 +495,7 @@ void release_segments(struct mm_struct */* * Create a kernel thread */ -int kernel_thread (int (*fn)(void *),void * arg,unsigned long flags) +int arch_kernel_thread (int (*fn)(void *),void * arg,unsigned long flags) {long retval, d0;
@@ -518,6 +518,7 @@ int kernel_thread(int (*fn)(void *), voi "r" (arg), "r" (fn), "b" (flags | CLONE_VM) : "memory"); + return retval; }
arch/ia64/kernel/process.c +2 -2
@@ -220,7 +220,7 @@ ia64_load_extra (struct task_struct *tas* | | <-- sp (lowest addr) * +---------------------+ * -* Note: if we get called through kernel_thread() then the memory +* Note: if we get called through arch_kernel_thread() then the memory * above "(highest addr)" is valid kernel stack memory that needs to * be copied as well. *
@@ -469,7 +469,7 @@ ia64_set_personality (struct elf64_hdr * }pid_t -kernel_thread (int (*fn)(void *),void *arg,unsigned long flags) +arch_kernel_thread (int (*fn)(void *),void *arg,unsigned long flags) {struct task_struct *parent = current;int result, tid;
arch/m68k/kernel/process.c +1 -1
@@ -124,7 +124,7 @@ void show_regs(struct pt_regs * regs)/* * Create a kernel thread */ -int kernel_thread (int (*fn)(void *),void * arg,unsigned long flags) +int arch_kernel_thread (int (*fn)(void *),void * arg,unsigned long flags) {int pid;mm_segment_t fs;
arch/mips/kernel/process.c +1 -1
@@ -155,7 +155,7 @@ void dump_thread(struct pt_regs *regs, s/* * Create a kernel thread */ -int kernel_thread (int (*fn)(void *),void * arg,unsigned long flags) +int arch_kernel_thread (int (*fn)(void *),void * arg,unsigned long flags) {long retval;
arch/mips64/kernel/process.c +1 -1
@@ -152,7 +152,7 @@ void dump_thread(struct pt_regs *regs, s/* * Create a kernel thread */ -int kernel_thread (int (*fn)(void *),void *arg,unsigned long flags) +int arch_kernel_thread (int (*fn)(void *),void *arg,unsigned long flags) {int retval;
arch/parisc/kernel/process.c +1 -1
@@ -118,7 +118,7 @@ void machine_heartbeat(void)*/ extern pid_t __kernel_thread (int (*fn)(void *),void *arg,unsigned long flags); -pid_t kernel_thread (int (*fn)(void *),void *arg,unsigned long flags) +pid_t arch_kernel_thread (int (*fn)(void *),void *arg,unsigned long flags) {/*
arch/ppc/kernel/misc.S +2 -2
@@ -899,9 +899,9 @@ _GLOBAL(cvt_df) /* * Create a kernel thread - * kernel_thread(fn, arg, flags) + * arch_kernel_thread(fn, arg, flags) */ -_GLOBAL(kernel_thread) +_GLOBAL(arch_kernel_thread) mr r6,r3 /* function */ ori r3,r5,CLONE_VM /* flags */ li r0,__NR_clone
arch/ppc64/kernel/misc.S +2 -2
@@ -493,9 +493,9 @@ _GLOBAL(cvt_df) /* * Create a kernel thread - * kernel_thread(fn, arg, flags) + * arch_kernel_thread(fn, arg, flags) */ -_GLOBAL(kernel_thread) +_GLOBAL(arch_kernel_thread) mr r6,r3 /* function */ ori r3,r5,CLONE_VM /* flags */ li r0,__NR_clone
arch/s390/kernel/process.c +1 -1
@@ -105,7 +105,7 @@ void show_regs(struct pt_regs *regs)show_trace ((unsigned long *) regs->gprs[15 ]); } -int kernel_thread (int (*fn)(void *),void * arg,unsigned long flags) +int arch_kernel_thread (int (*fn)(void *),void * arg,unsigned long flags) {int clone_arg = flags |CLONE_VM ;int retval;
arch/s390x/kernel/process.c +1 -1
@@ -102,7 +102,7 @@ void show_regs(struct pt_regs *regs)show_trace ((unsigned long *) regs->gprs[15 ]); } -int kernel_thread (int (*fn)(void *),void * arg,unsigned long flags) +int arch_kernel_thread (int (*fn)(void *),void * arg,unsigned long flags) {int clone_arg = flags |CLONE_VM ;int retval;
arch/sh/kernel/process.c +1 -1
@@ -118,7 +118,7 @@ void free_task_struct(struct task_struct* This is the mechanism for creating a new kernel thread. * */ -int kernel_thread (int (*fn)(void *),void * arg,unsigned long flags) +int arch_kernel_thread (int (*fn)(void *),void * arg,unsigned long flags) {/* Don't use this in BL=1(cli). Or else, CPU resets! */ registerunsigned long __sc0 __asm__ ("r0" ); register unsigned long __sc3 __asm__ ("r3") = __NR_clone;
arch/sparc/kernel/process.c +1 -1
@@ -676,7 +676,7 @@ out:* a system call from a "real" process, but the process memory space will * not be free'd until both the parent and the child have exited. */ -pid_t kernel_thread (int (*fn)(void *),void * arg,unsigned long flags) +pid_t arch_kernel_thread (int (*fn)(void *),void * arg,unsigned long flags) {long retval;
arch/sparc64/kernel/process.c +1 -1
@@ -658,7 +658,7 @@ int copy_thread(int nr, unsigned long cl* a system call from a "real" process, but the process memory space will * not be free'd until both the parent and the child have exited. */ -pid_t kernel_thread (int (*fn)(void *),void * arg,unsigned long flags) +pid_t arch_kernel_thread (int (*fn)(void *),void * arg,unsigned long flags) {long retval;
arch/um/kernel/process_kern.c +2 -2
@@ -171,14 +171,14 @@ static int new_thread_proc(void *stack)os_usr1_process (os_getpid ()); } -int kernel_thread (int (*fn)(void *),void * arg,unsigned long flags) +int arch_kernel_thread (int (*fn)(void *),void * arg,unsigned long flags) {int pid; current->thread.request.u.thread.proc = fn; current->thread.request.u.thread.arg = arg; pid =do_fork (CLONE_VM | flags,0 ,NULL ,0 ); -if (pid <0 )panic ("do_fork failed in kernel_thread" ); +if (pid <0 )panic ("do_fork failed in arch_kernel_thread" );return (pid); }
fs/exec.c +4 -2
@@ -559,8 +559,10 @@ int flush_old_exec(struct linux_binprm * current->sas_ss_sp = current->sas_ss_size =0 ; -if (current->euid == current->uid && current->egid == current->gid) +if (current->euid == current->uid && current->egid == current->gid) { current->mm->dumpable =1 ; + current->task_dumpable =1 ; + } name = bprm->filename;for (i=0 ; (ch = *(name++)) !='\0' ;) {if (ch =='/' )
@@ -952,7 +954,7 @@ int do_coredump(long signr, struct pt_re binfmt = current->binfmt;if (!binfmt || !binfmt->core_dump) goto fail; -if (!current->mm->dumpable) +if (!is_dumpable (current)) goto fail; current->mm->dumpable =0 ;if (current->rlim[RLIMIT_CORE ].rlim_cur < binfmt->min_coredump)
include/asm-alpha/processor.h +1 -1
@@ -119,7 +119,7 @@ struct task_struct;extern void release_thread (struct task_struct *);/* Create a kernel thread without removing it from tasklists. */ -extern long kernel_thread (int (*fn)(void *),void *arg,unsigned long flags); +extern long arch_kernel_thread (int (*fn)(void *),void *arg,unsigned long flags);#define copy_segments (tsk, mm) do { } while (0)#define release_segments (mm) do { } while (0)
include/asm-arm/processor.h +1 -1
@@ -117,7 +117,7 @@ extern void __free_task_struct(struct ta/* * Create a new kernel thread */ -extern int kernel_thread (int (*fn)(void *),void *arg,unsigned long flags); +extern int arch_kernel_thread (int (*fn)(void *),void *arg,unsigned long flags);#endif
include/asm-cris/processor.h +1 -1
@@ -81,7 +81,7 @@ struct thread_struct {#define INIT_THREAD { \ 0, 0, 0x20 }/* ccr = int enable, nothing else */ -extern int kernel_thread (int (*fn)(void *),void * arg,unsigned long flags); +extern int arch_kernel_thread (int (*fn)(void *),void * arg,unsigned long flags);/* give the thread a program location * set user-mode (The 'U' flag (User mode flag) is CCR/DCCR bit 8)
include/asm-i386/processor.h +1 -1
@@ -433,7 +433,7 @@ extern void release_thread(struct task_s/* * create a kernel thread without removing it from tasklists */ -extern int kernel_thread (int (*fn)(void *),void * arg,unsigned long flags); +extern int arch_kernel_thread (int (*fn)(void *),void * arg,unsigned long flags);/* Copy and release all segment info associated with a VM */ extern void copy_segments (struct task_struct *p,struct mm_struct * mm);
include/asm-ia64/processor.h +1 -1
@@ -476,7 +476,7 @@ struct task_struct;* do_basic_setup() and the timing is such that free_initmem() has * been called already. */ -extern int kernel_thread (int (*fn)(void *),void *arg,unsigned long flags); +extern int arch_kernel_thread (int (*fn)(void *),void *arg,unsigned long flags);/* Copy and release all segment info associated with a VM */ #define copy_segments (tsk, mm) do { } while (0)
include/asm-m68k/processor.h +1 -1
@@ -105,7 +105,7 @@ static inline void release_thread(struct { } -extern int kernel_thread (int (*fn)(void *),void * arg,unsigned long flags); +extern int arch_kernel_thread (int (*fn)(void *),void * arg,unsigned long flags);#define copy_segments (tsk, mm) do { } while (0)#define release_segments (mm) do { } while (0)
include/asm-mips/processor.h +1 -1
@@ -186,7 +186,7 @@ struct thread_struct {/* Free all resources held by a thread. */ #define release_thread (thread) do { } while(0) -extern int kernel_thread (int (*fn)(void *),void * arg,unsigned long flags); +extern int arch_kernel_thread (int (*fn)(void *),void * arg,unsigned long flags);/* Copy and release all segment info associated with a VM */ #define copy_segments (p, mm) do { } while(0)
include/asm-mips64/processor.h +1 -1
@@ -245,7 +245,7 @@ struct thread_struct {/* Free all resources held by a thread. */ #define release_thread (thread) do { } while(0) -extern int kernel_thread (int (*fn)(void *),void * arg,unsigned long flags); +extern int arch_kernel_thread (int (*fn)(void *),void * arg,unsigned long flags);/* Copy and release all segment info associated with a VM */ #define copy_segments (p, mm) do { } while(0)
include/asm-parisc/processor.h +1 -1
@@ -305,7 +305,7 @@ struct task_struct;/* Free all resources held by a thread. */ extern void release_thread (struct task_struct *); -extern int kernel_thread (int (*fn)(void *),void * arg,unsigned long flags); +extern int arch_kernel_thread (int (*fn)(void *),void * arg,unsigned long flags);#define copy_segments (tsk, mm) do { } while (0)#define release_segments (mm) do { } while (0)
include/asm-ppc/processor.h +1 -1
@@ -593,7 +593,7 @@ void release_thread(struct task_struct */* * Create a new kernel thread. */ -extern long kernel_thread (int (*fn)(void *),void *arg,unsigned long flags); +extern long arch_kernel_thread (int (*fn)(void *),void *arg,unsigned long flags);/* * Bus types
include/asm-ppc64/processor.h +1 -1
@@ -609,7 +609,7 @@ void release_thread(struct task_struct */* * Create a new kernel thread. */ -extern long kernel_thread (int (*fn)(void *),void *arg,unsigned long flags); +extern long arch_kernel_thread (int (*fn)(void *),void *arg,unsigned long flags);/* * Bus types
include/asm-s390/processor.h +1 -1
@@ -113,7 +113,7 @@ struct mm_struct;/* Free all resources held by a thread. */ extern void release_thread (struct task_struct *); -extern int kernel_thread (int (*fn)(void *),void * arg,unsigned long flags); +extern int arch_kernel_thread (int (*fn)(void *),void * arg,unsigned long flags);/* Copy and release all segment info associated with a VM */ #define copy_segments (nr, mm) do { } while (0)
include/asm-s390x/processor.h +1 -1
@@ -127,7 +127,7 @@ struct mm_struct;/* Free all resources held by a thread. */ extern void release_thread (struct task_struct *); -extern int kernel_thread (int (*fn)(void *),void * arg,unsigned long flags); +extern int arch_kernel_thread (int (*fn)(void *),void * arg,unsigned long flags);/* Copy and release all segment info associated with a VM */ #define copy_segments (nr, mm) do { } while (0)
include/asm-sh/processor.h +1 -1
@@ -137,7 +137,7 @@ extern void release_thread(struct task_s/* * create a kernel thread without removing it from tasklists */ -extern int kernel_thread (int (*fn)(void *),void * arg,unsigned long flags); +extern int arch_kernel_thread (int (*fn)(void *),void * arg,unsigned long flags);/* * Bus types
include/asm-sparc/processor.h +1 -1
@@ -146,7 +146,7 @@ extern __inline__ void start_thread(stru/* Free all resources held by a thread. */ #define release_thread (tsk) do { } while(0) -extern pid_t kernel_thread (int (*fn)(void *),void * arg,unsigned long flags); +extern pid_t arch_kernel_thread (int (*fn)(void *),void * arg,unsigned long flags);#define copy_segments (tsk, mm) do { } while (0)
include/asm-sparc64/processor.h +1 -1
@@ -270,7 +270,7 @@ do { \/* Free all resources held by a thread. */ #define release_thread (tsk) do { } while(0) -extern pid_t kernel_thread (int (*fn)(void *),void * arg,unsigned long flags); +extern pid_t arch_kernel_thread (int (*fn)(void *),void * arg,unsigned long flags);#define copy_segments (tsk, mm) do { } while (0)#define release_segments (mm) do { } while (0)
include/linux/sched.h +5 -0
@@ -362,6 +362,7 @@ struct task_struct {/* ??? */ unsigned long personality; int did_exec:1; + unsigned task_dumpable:1;pid_t pid;pid_t pgrp;pid_t tty_old_pgrp;
@@ -485,6 +486,8 @@ struct task_struct {#define PT_TRACESYSGOOD 0x00000008#define PT_PTRACE_CAP 0x00000010/* ptracer can follow suid-exec */ +#define is_dumpable (tsk) ((tsk)->task_dumpable && (tsk)->mm->dumpable) +/* * Limit the stack by to some sane default: root can always * increase this limit if needed.. 8MB seems reasonable.
@@ -848,6 +851,8 @@ extern void FASTCALL(remove_wait_queue(wextern void wait_task_inactive (task_t * p);extern void kick_if_running (task_t * p); +extern long kernel_thread (int (*fn)(void *),void * arg,unsigned long flags); +#define __wait_event (wq, condition) \ do { \
kernel/fork.c +26 -0
@@ -28,6 +28,7 @@#include <asm/pgalloc.h> #include <asm/uaccess.h> #include <asm/mmu_context.h> +#include <asm/processor.h> /* The idle threads do not count.. */ int nr_threads;
@@ -575,6 +576,31 @@ static inline void copy_flags(unsigned l p->flags = new_flags; } +long kernel_thread (int (*fn)(void *),void * arg,unsigned long flags) +{ +struct task_struct *task = current; +unsigned old_task_dumpable; +long ret; + +/* lock out any potential ptracer */ +task_lock (task); +if (task->ptrace) { +task_unlock (task); +return -EPERM ; + } + + old_task_dumpable = task->task_dumpable; + task->task_dumpable =0 ; +task_unlock (task); + + ret =arch_kernel_thread (fn, arg, flags); + +/* never reached in child process, only in parent */ + current->task_dumpable = old_task_dumpable; + +return ret; +} +/* * Ok, this is the main fork-routine. It copies the system process * information (task[nr]) and sets up the necessary registers. It also
kernel/ptrace.c +7 -1
@@ -21,6 +21,10 @@*/ int ptrace_check_attach (struct task_struct *child,int kill) { +mb (); +if (!is_dumpable (child)) +return -EPERM ; +if (!(child->ptrace &PT_PTRACED ))return -ESRCH ;
@@ -57,7 +61,7 @@ int ptrace_attach(struct task_struct *ta (current->gid != task->gid)) && !capable(CAP_SYS_PTRACE)) goto bad;rmb (); -if (!task->mm->dumpable && !capable (CAP_SYS_PTRACE )) +if (!is_dumpable (task) && !capable (CAP_SYS_PTRACE )) goto bad;/* the same process cannot be attached many times */ if (task->ptrace &PT_PTRACED )
@@ -123,6 +127,8 @@ int access_process_vm(struct task_struct/* Worry about races with exit() */ task_lock (tsk); mm = tsk->mm; +if (!is_dumpable (tsk) || (&init_mm == mm)) + mm =NULL ;if (mm)atomic_inc (&mm->mm_users);task_unlock (tsk);
kernel/sys.c +3 -2
@@ -1286,7 +1286,7 @@ asmlinkage long sys_prctl(int option, un error =put_user (current->pdeath_signal, (int *)arg2);break ;case PR_GET_DUMPABLE : -if (current->mm->dumpable) +if (is_dumpable (current)) error =1 ;break ;case PR_SET_DUMPABLE :
@@ -1294,7 +1294,8 @@ asmlinkage long sys_prctl(int option, un error = -EINVAL ;break ; } - current->mm->dumpable = arg2; +if (is_dumpable (current)) + current->mm->dumpable = arg2;break ;case PR_SET_UNALIGN :#ifdef SET_UNALIGN_CTL
Quoted 6 lines · Alan Cox
Vulnerability: CAN-2003-0127
The Linux 2.2 and Linux 2.4 kernels have a flaw in ptrace. This hole allows local users to obtain full privileges. Remote exploitation of this hole is not possible. Linux 2.5 is not believed to be vulnerable.
Quoted 8 lines
Linux 2.2.25 has been released to correct Linux 2.2. It contains no other changes. The bug fixes that would have been in 2.2.5pre1 will now appear in 2.2.26pre1. The patch will apply directly to most older 2.2 releases.
A patch for Linux 2.4.20/Linux 2.4.21pre is attached. The patch also subtly changes the
PR_SET_DUMPABLEprctl. We believe this is neccessary and that it will not affect any software. The functionality change is specific to unusual debugging situations.
I've attached a patch against 2.4.21pre5
arch/alpha/kernel/entry.S +2 -2
@@ -231,12 +231,12 @@ .end kernel_clone /* - * kernel_thread(fn, arg, clone_flags) + * arch_kernel_thread(fn, arg, clone_flags) */ .align 3 .globl kernel_thread .ent kernel_thread -kernel_thread: +arch_kernel_thread: ldgp $29,0($27) /* we can be called from a module */ .frame $30, 4*8, $26 subq $30,4*8,$30
arch/arm/kernel/process.c +1 -1
@@ -366,7 +366,7 @@* a system call from a "real" process, but the process memory space will * not be free'd until both the parent and the child have exited. */ -pid_t kernel_thread (int (*fn)(void *),void *arg,unsigned long flags) +pid_t arch_kernel_thread (int (*fn)(void *),void *arg,unsigned long flags) {pid_t __ret;
arch/cris/kernel/entry.S +3 -3
@@ -739,12 +739,12 @@ * the grosser the code, at least with the gcc version in cris-dist-1.13. */ -/* int kernel_thread(int (*fn)(void *), void * arg, unsigned long flags) */ +/* int arch_kernel_thread(int (*fn)(void *), void * arg, unsigned long flags) */ /* r10 r11 r12 */ .text - .global kernel_thread -kernel_thread: + .global arch_kernel_thread +arch_kernel_thread: /* Save ARG for later. */ move.d $r11, $r13
arch/i386/kernel/process.c +1 -1
@@ -485,7 +485,7 @@/* * Create a kernel thread */ -int kernel_thread (int (*fn)(void *),void * arg,unsigned long flags) +int arch_kernel_thread (int (*fn)(void *),void * arg,unsigned long flags) {long retval, d0;
arch/ia64/kernel/process.c +2 -2
@@ -230,7 +230,7 @@* | | <-- sp (lowest addr) * +---------------------+ * -* Note: if we get called through kernel_thread() then the memory +* Note: if we get called through arch_kernel_thread() then the memory * above "(highest addr)" is valid kernel stack memory that needs to * be copied as well. *
@@ -485,7 +485,7 @@ }pid_t -kernel_thread (int (*fn)(void *),void *arg,unsigned long flags) +arch_kernel_thread (int (*fn)(void *),void *arg,unsigned long flags) {struct task_struct *parent = current;int result, tid;
arch/m68k/kernel/process.c +1 -1
@@ -124,7 +124,7 @@/* * Create a kernel thread */ -int kernel_thread (int (*fn)(void *),void * arg,unsigned long flags) +int arch_kernel_thread (int (*fn)(void *),void * arg,unsigned long flags) {int pid;mm_segment_t fs;
arch/mips/kernel/process.c +1 -1
@@ -152,7 +152,7 @@/* * Create a kernel thread */ -int kernel_thread (int (*fn)(void *),void * arg,unsigned long flags) +int arch_kernel_thread (int (*fn)(void *),void * arg,unsigned long flags) {long retval;
arch/mips64/kernel/process.c +1 -1
@@ -151,7 +151,7 @@/* * Create a kernel thread */ -int kernel_thread (int (*fn)(void *),void *arg,unsigned long flags) +int arch_kernel_thread (int (*fn)(void *),void *arg,unsigned long flags) {int retval;
arch/parisc/kernel/process.c +1 -1
@@ -169,7 +169,7 @@*/ extern pid_t __kernel_thread (int (*fn)(void *),void *arg,unsigned long flags); -pid_t kernel_thread (int (*fn)(void *),void *arg,unsigned long flags) +pid_t arch_kernel_thread (int (*fn)(void *),void *arg,unsigned long flags) {/*
arch/ppc/kernel/misc.S +2 -2
@@ -899,9 +899,9 @@ /* * Create a kernel thread - * kernel_thread(fn, arg, flags) + * arch_kernel_thread(fn, arg, flags) */ -_GLOBAL(kernel_thread) +_GLOBAL(arch_kernel_thread) mr r6,r3 /* function */ ori r3,r5,CLONE_VM /* flags */ li r0,__NR_clone
arch/ppc64/kernel/misc.S +2 -2
@@ -481,9 +481,9 @@ /* * Create a kernel thread - * kernel_thread(fn, arg, flags) + * arch_kernel_thread(fn, arg, flags) */ -_GLOBAL(kernel_thread) +_GLOBAL(arch_kernel_thread) mr r6,r3 /* function */ ori r3,r5,CLONE_VM /* flags */ li r0,__NR_clone
arch/s390/kernel/process.c +1 -1
@@ -105,7 +105,7 @@show_trace ((unsigned long *) regs->gprs[15 ]); } -int kernel_thread (int (*fn)(void *),void * arg,unsigned long flags) +int arch_kernel_thread (int (*fn)(void *),void * arg,unsigned long flags) {int clone_arg = flags |CLONE_VM ;int retval;
arch/s390x/kernel/process.c +1 -1
@@ -102,7 +102,7 @@show_trace ((unsigned long *) regs->gprs[15 ]); } -int kernel_thread (int (*fn)(void *),void * arg,unsigned long flags) +int arch_kernel_thread (int (*fn)(void *),void * arg,unsigned long flags) {int clone_arg = flags |CLONE_VM ;int retval;
arch/sh/kernel/process.c +1 -1
@@ -118,7 +118,7 @@* This is the mechanism for creating a new kernel thread. * */ -int kernel_thread (int (*fn)(void *),void * arg,unsigned long flags) +int arch_kernel_thread (int (*fn)(void *),void * arg,unsigned long flags) {/* Don't use this in BL=1(cli). Or else, CPU resets! */ registerunsigned long __sc0 __asm__ ("r0" ); register unsigned long __sc3 __asm__ ("r3") = __NR_clone;
arch/sparc/kernel/process.c +1 -1
@@ -676,7 +676,7 @@* a system call from a "real" process, but the process memory space will * not be free'd until both the parent and the child have exited. */ -pid_t kernel_thread (int (*fn)(void *),void * arg,unsigned long flags) +pid_t arch_kernel_thread (int (*fn)(void *),void * arg,unsigned long flags) {long retval;
arch/sparc64/kernel/process.c +1 -1
@@ -673,7 +673,7 @@* a system call from a "real" process, but the process memory space will * not be free'd until both the parent and the child have exited. */ -pid_t kernel_thread (int (*fn)(void *),void * arg,unsigned long flags) +pid_t arch_kernel_thread (int (*fn)(void *),void * arg,unsigned long flags) {long retval;
fs/exec.c +4 -2
@@ -576,8 +576,10 @@ current->sas_ss_sp = current->sas_ss_size =0 ; -if (current->euid == current->uid && current->egid == current->gid) +if (current->euid == current->uid && current->egid == current->gid) { current->mm->dumpable =1 ; + current->task_dumpable =1 ; + } name = bprm->filename;for (i=0 ; (ch = *(name++)) !='\0' ;) {if (ch =='/' )
@@ -1085,7 +1087,7 @@ binfmt = current->binfmt;if (!binfmt || !binfmt->core_dump) goto fail; -if (!current->mm->dumpable) +if (!is_dumpable (current)) goto fail; current->mm->dumpable =0 ;if (current->rlim[RLIMIT_CORE ].rlim_cur < binfmt->min_coredump)
include/asm-alpha/processor.h +1 -1
@@ -119,7 +119,7 @@extern void release_thread (struct task_struct *);/* Create a kernel thread without removing it from tasklists. */ -extern long kernel_thread (int (*fn)(void *),void *arg,unsigned long flags); +extern long arch_kernel_thread (int (*fn)(void *),void *arg,unsigned long flags);#define copy_segments (tsk, mm) do { } while (0)#define release_segments (mm) do { } while (0)
include/asm-arm/processor.h +1 -1
@@ -117,7 +117,7 @@/* * Create a new kernel thread */ -extern int kernel_thread (int (*fn)(void *),void *arg,unsigned long flags); +extern int arch_kernel_thread (int (*fn)(void *),void *arg,unsigned long flags);#endif
include/asm-cris/processor.h +1 -1
@@ -81,7 +81,7 @@#define INIT_THREAD { \ 0, 0, 0x20 }/* ccr = int enable, nothing else */ -extern int kernel_thread (int (*fn)(void *),void * arg,unsigned long flags); +extern int arch_kernel_thread (int (*fn)(void *),void * arg,unsigned long flags);/* give the thread a program location * set user-mode (The 'U' flag (User mode flag) is CCR/DCCR bit 8)
include/asm-i386/processor.h +1 -1
@@ -433,7 +433,7 @@/* * create a kernel thread without removing it from tasklists */ -extern int kernel_thread (int (*fn)(void *),void * arg,unsigned long flags); +extern int arch_kernel_thread (int (*fn)(void *),void * arg,unsigned long flags);/* Copy and release all segment info associated with a VM */ extern void copy_segments (struct task_struct *p,struct mm_struct * mm);
include/asm-ia64/processor.h +1 -1
@@ -372,7 +372,7 @@* do_basic_setup() and the timing is such that free_initmem() has * been called already. */ -extern int kernel_thread (int (*fn)(void *),void *arg,unsigned long flags); +extern int arch_kernel_thread (int (*fn)(void *),void *arg,unsigned long flags);/* Copy and release all segment info associated with a VM */ #define copy_segments (tsk, mm) do { } while (0)
include/asm-m68k/processor.h +1 -1
@@ -105,7 +105,7 @@ { } -extern int kernel_thread (int (*fn)(void *),void * arg,unsigned long flags); +extern int arch_kernel_thread (int (*fn)(void *),void * arg,unsigned long flags);#define copy_segments (tsk, mm) do { } while (0)#define release_segments (mm) do { } while (0)
include/asm-mips/processor.h +1 -1
@@ -188,7 +188,7 @@/* Free all resources held by a thread. */ #define release_thread (thread) do { } while(0) -extern int kernel_thread (int (*fn)(void *),void * arg,unsigned long flags); +extern int arch_kernel_thread (int (*fn)(void *),void * arg,unsigned long flags);/* Copy and release all segment info associated with a VM */ #define copy_segments (p, mm) do { } while(0)
include/asm-mips64/processor.h +1 -1
@@ -231,7 +231,7 @@/* Free all resources held by a thread. */ #define release_thread (thread) do { } while(0) -extern int kernel_thread (int (*fn)(void *),void * arg,unsigned long flags); +extern int arch_kernel_thread (int (*fn)(void *),void * arg,unsigned long flags);/* Copy and release all segment info associated with a VM */ #define copy_segments (p, mm) do { } while(0)
include/asm-parisc/processor.h +1 -1
@@ -292,7 +292,7 @@/* Free all resources held by a thread. */ extern void release_thread (struct task_struct *); -extern int kernel_thread (int (*fn)(void *),void * arg,unsigned long flags); +extern int arch_kernel_thread (int (*fn)(void *),void * arg,unsigned long flags);extern void map_hpux_gateway_page (struct task_struct *tsk,struct mm_struct *mm);
include/asm-ppc/processor.h +1 -1
@@ -622,7 +622,7 @@/* * Create a new kernel thread. */ -extern long kernel_thread (int (*fn)(void *),void *arg,unsigned long flags); +extern long arch_kernel_thread (int (*fn)(void *),void *arg,unsigned long flags);/* * Bus types
include/asm-ppc64/processor.h +1 -1
@@ -602,7 +602,7 @@/* * Create a new kernel thread. */ -extern long kernel_thread (int (*fn)(void *),void *arg,unsigned long flags); +extern long arch_kernel_thread (int (*fn)(void *),void *arg,unsigned long flags);/* * Bus types
include/asm-s390/processor.h +1 -1
@@ -113,7 +113,7 @@/* Free all resources held by a thread. */ extern void release_thread (struct task_struct *); -extern int kernel_thread (int (*fn)(void *),void * arg,unsigned long flags); +extern int arch_kernel_thread (int (*fn)(void *),void * arg,unsigned long flags);/* Copy and release all segment info associated with a VM */ #define copy_segments (nr, mm) do { } while (0)
include/asm-s390x/processor.h +1 -1
@@ -128,7 +128,7 @@/* Free all resources held by a thread. */ extern void release_thread (struct task_struct *); -extern int kernel_thread (int (*fn)(void *),void * arg,unsigned long flags); +extern int arch_kernel_thread (int (*fn)(void *),void * arg,unsigned long flags);/* Copy and release all segment info associated with a VM */ #define copy_segments (nr, mm) do { } while (0)
include/asm-sh/processor.h +1 -1
@@ -137,7 +137,7 @@/* * create a kernel thread without removing it from tasklists */ -extern int kernel_thread (int (*fn)(void *),void * arg,unsigned long flags); +extern int arch_kernel_thread (int (*fn)(void *),void * arg,unsigned long flags);/* * Bus types
include/asm-sparc/processor.h +1 -1
@@ -146,7 +146,7 @@/* Free all resources held by a thread. */ #define release_thread (tsk) do { } while(0) -extern pid_t kernel_thread (int (*fn)(void *),void * arg,unsigned long flags); +extern pid_t arch_kernel_thread (int (*fn)(void *),void * arg,unsigned long flags);#define copy_segments (tsk, mm) do { } while (0)
include/asm-sparc64/processor.h +1 -1
@@ -270,7 +270,7 @@/* Free all resources held by a thread. */ #define release_thread (tsk) do { } while(0) -extern pid_t kernel_thread (int (*fn)(void *),void * arg,unsigned long flags); +extern pid_t arch_kernel_thread (int (*fn)(void *),void * arg,unsigned long flags);#define copy_segments (tsk, mm) do { } while (0)#define release_segments (mm) do { } while (0)
include/linux/sched.h +4 -0
@@ -162,6 +162,7 @@extern void flush_scheduled_tasks (void );extern int start_context_thread (void );extern int current_is_keventd (void ); +extern long kernel_thread (int (*fn)(void *),void * arg,unsigned long flags);#if CONFIG_SMP extern void set_cpus_allowed (struct task_struct *p,unsigned long new_mask);
@@ -345,6 +346,7 @@/* ??? */ unsigned long personality; int did_exec:1; + unsigned task_dumpable:1;pid_t pid;pid_t pgrp;pid_t tty_old_pgrp;
@@ -454,6 +456,8 @@#define PT_TRACESYSGOOD 0x00000008#define PT_PTRACE_CAP 0x00000010/* ptracer can follow suid-exec */ +#define is_dumpable (tsk) ((tsk)->task_dumpable && (tsk)->mm->dumpable) +/* * Limit the stack by to some sane default: root can always * increase this limit if needed.. 8MB seems reasonable.
kernel/fork.c +26 -0
@@ -27,6 +27,7 @@#include <asm/pgalloc.h> #include <asm/uaccess.h> #include <asm/mmu_context.h> +#include <asm/processor.h> /* The idle threads do not count.. */ int nr_threads;
@@ -565,6 +566,31 @@ p->flags = new_flags; } +long kernel_thread (int (*fn)(void *),void * arg,unsigned long flags) +{ +struct task_struct *task = current; +unsigned old_task_dumpable; +long ret; + +/* lock out any potential ptracer */ +task_lock (task); +if (task->ptrace) { +task_unlock (task); +return -EPERM ; + } + + old_task_dumpable = task->task_dumpable; + task->task_dumpable =0 ; +task_unlock (task); + + ret =arch_kernel_thread (fn, arg, flags); + +/* never reached in child process, only in parent */ + current->task_dumpable = old_task_dumpable; + +return ret; +} +/* * Ok, this is the main fork-routine. It copies the system process * information (task[nr]) and sets up the necessary registers. It also
kernel/ptrace.c +7 -1
@@ -21,6 +21,10 @@*/ int ptrace_check_attach (struct task_struct *child,int kill) { +mb (); +if (!is_dumpable (child)) +return -EPERM ; +if (!(child->ptrace &PT_PTRACED ))return -ESRCH ;
@@ -70,7 +74,7 @@ (current->gid != task->gid)) && !capable(CAP_SYS_PTRACE)) goto bad;rmb (); -if (!task->mm->dumpable && !capable (CAP_SYS_PTRACE )) +if (!is_dumpable (task) && !capable (CAP_SYS_PTRACE )) goto bad;/* the same process cannot be attached many times */ if (task->ptrace &PT_PTRACED )
@@ -136,6 +140,8 @@/* Worry about races with exit() */ task_lock (tsk); mm = tsk->mm; +if (!is_dumpable (tsk) || (&init_mm == mm)) + mm =NULL ;if (mm)atomic_inc (&mm->mm_users);task_unlock (tsk);
kernel/sys.c +3 -2
@@ -1238,7 +1238,7 @@ error =put_user (current->pdeath_signal, (int *)arg2);break ;case PR_GET_DUMPABLE : -if (current->mm->dumpable) +if (is_dumpable (current)) error =1 ;break ;case PR_SET_DUMPABLE :
@@ -1246,7 +1246,8 @@ error = -EINVAL ;break ; } - current->mm->dumpable = arg2; +if (is_dumpable (current)) + current->mm->dumpable = arg2;break ;case PR_SET_UNALIGN :
Quoted 3 lines
I've attached a patch against 2.4.21pre5.
So what happens now?
Is this critical enough for 2.4.21 to go out? Or can it wait like some other fairly serious stuff such as the ext3 fixes? What about the current state of IDE?
Would it make sense to repackage 2.4.20 into something like 2.4.20-p1 or 2.4.20.1 with only the critical stuff applied?
Signature · 1 line
Tomas Szepe <[email protected]>
Quoted 4 lines · Tomas Szepe
Quoted 3 lines
I've attached a patch against 2.4.21pre5.
Quoted 8 lines
So what happens now?
Is this critical enough for 2.4.21 to go out? Or can it wait like some other fairly serious stuff such as the ext3 fixes? What about the current state of IDE?
Would it make sense to repackage 2.4.20 into something like 2.4.20-p1 or 2.4.20.1 with only the critical stuff applied?
FYI, I am currently testing Alans patch (cleaned up, the original does not patch cleanly) against 2.4.20 proper.
I can make this available if requested once I know it compiles and boots...
Regards
James Bourne
Signature · 16 lines
James Bourne, Supervisor Data Centre Operations Mount Royal College, Calgary, AB, CA www.mtroyal.ab.ca ****************************************************************************** This communication is intended for the use of the recipient to which it is addressed, and may contain confidential, personal, and or privileged information. Please contact the sender immediately if you are not the intended recipient of this communication, and do not copy, distribute, or take action relying on it. Any communication received in error, or subsequent reply, should be deleted or destroyed. ****************************************************************************** "There are only 10 types of people in this world: those who understand binary and those who don't."
Quoted 6 lines · Tomas Szepe
Is this critical enough for 2.4.21 to go out? Or can it wait like some other fairly serious stuff such as the ext3 fixes? What about the current state of IDE?
Would it make sense to repackage 2.4.20 into something like 2.4.20-p1 or 2.4.20.1 with only the critical stuff applied?
If you build your own kernels apply the patch, if you use vendor kernels then you can expect vendor kernel updates to appear or have already appeared
Quoted 7 lines
Quoted 4 lines · Tomas Szepe
Is this critical enough for 2.4.21 to go out? Or can it wait like some other fairly serious stuff such as the ext3 fixes? What about the current state of IDE?
Quoted 6 lines
Quoted 2 lines
Would it make sense to repackage 2.4.20 into something like 2.4.20-p1 or 2.4.20.1 with only the critical stuff applied?
If you build your own kernels apply the patch, if you use vendor kernels then you can expect vendor kernel updates to appear or have already appeared
You have avoided the question(s). 8)
Signature · 1 line
Tomas Szepe <[email protected]>
Quoted 7 lines · Tomas Szepe
Quoted 7 lines
Quoted 4 lines · Tomas Szepe
Is this critical enough for 2.4.21 to go out? Or can it wait like some other fairly serious stuff such as the ext3 fixes? What about the current state of IDE?
Quoted 8 lines
Quoted 6 lines
Quoted 2 lines
Would it make sense to repackage 2.4.20 into something like 2.4.20-p1 or 2.4.20.1 with only the critical stuff applied?
If you build your own kernels apply the patch, if you use vendor kernels then you can expect vendor kernel updates to appear or have already appeared
You have avoided the question(s). 8)
I think Alan's trying to teach us how to fish ;-)
That said, IMVHO something like this does constitute an argument for 2.4.20-p1 (due to the amount of change that's already racked up for 2.2.21).
Regards,
Neale.
Quoted 8 lines · Neale Banks
Quoted 6 lines · Tomas Szepe
Quoted 5 lines
If you build your own kernels apply the patch, if you use vendor kernels then you can expect vendor kernel updates to appear or have already appeared
Quoted 7 lines
Quoted 1 line
You have avoided the question(s). 8)
I think Alan's trying to teach us how to fish ;-)
That said, IMVHO something like this does constitute an argument for 2.4.20-p1 (due to the amount of change that's already racked up for 2.2.21).
Hi all,
There is a clean patch for 2.4.20 (taken from Alans original patch) at
http://www.hardrock.org/kernel/2.4.20/linux-2.4.20-ptrace.patch
I am currently using it on 3 production systems at work and it seems stable. You will notice processes which are not dumpable with this patch, as the output from ps ax will contain the process name in [] square brackets.
Regards
James Bourne
Quoted 2 lines
Regards,
Neale.
Signature · 16 lines
James Bourne, Supervisor Data Centre Operations Mount Royal College, Calgary, AB, CA www.mtroyal.ab.ca ****************************************************************************** This communication is intended for the use of the recipient to which it is addressed, and may contain confidential, personal, and or privileged information. Please contact the sender immediately if you are not the intended recipient of this communication, and do not copy, distribute, or take action relying on it. Any communication received in error, or subsequent reply, should be deleted or destroyed. ****************************************************************************** "There are only 10 types of people in this world: those who understand binary and those who don't."
Quoted 4 lines · Tomas Szepe
Quoted 3 lines
I've attached a patch against 2.4.21pre5.
Quoted 8 lines
So what happens now?
Is this critical enough for 2.4.21 to go out? Or can it wait like some other fairly serious stuff such as the ext3 fixes? What about the current state of IDE?
Would it make sense to repackage 2.4.20 into something like 2.4.20-p1 or 2.4.20.1 with only the critical stuff applied?
There shouldn't be a huge need to rush 2.4.21 as-is, really. If you want an immediate update, get the fix from your vendor.
Plus, it's a local root hole, and there are still tons of those left out there to squash.
Jeff
Hi!
Quoted 5 lines
Quoted 2 lines
Would it make sense to repackage 2.4.20 into something like 2.4.20-p1 or 2.4.20.1 with only the critical stuff applied?
There shouldn't be a huge need to rush 2.4.21 as-is, really. If you want an immediate update, get the fix from your vendor.
Many people are using self-compiled kernels and it would be better to have 2.4.21 out than having each person apply slightly different patch...
Quoted 2 lines
Plus, it's a local root hole, and there are still tons of those left out there to squash.
Really? Care to name a few?
Signature · 2 lines
Pavel Written on sharp zaurus, because my Velo1 broke. If you have Velo you don't need...
Quoted 7 lines · On Fri, 21 Mar 2003 22:17:08 +0100 Pavel Machek <[email protected]> wrote:
Hi!
Quoted 5 lines
Quoted 2 lines
Would it make sense to repackage 2.4.20 into something like 2.4.20-p1 or 2.4.20.1 with only the critical stuff applied?
There shouldn't be a huge need to rush 2.4.21 as-is, really. If you want an immediate update, get the fix from your vendor.
Sorry Jeff,
this comment must obviously be flagged with a big community-buh. It is very likely that most readers of LKML read/write here _not_ because they are looking for a _vendor_ specific thing, but because they feel to a certain extent as part of a linux-community and (partly) want to give something back for the good things they got from it.
It is no hot news over here that linux does _not_ live because of 5 different (or more?) "vendor"-kernels, but solely because there is _the_ official kernel.org kernel (releases).
For me personally I must say there is nothing I care less about than a vendor-kernel - not because I think they are doing a bad job _in general_, but because they are expected to be _less_ tested than "official" releases. My favourite vendor (which I won't name here) managed to create a kernel that does not even completely boot on about 8 of 10 of my test-beds. And guess what:
replacing the patched-to-death vendor kernel with kernel.org release makes all of them work (at least boot correctly).
So IMHO: if there is a-known-to-work patch for the discussed exploit it should be released as _some_ (pre-)release for 2.4 quickly, and thanks must go to alan for taking quick approach on 2.2.
Signature · 2 lines
Regards, Stephan
Quoted 24 lines · Stephan von Krawczynski
Quoted 8 lines · On Fri, 21 Mar 2003 22:17:08 +0100 Pavel Machek <[email protected]> wrote:
Hi!
Quoted 5 lines
Quoted 2 lines
Would it make sense to repackage 2.4.20 into something like 2.4.20-p1 or 2.4.20.1 with only the critical stuff applied?
There shouldn't be a huge need to rush 2.4.21 as-is, really. If you want an immediate update, get the fix from your vendor.
Sorry Jeff,
this comment must obviously be flagged with a big community-buh. It is very likely that most readers of LKML read/write here _not_ because they are looking for a _vendor_ specific thing, but because they feel to a certain extent as part of a linux-community and (partly) want to give something back for the good things they got from it.
It is no hot news over here that linux does _not_ live because of 5 different (or more?) "vendor"-kernels, but solely because there is _the_ official kernel.org kernel (releases).
[...]
Quoted 3 lines
So IMHO: if there is a-known-to-work patch for the discussed exploit it should be released as _some_ (pre-)release for 2.4 quickly, and thanks must go to alan for taking quick approach on 2.2.
I think you misunderstand my point: there was a patch posted which fixes the ptrace issue. If you want to fix your kernel, there are two options: either you are capable enough apply that patch yourself, otherwise get a kernel update from a vendor. Marcelo is under no obligation to provide hot-fix kernels...
As for Alan, his task was easier: Guess how many patches are in 2.2.25?
One. ;-)
Jeff
Dear diary, on Sun, Mar 23, 2003 at 02:41:47PM CET, I got a letter, where Jeff Garzik <[email protected]> told me, that...
Quoted 35 lines
Quoted 26 lines · Stephan von Krawczynski
Quoted 8 lines · On Fri, 21 Mar 2003 22:17:08 +0100 Pavel Machek <[email protected]> wrote:
Hi!
Quoted 5 lines
Quoted 2 lines
Would it make sense to repackage 2.4.20 into something like 2.4.20-p1 or 2.4.20.1 with only the critical stuff applied?
There shouldn't be a huge need to rush 2.4.21 as-is, really. If you want an immediate update, get the fix from your vendor.
Sorry Jeff,
this comment must obviously be flagged with a big community-buh. It is very likely that most readers of LKML read/write here _not_ because they are looking for a _vendor_ specific thing, but because they feel to a certain extent as part of a linux-community and (partly) want to give something back
for the good things they got from it.
It is no hot news over here that linux does _not_ live because of 5 different
(or more?) "vendor"-kernels, but solely because there is _the_ official kernel.org kernel (releases).[...]
Quoted 5 lines
So IMHO: if there is a-known-to-work patch for the discussed exploit it should
be released as _some_ (pre-)release for 2.4 quickly, and thanks must go to alan
for taking quick approach on 2.2.
Quoted 5 lines
I think you misunderstand my point: there was a patch posted which fixes the ptrace issue. If you want to fix your kernel, there are two
options: either you are capable enough apply that patch yourself, otherwise get a kernel update from a vendor. Marcelo is under no obligation to provide hot-fix kernels...
Just out of curiosity, Marcelo, when could we see 2.4.21-rc1 ? What is yet expected to go in before rc, and how long it could take to have 2.4.21 final out given that no other critical bugs would be discovered?
The release cycle is probably getting indeed kind of ... long; that could be ok for ie. 2.2, but it would be nice to have shorter development cycle for the pair of latest two development lines. Sure that the larger changes need to get enough of testing, but then we could maybe spend the months rather between the -rc releases than both -pre and -rc releases...?
Thanks in advance,
Signature · 6 lines
Petr "Pasky" Baudis . The pure and simple truth is rarely pure and never simple. -- Oscar Wilde . Stuff: http://pasky.ji.cz/
Hi Jeff!
Quoted 4 lines
I think you misunderstand my point: there was a patch posted which fixes the ptrace issue. If you want to fix your kernel, there are two
options: either you are capable enough apply that patch yourself, otherwise get a kernel update from a vendor.
Sorry, but you seem to forget that a significant amount of people use kernel.org kernels, but don't monitor LKML nor are able to choose from the various patches floating there the most appropriate fix.
If 2.4.21 were expected in a few days, it would make sense to delay the fix, but this doesn't seem to be the case, so I think that a hot-fix really should be released quickly (either as 2.4.20.1 or 2.4.21)
Quoted 2 lines
As for Alan, his task was easier: Guess how many patches are in 2.2.25?
One. ;-)
And why couldn't it be the same for 2.4.21?
Have a nice fortnight
Signature · 3 lines
Martin `MJ' Mares <[email protected]> http://atrey.karlin.mff.cuni.cz/~mj/ Faculty of Math and Physics, Charles University, Prague, Czech Rep., Earth The better the better, the better the bet.
Quoted 3 lines
Sorry, but you seem to forget that a significant amount of people use kernel.org kernels, but don't monitor LKML nor are able to choose from the various patches floating there the most appropriate fix.
Thats not my problem is it. There are vendors, there are free distributions too.
Alan
Quoted 1 line
Thats not my problem is it.
It probably isn't -- my mail was a reply to Jeff :-)
Quoted 1 line
There are vendors, there are free distributions too.
Yes, but that's pretty irrelevant. People should not depend on such sources to get security fixes. Anything so critical should be included in the official kernel as soon as possible -- any reasons against?
Have a nice fortnight
Signature · 3 lines
Martin `MJ' Mares <[email protected]> http://atrey.karlin.mff.cuni.cz/~mj/ Faculty of Math and Physics, Charles University, Prague, Czech Rep., Earth Not all rumors are as misleading as this one.
Quoted 3 lines
Yes, but that's pretty irrelevant. People should not depend on such sources to get security fixes. Anything so critical should be included in the official kernel as soon as possible -- any reasons against?
Several
- We aren't about to release an official kernel right now afaik,
there are bugs left to sort out first
- Anyone can apply the patch themselves
- Anyone can go and get a vendor kernel
- Anyone can go and release their own 2.4.20.1 or 2.4.20-sec or
whatever if they feel strongly about it
Just go do it. If someone wants to be a contact point for build existing base kernels + published security fix trees I'm pretty sure kernel.org would host them too.
Alan
Hi Alan!
Quoted 3 lines
Several
(quoted diff) +0
-1- We aren't about to release an official kernel right now afaik,there are bugs left to sort out first
But these patches can be easily postponed to the next release and now we can release just the bug fix as you did in the 2.2 series.
Quoted 4 lines
(quoted diff) +0
-3- Anyone can apply the patch themselves - Anyone can go and get a vendor kernel - Anyone can go and release their own 2.4.20.1 or 2.4.20-sec orwhatever if they feel strongly about it
No, I asked you for reasons against, you gave me (except for the first point) just reasons why it won't hurt too much.
Do you really think that "People should either use vendor kernels or read LKML and be able to gather the fixes from there themselves" is a good strategy?
Have a nice fortnight
Signature · 3 lines
Martin `MJ' Mares <[email protected]> http://atrey.karlin.mff.cuni.cz/~mj/ Faculty of Math and Physics, Charles University, Prague, Czech Rep., Earth Next lecture on time travel will be held on previous Monday.
Quoted 3 lines · Martin Mares
Do you really think that "People should either use vendor kernels or read LKML and be able to gather the fixes from there themselves" is a good strategy?
Yes, I suspect he does as do most people here.
If you do not use a vendor kernel then you assume the responsibility of doing this stuff yourself. If you do not want to worry about these things, use a vendor kernel.
Robert Love
Quoted 3 lines · On 23 Mar 2003 14:47:19 -0500 Robert Love <[email protected]> wrote:
If you do not use a vendor kernel then you assume the responsibility of doing this stuff yourself. If you do not want to worry about these things, use a vendor kernel.
Almost all of the people I know who are running Linux are compiling their own kernels fetched from kernel.org and very few of them are tracking LKML, so even if they should, they aren't.
Would it really hurt that much to release 2.4.21 with the ptracefix(es)?
If it hurts that much, can kernel.org put out a brief message and a link to the relevant patches somewhere so that people who doesn't follow LKML can find the patches without browsing the ML-archives?
Signature · 2 lines
Henrik Persson [email protected] http://nix.badanka.com PGP-key: http://nix.badanka.com/pgp PGP-KeyID: 0x43B68116
Quoted 2 lines · Henrik Persson
Would it really hurt that much to release 2.4.21 with the ptracefix(es)?
No, it would not. But the point is Marcelo does not need to. If he and other kernel developers feel this course of action is better warranted, then that is fine.
Users should rely on their vendors if they cannot rely on themselves.
Note that personally, I probably would of released a 2.4.21 with just the ptrace security fix applied, as Alan did for 2.2. But I am neither Alan nor Marcelo, and the actions they both picked are OK.
Robert Love
Quoted 1 line · On Sun, 23 Mar 2003 20:55:31 +0100 Henrik Persson <[email protected]> wrote:
Would it really hurt that much to release 2.4.21 with the ptracefix(es)?
Or would it hurt to release -pre6 like..right now with the fixes in it?
This combined with a small notice on kernel.org would most certainly satisfy me, but as for now I had to browse trough the archives cause I deleted the mail with the patch by accident, and that's not very optimal, is it?
Signature · 2 lines
Henrik Persson [email protected] http://nix.badanka.com PGP-key: http://nix.badanka.com/pgp PGP-KeyID: 0x43B68116
Hello!
Quoted 5 lines
Yes, I suspect he does as do most people here.
If you do not use a vendor kernel then you assume the responsibility of doing this stuff yourself. If you do not want to worry about these things, use a vendor kernel.
But if you assume this, what are the official releases for anyway?
Have a nice fortnight
Signature · 3 lines
Martin `MJ' Mares <[email protected]> http://atrey.karlin.mff.cuni.cz/~mj/ Faculty of Math and Physics, Charles University, Prague, Czech Rep., Earth "God doesn't play dice." -- Albert Einstein
Quoted 7 lines · Martin Mares
Quoted 5 lines
Yes, I suspect he does as do most people here.
If you do not use a vendor kernel then you assume the responsibility of doing this stuff yourself. If you do not want to worry about these things, use a vendor kernel.
But if you assume this, what are the official releases for anyway?
It is the way Linux is heading - becoming less free. Lock-in to distribution vendors. And soon you'll need to pay distributions to (timely) get the fixes.
To give an instance, because I don't work for a distribution, I don't have access to the security lists. Yet, I'm the guy who produces the ARM patches which the ARM community at large use.
This situation caused HP to shut down their public ARM boxen while I worked on integrating the security fix into the ARM tree. Unfortunately, this could only happen _after_ the problem was publically announced, which means some of HPs systems were vulnerable to attack for a few days.
If you think Linux today is about something "free"...
Signature · 2 lines
Russell King ([email protected]) The developer of ARM Linux http://www.arm.linux.org.uk/personal/aboutme.html
Quoted 3 lines · Russell King
To give an instance, because I don't work for a distribution, I don't have access to the security lists. Yet, I'm the guy who produces the ARM patches which the ARM community at large use.
So apply to join vendor-sec.
Alan
Quoted 1 line · Martin Mares
But if you assume this, what are the official releases for anyway?
Well, official releases have always been sort of arbitrary for the kernel... just labeled releases along the course of development. Although with the recent addition of the -rc patches, they tend to ensure the latest round of development at least resulted in a stable release. But look at all the major vendors - their 2.4.18 release, for example, may include whatever the latest pre-patch was at the time.
Anyhow, to answer your question: the official releases are labels along the course of development for use by vendors, developers, and users who (as Alan described) can manage their own kernels.
Do not get me wrong, I think users can and should compile their own kernel if they want. And as kernel developers, we should facilitate that. But if someone requires handholding and instant or controlled releases of bug fixes, they either need to be able to rely on their own ability to get them or their vendor. We have vendors for a reason, after all.
Robert Love
Quoted 8 lines
Quoted 1 line
But if you assume this, what are the official releases for anyway?
Well, official releases have always been sort of arbitrary for the kernel... just labeled releases along the course of development. Although with the recent addition of the -rc patches, they tend to ensure the latest round of development at least resulted in a stable release. But look at all the major vendors - their 2.4.18 release, for example, may include whatever the latest pre-patch was at the time.
I don't agree that's always been true by any means. It may currently be true, but that's far from a good thing. The current state of divergance the distros have from mainline 2.4 is IMHO the biggest problem Linux has today.
The distros inherently have a conflict of interest getting changes merged back into mainline ... it's time consuming to do, it provides them no real benefit (they have to maintain their huge trees anyway), and it actively damages the "value add" they provide.
Quoted 10 lines
Anyhow, to answer your question: the official releases are labels along the course of development for use by vendors, developers, and users who (as Alan described) can manage their own kernels.
Do not get me wrong, I think users can and should compile their own kernel if they want. And as kernel developers, we should facilitate that. But if someone requires handholding and instant or controlled releases of bug fixes, they either need to be able to rely on their own ability to get them or their vendor. We have vendors for a reason, after all.
If that's people's attitude ("you should use a vendor"), then we need a 2.4-fixed tree to be run by somebody with an interest in providing critical bugfixes to the community with no distro ties. People may be perfectly capable of finding, applying, and collecting their own patches, but that's no reason to make it difficult.
M.
Hi!
Quoted 9 lines
Quoted 6 lines
Do not get me wrong, I think users can and should compile their own kernel if they want. And as kernel developers, we should facilitate that. But if someone requires handholding and instant or controlled releases of bug fixes, they either need to be able to rely on their own ability to get them or their vendor. We have vendors for a reason, after all.
If that's people's attitude ("you should use a vendor"), then we need a
I believe sentence "you should use a vendor kernel" schould be banned on this list ;-).
How badly would releasing 2.4.21 which does not have 2.4.20-preX as a parent mess version control systems?
Pavel
Signature · 2 lines
Horseback riding is like software... ...vgf orggre jura vgf serr.
Quoted 9 lines · Pavel Machek
Hi!
Quoted 7 lines
Quoted 6 lines
Do not get me wrong, I think users can and should compile their own kernel if they want. And as kernel developers, we should facilitate that. But if someone requires handholding and instant or controlled releases of bug fixes, they either need to be able to rely on their own ability to get them or their vendor. We have vendors for a reason, after all.
Quoted 5 lines
Quoted 2 lines
If that's people's attitude ("you should use a vendor"), then we need a
I believe sentence "you should use a vendor kernel" schould be banned on this list ;-).
ACK ;-)
Quoted 2 lines
How badly would releasing 2.4.21 which does not have 2.4.20-preX as a parent mess version control systems?
I guess this would make problems with the incremental patches.
I think putting an official patch for 2.4.20 closing the ptrace hole on www.kernel.org should be no problem, and people compiling the kernel themselves could easily use a correctly patched kernel. The main problem (IMHO) is finding the correct patch. Even a link to the mail in the archive might be sufficient.
(I hope this has not been suggested before, I was unsubsribed to lkml for some days)
Regards,
Martin
Quoted 2 lines · Pavel Machek
Hi!
...
Quoted 8 lines
Quoted 2 lines
If that's people's attitude ("you should use a vendor"), then we need a
I believe sentence "you should use a vendor kernel" schould be banned on this list ;-).
How badly would releasing 2.4.21 which does not have 2.4.20-preX as a parent mess version control systems?
I shouldn't step in this but I am going to anyway. BTW, the first 2 bits is my opinion and can be discarded or whatever, not directed at anyone in particular.
<subjectiveopinion>
First, I do agree with Alan, it's not his (or Marcelos'/Linus'/pick your favorite kernel maintainer) problem if you choose not to go with a vendor kernel. I choose not to go with vendor kernels, primarily because since days long past, when I started admining Linux systems, the vendor kernels were not the most stable ones... Times change but habits are more difficult to. That is why you can download the ptrace patch from my personal website (http://www.hardrock.org/kernel/2.4.20/).
If you can't do it, or are not willing to stick your neck out to do it, then use a vendor kernel and don't complain about the release cycle...
Second, the current patch isn't quite right. It blocks even root from tracing a process if needed and breaks chroot'ing from what I hear. Including this as a release for 2.4.21 would be the "Wrong Thing" to do. Could you imagine releasing something that breaks applications which require these things to work as a "release" kernel? Bad karma there... </subjectiveopinion>
I do already host patches for current kernels which I use at work. What about just keeping a combined security and fixup patch set for the current tree available for people to download and apply with instructions on doing so and an index of what the patch contains and why?
Given that the patches come from reputable sources (for example the ext3 patches for 2.4.20 and the ptrace patch) they can be
included without too much thought and some testing. I could maintain this, and it could be available either on kernel.org or just from my website, no matter either way. As I said, I'm already doing this so it wouldn't be a huge bother anyway.
If anyone wants this to happen, let me know as it will then happen... Otherwise I'll continue to do it as I am now anyway, and everyone is welcome to use this source for patches to the current tree.
Regards,
James Bourne
Quoted 1 line
Pavel
Signature · 6 lines
James Bourne, Supervisor Data Centre Operations Mount Royal College, Calgary, AB, CA www.mtroyal.ab.ca "There are only 10 types of people in this world: those who understand binary and those who don't."
Quoted 12 lines
I do already host patches for current kernels which I use at work. What about just keeping a combined security and fixup patch set for the current tree available for people to download and apply with instructions on doing so and an index of what the patch contains and why?
Given that the patches come from reputable sources (for example the ext3 patches for 2.4.20 and the ptrace patch) they can be
included without too much thought and some testing. I could maintain this, and it could be available either on kernel.org or just from my website, no matter either way. As I said, I'm already doing this so it wouldn't be a huge bother anyway.
Quoted 3 lines
If anyone wants this to happen, let me know as it will then happen... Otherwise I'll continue to do it as I am now anyway, and everyone is welcome to use this source for patches to the current tree.
I think this would be valuable .. the other thing that really needs to be present is a "common vendor" kernel where changes that are common to most distros are merged (eg O(1) scheduler, etc). Personally, I think that's what mainline should be doing ... but if other people disagree, then I, at least, would see value in a separate tree to do this.
M.
Quoted 4 lines · Martin J. Bligh
I think this would be valuable .. the other thing that really needs to
be present is a "common vendor" kernel where changes that are common
to most distros are merged (eg O(1) scheduler, etc). Personally, I think that's what mainline should be doing ... but if other people disagree, then I, at least, would see value in a separate tree to do this.
akpm has suggested something like this in the past. I respectfully disagree.
The 2.4 kernel will not benefit from constant churn of backporting core kernel changes like a new scheduler. We need to let it settle, simply get it stable, and concentrate on fixing key problems in 2.6. Otherwise you will never have a stable 2.4 tree, and it will look suspiciously more and more like 2.6 as time goes by. Constantly breaking working configurations and changing core behaviors is _not_ the way to go for 2.4.
I see 2.4 O(1) scheduler and similar features as _pain_ brought on the vendors by themselves (and their customers).
Surely it is better to concentrate developer time and mindshare on making 2.6 sane?
Jeff
Quoted 9 lines · Jeff Garzik
Quoted 5 lines · Martin J. Bligh
I think this would be valuable .. the other thing that really needs to be present is a "common vendor" kernel where changes that are common to most distros are merged (eg O(1) scheduler, etc). Personally, I think that's what mainline should be doing ... but if other people disagree, then I, at least, would see value in a separate tree to do this.
akpm has suggested something like this in the past. I respectfully disagree.
I also disagree. Although it would be nice, it's not practical. What people want is strictly fixes and security related patches, and that is ALL I propose to want to include. Perhaps if the vendors want a "common vendor" patch they could maintain it? ;)
So, to that end, I have made available:
(URL is http://www.hardrock.org/kernel/current-updates/)
linux-2.4.20-updates.patch: Contains all three patches below. For the
primary fixes needed in the current release kernel.
Individual patches:
linux-2.4.20-ext3.patch: Fixes for ext3 data=journal umount patch, sync-fix
patch, and use-after-free patch from Andrew Morton <[email protected]>.
linux-2.4.20-ptrace.patch: Alan Cox relased a patch against 2.4.20 which
did not apply cleanly (perhaps it was his -ac tree). This will apply cleanly and compile under i386 to the clean 2.4.20 source tree.
linux-2.4.20-tg3.patch: Jeff Garzik and David S. Millers tg3 1.4c
driver for 2.4.20.
Enjoy!
Regards
James Bourne
Quoted 1 line
Jeff
Signature · 16 lines
James Bourne, Supervisor Data Centre Operations Mount Royal College, Calgary, AB, CA www.mtroyal.ab.ca ****************************************************************************** This communication is intended for the use of the recipient to which it is addressed, and may contain confidential, personal, and or privileged information. Please contact the sender immediately if you are not the intended recipient of this communication, and do not copy, distribute, or take action relying on it. Any communication received in error, or subsequent reply, should be deleted or destroyed. ****************************************************************************** "There are only 10 types of people in this world: those who understand binary and those who don't."
Quoted 7 lines
Quoted 2 lines
akpm has suggested something like this in the past. I respectfully disagree.
I also disagree. Although it would be nice, it's not practical. What people want is strictly fixes and security related patches, and that is ALL I propose to want to include. Perhaps if the vendors want a "common vendor" patch they could maintain it? ;)
I still think the common vendor kernel is valuable, but different ;-) A straight fixes tree is valuable too ... thanks.
M.
Quoted 5 lines · Martin J. Bligh
Quoted 2 lines
is ALL I propose to want to include. Perhaps if the vendors want a "common vendor" patch they could maintain it? ;)
I still think the common vendor kernel is valuable, but different ;-) A straight fixes tree is valuable too ... thanks.
I do agree that it would be valuable, just not my bag.
Regards
James Bourne (different email address due to disclaimer chaos)
Quoted 1 line
M.
Signature · 5 lines
James Bourne | Email: [email protected] Unix Systems Administrator | WWW: http://www.hardrock.org Custom Unix Programming | Linux: The choice of a GNU generation ---------------------------------------------------------------------- "All you need's an occasional kick in the philosophy." Frank Herbert
Quoted 10 lines · Jeff Garzik
akpm has suggested something like this in the past. I respectfully disagree.
The 2.4 kernel will not benefit from constant churn of backporting core kernel changes like a new scheduler. We need to let it settle, simply get it stable, and concentrate on fixing key problems in 2.6. Otherwise you will never have a stable 2.4 tree, and it will look suspiciously more and more like 2.6 as time goes by. Constantly breaking working configurations and changing core behaviors is _not_ the way to go for 2.4.
Quoted 5 lines
I see 2.4 O(1) scheduler and similar features as _pain_ brought on the vendors by themselves (and their customers).
Surely it is better to concentrate developer time and mindshare on making 2.6 sane?
I'm no hardcore kernel hacker, but I fully agree with you. 2.4 is pretty stable... Introducing new code (VM, IDE, etc) is just a bit risky, more even when current 2.4 is 2.4.21 (I would say mature enough).
________________________________________________________________________
Felipe Alfaro Solana
Linux Registered User #287198
http://counter.li.org
Quoted 10 lines
akpm has suggested something like this in the past. I respectfully disagree.
The 2.4 kernel will not benefit from constant churn of backporting core kernel changes like a new scheduler. We need to let it settle, simply get it stable, and concentrate on fixing key problems in 2.6. Otherwise you will never have a stable 2.4 tree, and it will look suspiciously more and more like 2.6 as time goes by. Constantly breaking working configurations and changing core behaviors is _not_ the way to go for 2.4.
Quoted 2 lines
I see 2.4 O(1) scheduler and similar features as _pain_ brought on the vendors by themselves (and their customers).
O(1) sched may be a bad example ... how about the fact that mainline VM is totally unstable? Witness, for instance, the buffer_head stuff. Fixes for that have been around for ages.
The real philosophical question is "what is mainline 2.4 _for_"?
Quoted 2 lines
Surely it is better to concentrate developer time and mindshare on making 2.6 sane?
Agreed, but all we're doing now is burning lots of time on backporting stuff from 2.5 into each separate distro base, and each distro fixing things independantly in their own tree (eg O(1) scheduler). I don't see that as constructive ... customers will not stagnate, and I don't see the point in 2.4 mainline doing that either.
It's now got to the point where the testing people don't even bother testing mainline 2.4 because they know it's horribly broken, and is not getting fixed, so there's no point. I think that's sad. Instead, we test umpteen different vendor kernels, and try to apply the same fixes to each of those, which is a pain in the butt, becasue they won't merge cleanly because the trees are so far diverged. People running non-vendor kernels are generally running 2.4-aa or 2.4-ac, etc, etc. All burnt thrash time.
Yes, the real answer is to get 2.6 out the door, and move people onto it. But that will take a little while ... would be nice to get some way to alleviate the pain in the meantime.
M.
Quoted 3 lines
O(1) sched may be a bad example ... how about the fact that mainline VM is totally unstable? Witness, for instance, the
buffer_headstuff. Fixes for that have been around for ages.
On normal computers 2.4.21pre VM is very stable, in fact I dumped the rmap vm from -ac because its far better at the moment
Most people don't care about 32 way scaling of 16Gb boxes running EVMS.
Quoted 6 lines
Quoted 3 lines
O(1) sched may be a bad example ... how about the fact that mainline VM is totally unstable? Witness, for instance, the
buffer_headstuff. Fixes for that have been around for ages.On normal computers 2.4.21pre VM is very stable, in fact I dumped the rmap vm from -ac because its far better at the moment
Cool - I gave up on 2.4 before that. Perhaps it's getting sorted out now ... is the buffer_head stuff fixed now? If 2.4 VM was more or less the same across distros, that would get rid of a whole bunch of pain.
Quoted 1 line
Most people don't care about 32 way scaling of 16Gb boxes running EVMS.
That wasn't what I meant ... but I think there's a place for a tree of common vendor 2.4 fixes & features, a separate one for the workstation and server stuff if you will. All the current duplication of effort seems rather silly.
M.
Hi,
Quoted 6 lines · Alan Cox
Quoted 3 lines
O(1) sched may be a bad example ... how about the fact that mainline VM is totally unstable? Witness, for instance, the
buffer_headstuff. Fixes for that have been around for ages.On normal computers 2.4.21pre VM is very stable, in fact I dumped the rmap vm from -ac because its far better at the moment
If you want to go in full sync with the other vm fixes and improvements in my tree I can send you the other remaining patches to apply (not before the end of next week though), they works so well that I don't get a single vm report for several months and I would like if they could reach mainline too infact since they are over-time-refinement only, nothing I would call major or very significant. Maybe if you merge them, then Marcelo will merge them too? most of them are easily mergeable by just checking my ftp area, most start with 05_vm_ and they shouldn't be very controversial. Andrew blessed them too, when he splitted them (he only giveup on the "-rest" patch so that one is still very monolithic sorry ;).
Andrea
Quoted 1 line · Andrea Arcangeli
nothing I would call major or very significant. Maybe if you merge them,
woops, re-reading I said the above plain wrong sorry, I really meant they're not going to give you major or very significant problems in merging (at least IMHO but I may be biased ;), for the big iron _end_users_ they are definitely significant this is why I'm recommending their merging and various other people is pushing for their merging in mainline too.
Andrea
Quoted 3 lines · Andrea Arcangeli
very controversial. Andrew blessed them too, when he splitted them (he only giveup on the "-rest" patch so that one is still very monolithic sorry ;).
For the -rest stuff (and very few other split patches) there's still no evidence that it needs to go into mainline. But having the other stuff in would certainly help to not only make mainline useable under higher loads on not-lowend heardware and has the additional benefit that later patches form -aa might just apply instead of people like me needing to spend some time on merging them over just to not get them applied anyway..
Quoted 6 lines
nothing I would call major or very significant. Maybe if you merge them, then Marcelo will merge them too? most of them are easily mergeable by just checking my ftp area, most start with 05_vm_ and they shouldn't be very controversial. Andrew blessed them too, when he splitted them (he only giveup on the "-rest" patch so that one is still very monolithic sorry ;).
I'm wary of mixing them with IDE but I will take a look. In the 2.2 case it certainly worked out well
Quoted 10 lines · Martin J. Bligh
Quoted 10 lines
akpm has suggested something like this in the past. I respectfully disagree.
The 2.4 kernel will not benefit from constant churn of backporting core kernel changes like a new scheduler. We need to let it settle, simply get it stable, and concentrate on fixing key problems in 2.6. Otherwise you will never have a stable 2.4 tree, and it will look suspiciously more and more like 2.6 as time goes by. Constantly breaking working configurations and changing core behaviors is _not_ the way to go for 2.4.
Quoted 7 lines
Quoted 2 lines
I see 2.4 O(1) scheduler and similar features as _pain_ brought on the vendors by themselves (and their customers).
O(1) sched may be a bad example ... how about the fact that mainline VM is totally unstable? Witness, for instance, the
buffer_headstuff. Fixes for that have been around for ages.
"totally unstable" being defined as: My computers don't crash, and my 100%-mainline test kernels pass various Cerberus/LTP/crashme runs.
Of course, I am not totally focused on multi-million-dollar computers, so maybe my perspective is skewed... ;-)
Quoted 1 line
The real philosophical question is "what is mainline 2.4 _for_"?
It's the 2.4 tree that's missing all the vendor junk unacceptable for mainline.
Quoted 3 lines
Yes, the real answer is to get 2.6 out the door, and move people onto it. But that will take a little while ... would be nice to get some way to alleviate the pain in the meantime.
Fixes should be applied to 2.4-mainline, certainly. Anything else just wastes developer brain cycles and slows the move to 2.6.
Jeff
Quoted 9 lines
Quoted 3 lines
O(1) sched may be a bad example ... how about the fact that mainline VM is totally unstable? Witness, for instance, the
buffer_headstuff. Fixes for that have been around for ages."totally unstable" being defined as: My computers don't crash, and my 100%-mainline test kernels pass various Cerberus/LTP/crashme runs.
Of course, I am not totally focused on multi-million-dollar computers, so maybe my perspective is skewed... ;-)
Last time I checked, a 2x machine with 4Gb of RAM didn't cost millions of dollars ;-)
Quoted 2 lines
Fixes should be applied to 2.4-mainline, certainly. Anything else just wastes developer brain cycles and slows the move to 2.6.
Common vendor _features_ is maybe better done in a separate tree, I'd accept ... I'm just frustrated with the current lack of commonality between distros, I guess.
M.
Quoted 13 lines · Martin J. Bligh
Quoted 9 lines
Quoted 3 lines
O(1) sched may be a bad example ... how about the fact that mainline VM is totally unstable? Witness, for instance, the
buffer_headstuff. Fixes for that have been around for ages."totally unstable" being defined as: My computers don't crash, and my 100%-mainline test kernels pass various Cerberus/LTP/crashme runs.
Of course, I am not totally focused on multi-million-dollar computers, so maybe my perspective is skewed... ;-)
Last time I checked, a 2x machine with 4Gb of RAM didn't cost millions of dollars ;-)
Quoted 7 lines
Quoted 2 lines
Fixes should be applied to 2.4-mainline, certainly. Anything else just wastes developer brain cycles and slows the move to 2.6.
Common vendor _features_ is maybe better done in a separate tree, I'd accept ... I'm just frustrated with the current lack of commonality between distros, I guess.
You will never get distros to follow that. A 'featured-kernel-for-distro'... Just take RH and SuSE (correct me if I'm wrong...)
RH ships -ac. SuSE ships -aa. At least both (-ac and -aa) have O(1) scheduler now. -ac ships rmap, -aa ships -aa (;)). That means O(1) goes in your kernel, but how about the VM subsystem ?
But now that -ac does not include rmap, perhaps the VM can be chosen as the one from Andrea...
(BTW, I have been runnin plan -pres for a couple of weeks, and now that I run -aa again, my computer looks like a new one...)
Signature · 4 lines
J.A. Magallon <[email protected]> \ Software is like sex: werewolf.able.es \ It's better when it's free Mandrake Linux release 9.1 (Bamboo) for i586 Linux 2.4.21-pre5-jam1 (gcc 3.2.2 (Mandrake Linux 9.1 3.2.2-3mdk))
Quoted 5 lines · J.A. Magallon
You will never get distros to follow that. A 'featured-kernel-for-distro'... Just take RH and SuSE (correct me if I'm wrong...)
RH ships -ac. SuSE ships -aa. At least both (-ac and -aa) have O(1) scheduler now. -ac ships rmap, -aa ships -aa (;)). That means O(1) goes in your kernel, but how about the VM subsystem ?
Mainline needs VM updates and as the -aa VM is the actual fixes for the 2.4.10+ VM it needs to be merged (at least partially). It's sad that this happened after akpm and other spent lots of time on splitting up and documenting it.
On Sun, 23 Mar 2003 15:45:38 -0800
"Martin J. Bligh" <[email protected]> wrote:
<snip>
Quoted 3 lines
Common vendor _features_ is maybe better done in a separate tree, I'd accept ... I'm just frustrated with the current lack of commonality between distros, I guess.
</snip>
Excuse me for breaking in, but after reading this thread for a while I have a suggestion to make: if you feel that a 2.4.xx-extrafeatures is needed try to get a couple of guys together and start up your own branch of patches :) I would be one that's willing to try it out.
Signature · 2 lines
Christan Axelsson [email protected]
Quoted 1 line · On Sun, 23 Mar 2003 14:54:40 -0800 "Martin J. Bligh" <[email protected]> wrote:
O(1) sched may be a bad example ... how about the fact that mainline VM
I guess alsa is even a better example. It's one of the very few things that really have sense (IMHO) to have in 2.4.
After all, they're drivers; and many people has to use them to get support.
(I remember in a interview somewhere where Marcelo said he wasn't going to merge them, but it'd be nice anyway....)
Diego Calleja
Quoted 4 lines · Martin J. Bligh
The distros inherently have a conflict of interest getting changes merged back into mainline ... it's time consuming to do, it provides them no real benefit (they have to maintain their huge trees anyway), and it actively damages the "value add" they provide.
I take a strong objection to this. I can't speak for all distros, but I know that Red Hat has a strong preference to get things merged upstream as soon as possible. I think you are absolutely wrong about the "no real benefit" part and that you totally misunderstand what value add distributions provide.
Quoted 3 lines
If that's people's attitude ("you should use a vendor"), then we need a 2.4-fixed tree to be run by somebody with an interest in providing critical bugfixes to the community with no distro ties.
this is not about distros or vendors (yes IBM is a linux vendor too). at all. Marcelo is in a tough position; either he releases an emergency kernel with a patch applied that seems to have a few corner case issues, or he starts to rush out 2.4.21 based on the current 2.4.21-pre codebase. Given that there are other bugs in 2.4.20 that makes people say "but THIS needs to be in too", I can see that becoming a very fuzzy thing pretty quick. Apparantly Marcelo decided to go for the "get 2.4.21 out soon" approach.....
Greetings,
Arjan van de Ven
Quoted 10 lines
Quoted 4 lines
The distros inherently have a conflict of interest getting changes merged back into mainline ... it's time consuming to do, it provides them no real benefit (they have to maintain their huge trees anyway), and it actively damages the "value add" they provide.
I take a strong objection to this. I can't speak for all distros, but I know that Red Hat has a strong preference to get things merged upstream as soon as possible. I think you are absolutely wrong about the "no real benefit" part and that you totally misunderstand what value add distributions provide.
Well, that is a minefield of subjective opinions. Yes, the distros merge stuff back ... but there's not enough of it going on. RHAS and UL are *massively* diverged. There are also changes that are in just about every distro that aren't back in mainline. I fail to see the point of that ... people complain about problems with things like O(1) scheduler, and yet the distros all distribute it ... very odd.
The question of "what is mainline 2.4 for anyway" is becoming increasingly interesting, especially as fewer people are using it. If there was more of a common base between the distros, there would be IMHO less duplicated work.
Quoted 4 lines
Quoted 3 lines
If that's people's attitude ("you should use a vendor"), then we need a 2.4-fixed tree to be run by somebody with an interest in providing critical bugfixes to the community with no distro ties.
Quoted 8 lines
this is not about distros or vendors (yes IBM is a linux vendor too). at all. Marcelo is in a tough position; either he releases an emergency kernel with a patch applied that seems to have a few corner case issues, or he starts to rush out 2.4.21 based on the current 2.4.21-pre codebase. Given that there are other bugs in 2.4.20 that makes people say "but THIS needs to be in too", I can see that becoming a very fuzzy thing pretty quick. Apparantly Marcelo decided to go for the "get 2.4.21 out soon" approach.....
I'm not so worried about what Marcelo chooses to do with this particular issue - that's his call. However, I'm extremely concerned by the general "you should be using a vendor kernel" attitude.
M.
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
"martin" == Martin J Bligh <[email protected]> writes:
Hi
martin> Well, that is a minefield of subjective opinions. Yes, the distros merge martin> stuff back ... but there's not enough of it going on. RHAS and UL are martin> *massively* diverged. There are also changes that are in just about every martin> distro that aren't back in mainline. I fail to see the point of that ... martin> people complain about problems with things like O(1) scheduler, and yet martin> the distros all distribute it ... very odd.
Problem is the same than ever. Full major kernel releases take 2 years. That means that we need to force things in the _stable_ branch that should be in next branch. 2.4 should be in maintenance mode (aka something similar to what happens in 2.2 just now), but as 2.6 is not ready (and will not in at least several months yet), we have to live with big changes like the big IDE merge.
About the reasons for having lots of patches in a vendor kernel. It is just a pain in the ass :( I completely agree with Arjan on that. Problem is that getting patches back merged upstream sometimes is not easy either :( For instance, users test the distro when they are in release candidate, and when you found that problems and you got fixes for that, it is posible that kernel code base has already changed, what makes merging your fixes difficult. And not, merging code for mainline during a release candidate cycle is Just a Bad Idea (tm).
martin> The question of "what is mainline 2.4 for anyway" is becoming martin> increasingly interesting, especially as fewer people are using martin> it. If there was more of a common base between the distros, martin> there would be IMHO less duplicated work.
Will be basically the same work. Somebody needs to be in charge of that branch. And if you get <somebody> to pass your changes, then you have also the same posibilities to pass the patch Marcelo :)
martin> I'm not so worried about what Marcelo chooses to do with this particular martin> issue - that's his call. However, I'm extremely concerned by the general martin> "you should be using a vendor kernel" attitude.
Here, I completely agree with Pavel, you should never tell that sentence in that list :) You should use a vendor kernel only if:
- you don't know how to compile your own, and you are not interested in learn how to do it.
- you are lazy, and think that it is _easier_ for you to use a vendor kernel.
Later, Juan "who knows what is the pain of having lots of patches"
Signature · 2 lines
In theory, practice and theory are the same, but in practice they are different -- Larry McVoy
Quoted 10 lines · Juan Quintela
Here, I completely agree with Pavel, you should never tell that sentence in that list :) You should use a vendor kernel only if:
- you don't know how to compile your own, and you are not interested in learn how to do it.
- you are lazy, and think that it is _easier_ for you to use a vendor kernel.
OR :
- you work for people that absolutely freak out because you compile and/or patch your own kernel (yet you continue to torture them by doing so - hehe)
- you spend 80 hours a week on your job and don't have time to mess with building and maintaining your own kernels (where's the laziness here?)
- you are subject to certain rules and regulations that require a "vendor" to stand behind the various pieces of software that comprise your system (yeah I know, really lame, but a reality)
Quoted 4 lines · Martin J. Bligh
I don't agree that's always been true by any means. It may currently be true, but that's far from a good thing. The current state of divergance the distros have from mainline 2.4 is IMHO the biggest problem Linux has today.
What part of my statement are you disagreeing with, here?
I agree distribution divergence is a big issue. It may be a mostly insolvable one, too. It is partially a result of having a long development cycle. But even if we had a shorter development cycle, different distributions have different priorities. It is a hard problem.
Quoted 4 lines
The distros inherently have a conflict of interest getting changes merged back into mainline ... it's time consuming to do, it provides them no real benefit (they have to maintain their huge trees anyway), and it actively damages the "value add" they provide.
I do not disagree.
Although, I think there is incentive to get work merged. It _does_ reduce maintenance. I think you can see Red Hat merging stuff back. I know my employer encourages everything I do to be done openly and get it merged. Its a huge benefit to maintenance and QA to get stuff merged.
Quoted 5 lines
If that's people's attitude ("you should use a vendor"), then we need a 2.4-fixed tree to be run by somebody with an interest in providing critical bugfixes to the community with no distro ties. People may be perfectly capable of finding, applying, and collecting their own patches, but that's no reason to make it difficult.
No where above did I say "you should use a vendor"
In fact, what I did say is "I think users can and should compile their own kernel if they want. And as kernel developers, we should facilitate that."
I merely suggest that users should not expect anything if they go it there own. They need to follow the lists and be informed. Its like me assuming I can maintain my car without a mechanic and then freaking out when I did not hear about a service defect. Actually, a better analogy may include me knowing nothing about cars, too :)
Marcelo is in a tough spot. I think Arjan's email (just sent) sums it up well. It is not so clear cut. Personally, I think the ext3 bugs in 2.4.20 are worse than this local ptrace problem (there are other local issues, too). I also think some people are skeptical over the correctness of this patch.
Anyhow, what exactly are we arguing over?
Robert Love
Quoted 11 lines
Quoted 4 lines
The distros inherently have a conflict of interest getting changes merged back into mainline ... it's time consuming to do, it provides them no real benefit (they have to maintain their huge trees anyway), and it actively damages the "value add" they provide.
I do not disagree.
Although, I think there is incentive to get work merged. It _does_ reduce maintenance. I think you can see Red Hat merging stuff back. I know my employer encourages everything I do to be done openly and get it merged. Its a huge benefit to maintenance and QA to get stuff merged.
Yeah, I think it happens on the whole, despite the conflict of interest; but frustratingly slowly. There's two sides to that equation though.
Quoted 11 lines
Quoted 5 lines
If that's people's attitude ("you should use a vendor"), then we need a 2.4-fixed tree to be run by somebody with an interest in providing critical bugfixes to the community with no distro ties. People may be perfectly capable of finding, applying, and collecting their own patches, but that's no reason to make it difficult.
No where above did I say "you should use a vendor"
In fact, what I did say is "I think users can and should compile their own kernel if they want. And as kernel developers, we should facilitate that."
Right. I just think mainline should provide that facilitation role. If it doesn't, then if someone can gather the patches together, it'd help a lot. Applying the patches less of a problem than finding out what to apply ... following LKML isn't feasible for most people.
Quoted 5 lines
I merely suggest that users should not expect anything if they go it there own. They need to follow the lists and be informed. Its like me assuming I can maintain my car without a mechanic and then freaking out when I did not hear about a service defect. Actually, a better analogy may include me knowing nothing about cars, too :)
yeah, but it's more like "should we have someone list the service defects together on a website where you can find them easily", or leave them in a darkened basment where the lights are out with "beware of the leapord" stuck on the door ;-) Or should I have to service my car at the dealer?
Some people may chose the dealer ... I'd prefer the website to the basement ;-)
Quoted 1 line
Anyhow, what exactly are we arguing over?
Not a lot ;-)
M.
Quoted 14 lines · Martin J. Bligh
Quoted 7 lines
Quoted 1 line
But if you assume this, what are the official releases for anyway?
Well, official releases have always been sort of arbitrary for the
kernel... just labeled releases along the course of development. Although with the recent addition of the -rc patches, they tend to ensure the latest round of development at least resulted in a stable
release. But look at all the major vendors - their 2.4.18 release, for
example, may include whatever the latest pre-patch was at the time.I don't agree that's always been true by any means. It may currently be true, but that's far from a good thing. The current state of divergance the distros have from mainline 2.4 is IMHO the biggest problem Linux has today.
Quoted 4 lines
The distros inherently have a conflict of interest getting changes merged back into mainline ... it's time consuming to do, it provides them no real benefit (they have to maintain their huge trees anyway), and it actively damages the "value add" they provide.
Just to underscore Arjan's point: non-mainline patches are very actively discouraged at Red Hat. As time progresses the maintenance cost of EACH non-mainline patch increases. Non-mainline patches do not get the benefits of wide community testing, review, and feedback. Further, Red Hat employees in my experience typically land patches in the community _first_ -- witness my netdriver work (goes me -> Marcelo -> RH), DaveM's net stack work, and Alan's -ac tree.
Jeff
Quoted 10 lines
Quoted 9 lines
I don't agree that's always been true by any means. It may currently be true, but that's far from a good thing. The current state of divergance the distros have from mainline 2.4 is IMHO the biggest problem Linux has today.
The distros inherently have a conflict of interest getting changes merged back into mainline ... it's time consuming to do, it provides them no real benefit (they have to maintain their huge trees anyway), and it actively damages the "value add" they provide.
Quoted 7 lines
Just to underscore Arjan's point: non-mainline patches are very actively discouraged at Red Hat. As time progresses the maintenance cost of EACH non-mainline patch increases. Non-mainline patches do not get the benefits of wide community testing, review, and feedback. Further, Red Hat employees in my experience typically land patches in the community _first_ -- witness my netdriver work (goes me -> Marcelo -> RH), DaveM's net stack work, and Alan's -ac tree.
Right ... people seem to have taken more than I meant from this, and taken it more personally than it was intended. I do believe there is at least some conflict of interest ... but that doesn't mean people are controlled by it.
After some other side conversations, perhaps it would be useful to clarify that the appearance of a problem is more that we don't *see* patches getting submitted or accepted very often. That doesn't necessarily mean they aren't getting submitted.
But the divergance of 2.4 is still a massive issue ... whatever the underlying causes are.
M.
Quoted 13 lines · Martin J. Bligh
Quoted 11 lines
Quoted 9 lines
I don't agree that's always been true by any means. It may currently be true, but that's far from a good thing. The current state of divergance the distros have from mainline 2.4 is IMHO the biggest problem Linux has today.
The distros inherently have a conflict of interest getting changes merged back into mainline ... it's time consuming to do, it provides them no real benefit (they have to maintain their huge trees anyway), and it actively damages the "value add" they provide.
Just to underscore Arjan's point: non-mainline patches are very actively discouraged at Red Hat. As time progresses the maintenance cost of EACH non-mainline patch increases. Non-mainline patches do not get the benefits of wide community testing, review, and feedback. Further, Red Hat employees in my experience typically land patches in the community _first_ -- witness my netdriver work (goes me -> Marcelo -> RH), DaveM's net stack work, and Alan's -ac tree.
Quoted 6 lines
Right ... people seem to have taken more than I meant from this, and taken it more personally than it was intended. I do believe there is at least some conflict of interest ... but that doesn't mean people are controlled by it.
After some other side conversations, perhaps it would be useful to clarify that the appearance of a problem is more that we don't *see* patches getting submitted or accepted very often. That doesn't necessarily mean they aren't getting submitted.
I see a lot of new Red Hat work getting discussed, landing in the 2.5 tree, and then getting backported as a value-add 2.4 feature for an RH kernel. Other stuff is "hack it into stability, but it's ugly and should not go to Marcelo."
IMNSHO this perception is more a not-looking-hard-enough issue rather than reality.
I have no idea about UnitedLinux kernel, but for RHAS I wager there is next to _nil_ patches you would actually want to submit to Marcelo, for three main reasons: it's a 2.5 backport, or, it's a 2.4.2X backport, or, its an ugly-hack-for-stability that should not be in a mainline kernel without cleaning anyway.
Quoted 1 line
But the divergance of 2.4 is still a massive issue ... whatever the underlying causes are.
Can you actually quantify this divergance?
From actually _looking_ at RHAS for submittable patches, it seems to me like mostly 2.5-backport patches in 2.4, or, bandaid-until-2.5 fixes that don't belong in mainline.
Jeff
Quoted 8 lines
I see a lot of new Red Hat work getting discussed, landing in the 2.5 tree, and then getting backported as a value-add 2.4 feature for an RH kernel. Other stuff is "hack it into stability, but it's ugly and should not go to Marcelo."
IMNSHO this perception is more a not-looking-hard-enough issue rather than reality.
Well ... or we had different meanings ;-) yes, lots of stuff is in 2.5 but I was meaning 2.4. If there's stuff that's in both RH and UL kernels, and it's stable enough for them both to ship as their product, it sounds mergeable to me.
Quoted 5 lines
I have no idea about UnitedLinux kernel, but for RHAS I wager there is next to _nil_ patches you would actually want to submit to Marcelo, for three main reasons: it's a 2.5 backport, or, it's a 2.4.2X backport, or, its an ugly-hack-for-stability that should not be in a mainline kernel without cleaning anyway.
I don't see what's wrong with putting 2.5 backports into 2.4 once they're stable. And I'd rather have an ugly-hack-for-stability than an unstable kernel ... 2.5 is the place for cleanliness ... 2.4 is a dead end that just needs to work.
Quoted 5 lines
Can you actually quantify this divergance?
From actually _looking_ at RHAS for submittable patches, it seems to me
like mostly 2.5-backport patches in 2.4, or, bandaid-until-2.5 fixes that don't belong in mainline.
Right ... I think we're agreeing about what's the difference. Just disagreeing about what should be in mainline 2.4. If most others think it shouldn't go either, than I guess we need a separate tree for a 2.4 that works, not a 2.4 that's pretty ...
M.
Quoted 4 lines · Martin J. Bligh
The distros inherently have a conflict of interest getting changes merged back into mainline ... it's time consuming to do, it provides them no real benefit (they have to maintain their huge trees anyway), and it actively damages the "value add" they provide.
Well, I hope that the fragmentation of Unix in the 80'ies with the resulting rise of an unified OS to be marked leader ("DOS", then "Windows") should've learned that lesson with the vendors.
Linux ATM is heading exactly in the same direction as Unix went when Sun/HP/IBM/DEC decided not to keep an unified Unix base. It isn't heading that fast, mainly because the vendors must keep open source trees and they work from a central baseline ("Linus kernels") but we already have various distributions which sell "Linux" with a hugely different kernel. Think e.g. VM or devfs. Or supported file systems.
Regards
Henning
Signature · 5 lines
Dipl.-Inf. (Univ.) Henning P. Schmiedehausen INTERMETA GmbH [email protected] +49 9131 50 654 0 http://www.intermeta.de/ Java, perl, Solaris, Linux, xSP Consulting, Web Services freelance consultant -- Jakarta Turbine Development -- hero for hire
Quoted 5 lines · Martin J. Bligh
If that's people's attitude ("you should use a vendor"), then we need a 2.4-fixed tree to be run by somebody with an interest in providing critical bugfixes to the community with no distro ties. People may be perfectly capable of finding, applying, and collecting their own patches, but that's no reason to make it difficult.
Get the vendors to pay someone equally for it. That's much more likely to succeed. The current 2.4 model is already doomed, IMHO.
Regards
Henning
Signature · 5 lines
Dipl.-Inf. (Univ.) Henning P. Schmiedehausen INTERMETA GmbH [email protected] +49 9131 50 654 0 http://www.intermeta.de/ Java, perl, Solaris, Linux, xSP Consulting, Web Services freelance consultant -- Jakarta Turbine Development -- hero for hire
Quoted 3 lines
Yes, I suspect he does as do most people here.
This sentence is ambiguous and one of its possible meanings is "Most people do and Robert Love suspects Alan Cox does, too," which is also probably what you meant. A bit strong a statement, don't you think? How can you know the opinion of most people here?
As a sidenote, I consider it important to note that it's obvious that if Alan were the 2.4 maintainer, we would likely have a 2.4.21 with the critical (and possibly other) fixes out and all the fancy new stuff rescheduled for 2.4.22.
Signature · 1 line
Tomas Szepe <[email protected]>
Quoted 4 lines · Tomas Szepe
This sentence is ambiguous and one of its possible meanings is "Most people do and Robert Love suspects Alan Cox does, too," which is also probably what you meant. A bit strong a statement, don't you think? How can you know the opinion of most people here?
Yes, sorry, ambiguous.
I meant "I suspect most people agree with Alan"
I do not presume to know what most people think. I presume to think I know, hence "I suspect ..."
Anyhow, all I am saying is, if people _require_ support or bug fixes or instant updates they should use a vendor kernel. This does not mean we should not facilitate users who do make their own kernel.
This thread is getting off-topic...
Quoted 4 lines
As a sidenote, I consider it important to note that it's obvious that if Alan were the 2.4 maintainer, we would likely have a 2.4.21 with the critical (and possibly other) fixes out and all the fancy new stuff rescheduled for 2.4.22.
I would of released a 2.4.21, too.
Robert Love
Quoted 4 lines · Tomas Szepe
As a sidenote, I consider it important to note that it's obvious that if Alan were the 2.4 maintainer, we would likely have a 2.4.21 with the critical (and possibly other) fixes out and all the fancy new stuff rescheduled for 2.4.22.
Now we're speaking for Marcelo _and_ Alan?
Jeff
Quoted 8 lines · Jeff Garzik
Quoted 4 lines · Tomas Szepe
As a sidenote, I consider it important to note that it's obvious that if Alan were the 2.4 maintainer, we would likely have a 2.4.21 with the critical (and possibly other) fixes out and all the fancy new stuff rescheduled for 2.4.22.
Now we're speaking for Marcelo _and_ Alan?
He's wrong too as past 2.2 history will show
Quoted 3 lines · Martin Mares
Do you really think that "People should either use vendor kernels or read LKML and be able to gather the fixes from there themselves" is a good strategy?
Maybe I can make the point another way...
TANSTAAFL: There Ain't No Such Thing As A Free Lunch.
Marcelo is a volunteer, and maintaining the 2.4 kernel is not his full time job. Marcelo isn't beholden to people demanding a kernel release NOW NOW NOW. If you want that type of support, you have to pay for it.
I consider my personal obligation as "do my best as time and sanity allows." Demanding of people what they already give freely is a poor way to motivate.
Jeff
Quoted 6 lines · Jeff Garzik
Quoted 3 lines · Martin Mares
Do you really think that "People should either use vendor kernels or read LKML and be able to gather the fixes from there themselves" is a good strategy?
Quoted 6 lines
Maybe I can make the point another way...
TANSTAAFL: There Ain't No Such Thing As A Free Lunch.Marcelo is a volunteer, and maintaining the 2.4 kernel is not his full time job. Marcelo isn't beholden to people demanding a kernel release NOW NOW NOW. If you want that type of support, you have to pay for it.
I know this can sound a bit "the wrong way".
There's another thing though; Marcelo needs to merge the RIGHT fix. And he did merge it; he just hasn't finished releasing -pre6 yet
Quoted 3 lines · Martin Mares
Do you really think that "People should either use vendor kernels or read LKML and be able to gather the fixes from there themselves" is a good strategy?
Hi Martin,
I must say that I think it is an excellent strategy. I will admit
though, that I have voiced this opinion several times in the past and it seems that most people disagree with me.
I think we do a disservice to people by encouraging them to believe
that the kernels they download from kernel.org can be depended on to work. Kernel.org kernels are effectivly a way for people to participate in the development process and to help with QA. If you dont want to be involved with these activities, you really do not want to use those kernels.
We could try and make that guarantee if we wanted to, but it would
be a lot of work and the vendors are already doing it. So why not leverage their work?
Thanks,
Jim
Quoted 7 lines · Alan Cox
(quoted diff) +0
-1- Anyone can go and release their own 2.4.20.1 or 2.4.20-sec orwhatever if they feel strongly about it
Just go do it. If someone wants to be a contact point for build existing base kernels + published security fix trees I'm pretty sure kernel.org would host them too.
Sounds like a good idea. Ideal would be a person with a lottle knowledge about security or at least, about this particular patch.
I would volunteer, if noone else does. But just about anyone would be closer to that ideal person, so consider me to be the last resort.
Jörn
Signature · 2 lines
Simplicity is prerequisite for reliability. -- Edsger W. Dijkstra
Quoted 15 lines · Jörn Engel
Quoted 8 lines · Alan Cox
(quoted diff) +0
-1- Anyone can go and release their own 2.4.20.1 or 2.4.20-sec orwhatever if they feel strongly about it
Just go do it. If someone wants to be a contact point for build existing base kernels + published security fix trees I'm pretty sure kernel.org would host them too.
Sounds like a good idea. Ideal would be a person with a lottle knowledge about security or at least, about this particular patch.
Quoted 6 lines
I would volunteer, if noone else does. But just about anyone would be closer to that ideal person, so consider me to be the last resort.
Jörn
I think a solution like this would be best, having a "-fix" tree or similar for the latest stable kernel maintained by a volunteer and hosted by kernel.org.
Optionally or alternatively there could/should be a mailinglist (yes, one more :-) where all critical fixes like sec + fs fixes, etc. are posted to, for people building their own kernels (and interested in staying up-to-date) but not willing/having the time/able to dig through the tons of emails brought by lkml.
Cause I think if you're not an active kernel developer or having some issues with running a kernel, or like me, just interested and still learning to understand linux kernel programming in the far future ;-) you shouldn't have to read lkml just for building and maintaining your own, none-vendor kernel. Btw, if you had to, I think there might even be the danger of loosing some critical fixes in the loads of emails.
Sven
Quoted 28 lines · Sven Schuster
Quoted 15 lines · Jörn Engel
Quoted 8 lines · Alan Cox
(quoted diff) +0
-1- Anyone can go and release their own 2.4.20.1 or 2.4.20-sec orwhatever if they feel strongly about it
Just go do it. If someone wants to be a contact point for build existing base kernels + published security fix trees I'm pretty sure kernel.org would host them too.
Sounds like a good idea. Ideal would be a person with a lottle knowledge about security or at least, about this particular patch.
Quoted 6 lines
I would volunteer, if noone else does. But just about anyone would be closer to that ideal person, so consider me to be the last resort.
Jörn
I think a solution like this would be best, having a "-fix" tree or similar for
the latest stable kernel maintained by a volunteer and hosted by kernel.org.
Quoted 11 lines
Optionally or alternatively there could/should be a mailinglist (yes, one more :-) where all critical fixes like sec + fs fixes, etc. are posted to, for people building their own kernels (and interested in staying up-to-date) but not willing/having the time/able to dig through the tons of emails brought by lkml. Cause I think if you're not an active kernel developer or having some issues with running a kernel, or like me, just interested and still learning to understand linux kernel programming in the far future ;-) you shouldn't have to read lkml just for building and maintaining your own, none-vendor kernel. Btw, if you had to, I think there might even be the danger of loosing some critical fixes in the loads of emails.
Hi,
In an earlier email I posted a URL to an updates directory containing strictly updates for the current 2.4 kernel tree. The URL is
http://www.hardrock.org/kernel/current-updates/
Currently there is the ext3 patch, tg3 patch and ptrace patch. Also is one single patch with all three patches include.
Regards
James Bourne
Quoted 1 line
Sven
Signature · 5 lines
James Bourne | Email: [email protected] Unix Systems Administrator | WWW: http://www.hardrock.org Custom Unix Programming | Linux: The choice of a GNU generation ---------------------------------------------------------------------- "All you need's an occasional kick in the philosophy." Frank Herbert
Quoted 9 lines · James Bourne
Hi,
In an earlier email I posted a URL to an updates directory containing strictly updates for the current 2.4 kernel tree. The URL is
http://www.hardrock.org/kernel/current-updates/Currently there is the ext3 patch, tg3 patch and ptrace patch. Also is one single patch with all three patches include.
It's not about me, I myself had the ext3+tg3 patches applied since...well, don't remember exactly, but it's been a while now. I'm reading lkml. This was just meant as a suggestion to provide a kindof "help" or "support" to people not reading lkml but building their own kernel. A mailinglist or central place where they can get all the urgent fixes for the latest stable kernel (here 2.4.20).
Sven
Quoted 3 lines
Regards
James Bourne
Quoted 6 lines · Sven Schuster
It's not about me, I myself had the ext3+tg3 patches applied since...well, don't remember exactly, but it's been a while now. I'm reading lkml. This was just meant as a suggestion to provide a kindof "help" or "support" to people not reading lkml but building their own kernel. A mailinglist or central place where they can get all the urgent fixes for the latest stable kernel (here 2.4.20).
Hi,
Thanks for the clarification. I did propose to provide a central location for the patches, as I do this for work already. I could also put together a place for that kind of help document or at least host it if someone else is going to do this, that's a great idea as well...
Regards
James
Quoted 2 lines
Sven
Signature · 5 lines
James Bourne | Email: [email protected] Unix Systems Administrator | WWW: http://www.hardrock.org Custom Unix Programming | Linux: The choice of a GNU generation ---------------------------------------------------------------------- "All you need's an occasional kick in the philosophy." Frank Herbert
Quoted 7 lines · James Bourne
In an earlier email I posted a URL to an updates directory containing strictly updates for the current 2.4 kernel tree. The URL is
http://www.hardrock.org/kernel/current-updates/Currently there is the ext3 patch, tg3 patch and ptrace patch. Also is one single patch with all three patches include.
Looks good. Now all that is missing is a link from www.kernel.org, maybe. Peter, what do you think?
Jörn
Signature · 2 lines
Ninety percent of everything is crap. -- Sturgeon's Law
Quoted 6 lines · Jörn Engel
Quoted 4 lines · James Bourne
In an earlier email I posted a URL to an updates directory containing strictly updates for the current 2.4 kernel tree. The URL is
http://www.hardrock.org/kernel/current-updates/
Quoted 7 lines
Quoted 2 lines
Currently there is the ext3 patch, tg3 patch and ptrace patch. Also is one single patch with all three patches include.
Looks good. Now all that is missing is a link from www.kernel.org, maybe. Peter, what do you think?
I'd rather keep the collection itself on kernel.org.
-hpa
Quoted 11 lines · H. Peter Anvin
Quoted 10 lines · Jörn Engel
Quoted 6 lines · James Bourne
In an earlier email I posted a URL to an updates directory containing strictly updates for the current 2.4 kernel tree. The URL is
http://www.hardrock.org/kernel/current-updates/Currently there is the ext3 patch, tg3 patch and ptrace patch. Also is one single patch with all three patches include.
Quoted 5 lines
Quoted 3 lines
Looks good. Now all that is missing is a link from www.kernel.org, maybe. Peter, what do you think?
I'd rather keep the collection itself on kernel.org.
No problem. Let me know where.
Regards
James Bourne
Quoted 4 lines
-hpa
Signature · 5 lines
James Bourne | Email: [email protected] Unix Systems Administrator | WWW: http://www.hardrock.org Custom Unix Programming | Linux: The choice of a GNU generation ---------------------------------------------------------------------- "All you need's an occasional kick in the philosophy." Frank Herbert
Quoted 16 lines · James Bourne
Quoted 13 lines · H. Peter Anvin
Quoted 11 lines · Jörn Engel
Quoted 6 lines · James Bourne
In an earlier email I posted a URL to an updates directory containing strictly updates for the current 2.4 kernel tree. The URL is
http://www.hardrock.org/kernel/current-updates/Currently there is the ext3 patch, tg3 patch and ptrace patch. Also is one single patch with all three patches include.
Quoted 9 lines
Quoted 5 lines
Quoted 3 lines
Looks good. Now all that is missing is a link from www.kernel.org, maybe. Peter, what do you think?
I'd rather keep the collection itself on kernel.org.
No problem. Let me know where.
Do you have a kernel.org account already? If not, please send a GPG key to [email protected] and put a brief reason for the request ("2.4 critical patches archive").
-hpa
Quoted 3 lines · H. Peter Anvin
Quoted 2 lines
Looks good. Now all that is missing is a link from www.kernel.org, maybe. Peter, what do you think?
I'd rather keep the collection itself on kernel.org.
Another possibility just occured to me.
It'd be useful to add a feature that adds a check to the build process..
"Download post-release errata ? [Y/n]"
and have it wget patches from k.o, verify signatures and auto-apply them, which removes the "admin didnt even know there were patches that needed to be applied" possibility.
Dave
Hi!
Quoted 7 lines
Quoted 2 lines
Quoted 1 line
maybe. Peter, what do you think?
I'd rather keep the collection itself on kernel.org.
Another possibility just occured to me.
It'd be useful to add a feature that adds a check to the build process..
Quoted 6 lines
"Download post-release errata ? [Y/n]"
and have it wget patches from k.o, verify signatures and auto-apply them, which removes the "admin didnt even know there were patches that needed to be applied" possibility.
That looks like ugly can of worms to me. "what kernel do you have?"
"2.4.25 and it did two downloads; I was compiling it on the friday night"
Pavel
Signature · 2 lines
Pavel Written on sharp zaurus, because my Velo1 broke. If you have Velo you don't need...
Quoted 8 lines · Pavel Machek
Quoted 3 lines
and have it wget patches from k.o, verify signatures and auto-apply them, which removes the "admin didnt even know there were patches that needed to be applied" possibility.
That looks like ugly can of worms to me. "what kernel do you have?"
"2.4.25 and it did two downloads; I was compiling it on the friday night"
So make one of the patches change extra-version to -errataN or the like.
Dave
Quoted 6 lines · Dave Jones
Quoted 4 lines · Pavel Machek
Quoted 3 lines
and have it wget patches from k.o, verify signatures and auto-apply them, which removes the "admin didnt even know there were patches that needed to be applied" possibility.
Quoted 7 lines
Quoted 4 lines
That looks like ugly can of worms to me. "what kernel do you have?"
"2.4.25 and it did two downloads; I was compiling it on the friday night"So make one of the patches change extra-version to -errataN or the like.
Basically what we're talking about now is someone to maintain an "errata tree" -- someone to maintain sub-point releases (2.4.25.1, .2, etc.) and to decide what those are.
The other option would be to have it called something like 2.4.25-ep36-ep42-ep96 if errata patches 36, 42 and 96 were applied.
I think sub-point releases are better, since it at least cuts down the number of possible combinations.
-hpa
Quoted 5 lines · H. Peter Anvin
Quoted 5 lines
Quoted 5 lines
That looks like ugly can of worms to me. "what kernel do you have?"
"2.4.25 and it did two downloads; I was compiling it on the friday night"
It look like a good thing to me, iff done right. iff.
Quoted 1 line
Quoted 1 line
So make one of the patches change extra-version to -errataN or the like.
And the script doing the automatic downloads should refuse to apply any patch that doesn't change extra-version. When something like this happens to -ac2, people download it manually and know, it is in fact -ac3. But here...
Quoted 9 lines
Basically what we're talking about now is someone to maintain an "errata tree" -- someone to maintain sub-point releases (2.4.25.1, .2, etc.) and to decide what those are.
The other option would be to have it called something like 2.4.25-ep36-ep42-ep96 if errata patches 36, 42 and 96 were applied.
I think sub-point releases are better, since it at least cuts down the number of possible combinations.
I agree. There should be no point in finer granularity than sub-point releases. Even those should be kept as small as possible, completely empty if possible.
Jörn
Signature · 2 lines
Homo Sapiens is a goal, not a description. -- unknown
Quoted 12 lines · H. Peter Anvin
Quoted 11 lines · Dave Jones
Quoted 8 lines · Pavel Machek
Quoted 3 lines
and have it wget patches from k.o, verify signatures and auto-apply them, which removes the "admin didnt even know there were patches that needed to be applied" possibility.
That looks like ugly can of worms to me. "what kernel do you have?"
"2.4.25 and it did two downloads; I was compiling it on the friday night"
Quoted 6 lines
Quoted 2 lines
So make one of the patches change extra-version to -errataN or the like.
Basically what we're talking about now is someone to maintain an "errata tree" -- someone to maintain sub-point releases (2.4.25.1, .2, etc.) and to decide what those are.
I agree with this format vs. the ep* format as it would be far easier to find the latest cumulative errata patch... Wouldn't the sub-point release be a part of the errata patch? I think it might get out of hand if there are too many different bits to deal with, the errata tree and sub-point release being seperate I mean.. IE if someone grabs the errata patches they should then be running the most secure and stable version of the current kernel available... This also prevents having multiple trees around that require sync, as there would be no errata patches required for a kernel with no urgent patch releases (either bugfix or security related). 2.4.25 would basically be 2.4.25.0 and until someone finds a show stopping problem there wouldn't be the need for any additional patches...
Regards
James Bourne
Quoted 10 lines
The other option would be to have it called something like 2.4.25-ep36-ep42-ep96 if errata patches 36, 42 and 96 were applied.
I think sub-point releases are better, since it at least cuts down the number of possible combinations.
-hpa
Signature · 5 lines
James Bourne | Email: [email protected] Unix Systems Administrator | WWW: http://www.hardrock.org Custom Unix Programming | Linux: The choice of a GNU generation ---------------------------------------------------------------------- "All you need's an occasional kick in the philosophy." Frank Herbert
Quoted 7 lines
Quoted 1 line
There are vendors, there are free distributions too.
Yes, but that's pretty irrelevant. People should not depend on such sources to get security fixes. Anything so critical should be included in the official kernel as soon as possible -- any reasons against?
What troubles *me* is that obviously I have missed the post with Marcelo's opinion on this.
Signature · 1 line
Tomas Szepe <[email protected]>