Skip to contentSkip to conversation

fix nsp32.c .text.exit error

PATCH In review Adrian Bunk 2 participants 2 messages Mar 27, 2003 – Mar 28, 2003

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 fix nsp32.c .text.exit error

In drivers/scsi/nsp32.c the function nsp32_remove is __devexit but the pointer to it isn't __devexit_p resulting in a .text.exit compile error if !CONFIG_HOTPLUG.

The following patch is needed:

drivers/scsi/nsp32.c renamed from drivers/scsi/nsp32.c.old +1 -1
@@ -2125,7 +2125,7 @@
 	.name =		"nsp32",
 	.id_table =	nsp32_pci_table,
 	.probe =	nsp32_probe,
-	.remove =	nsp32_remove,
+	.remove =	__devexit_p(nsp32_remove),
 #ifdef CONFIG_PM
 /*	.suspend =	nsp32_suspend,*/
 /*	.resume =	nsp32_resume,*/

This patch applies against 2.4.21-pre6 and 2.5.66. I've tested the compilation with 2.4.21-pre6.

Please apply
Adrian

Signature · 4 lines
       "Is there not promise of rain?" Ling Tan asked suddenly out
        of the darkness. There had been need of rain for many days.
       "Only a promise," Lao Er said.
                                       Pearl S. Buck - Dragon Seed
maintainer
#1 lore raw

At Thu, 27 Mar 2003 23:14:11 +0100,

Quoted 19 lines · Adrian Bunk

In drivers/scsi/nsp32.c the function nsp32_remove is __devexit but the pointer to it isn't __devexit_p resulting in a .text.exit compile error if !CONFIG_HOTPLUG.

The following patch is needed:

drivers/scsi/nsp32.c renamed from drivers/scsi/nsp32.c.old +1 -1
@@ -2125,7 +2125,7 @@
 	.name =		"nsp32",
 	.id_table =	nsp32_pci_table,
 	.probe =	nsp32_probe,
-	.remove =	nsp32_remove,
+	.remove =	__devexit_p(nsp32_remove),
 #ifdef CONFIG_PM
 /*	.suspend =	nsp32_suspend,*/
 /*	.resume =	nsp32_resume,*/
Quoted 2 lines

This patch applies against 2.4.21-pre6 and 2.5.66. I've tested the compilation with 2.4.21-pre6.

Looks fine. Thanks!

Regards,
-- gotom