Skip to contentSkip to conversation

fix ad1889.c .text.exit error

PATCH New Adrian Bunk 1 participant 1 message Mar 27, 2003

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 fix ad1889.c .text.exit error

In 2,4,21-pre6 the function ad1889_remove in drivers/sound/ad1889.c is __devexit but the pointer to it doesn't use __devexit_p resulting in a .text.exit error if !CONFIG_HOTPLUG.

The following patch is needed:

drivers/sound/ad1889.c renamed from drivers/sound/ad1889.c.old +1 -1
@@ -1059,7 +1059,7 @@
 	name:		DEVNAME,
 	id_table:	ad1889_id_tbl,
 	probe:		ad1889_probe,
-	remove:		ad1889_remove,
+	remove:		__devexit_p(ad1889_remove),
 };
 
 static int __init ad1889_init_module(void)

I've tested the compilation with 2.4.21-pre6.

Please apply
Adrian

Signature · 4 lines
       "Is there not promise of rain?" Ling Tan asked suddenly out
        of the darkness. There had been need of rain for many days.
       "Only a promise," Lao Er said.
                                       Pearl S. Buck - Dragon Seed