2.5.66 buglet
<boot dmesg snip>devfs_register(cpu/microcode): illegal mode: 8180
</snip>
# ls /dev/cpu # grep -i microcode /boot/2.5.66/.config CONFIG_MICROCODE=y
Not sure how it breaks between .64 where it worked and .66 where it doesn't. The code where it's registered doesn't appear to have changed. arch/i386/kernel/microcode.c, line 137.
david
Quoted 11 lines · David Ford
<boot dmesg snip>
devfs_register(cpu/microcode): illegal mode: 8180
</snip># ls /dev/cpu # grep -i microcode /boot/2.5.66/.config CONFIG_MICROCODE=yNot sure how it breaks between .64 where it worked and .66 where it doesn't. The code where it's registered doesn't appear to have changed.
arch/i386/kernel/microcode.c, line 137.
Please try the appended patch.
arch/i386/kernel/microcode.c +11 -20
@@ -107,7 +107,6 @@static char *mc_applied;/* array of applied microcode blocks */ static unsigned int mc_fsize;/* file size of /dev/cpu/microcode */ -/* we share file_operations between misc and devfs mechanisms */ static struct file_operations microcode_fops = { .owner =THIS_MODULE , .read = microcode_read,
@@ -122,41 +121,33 @@ .fops = µcode_fops, }; -static devfs_handle_t devfs_handle; -static int __init microcode_init (void ) {int error; error =misc_register (µcode_dev);if (error) -printk (KERN_WARNING -"microcode: can't misc_register on minor=%d\n" , -MICROCODE_MINOR ); - - devfs_handle =devfs_register (NULL ,"cpu/microcode" , -DEVFS_FL_DEFAULT ,0 ,0 ,S_IFREG |S_IRUSR |S_IWUSR , - µcode_fops,NULL ); -if (devfs_handle ==NULL && error) { -printk (KERN_ERR "microcode: failed to devfs_register()\n" ); -misc_deregister (µcode_dev); - goto out; - } - error =0 ; + goto fail; + error =devfs_mk_symlink ("cpu/microcode" ,"../misc/microcode" ); +if (error) + goto fail_deregister; +printk (KERN_INFO "IA-32 Microcode Update Driver: v%s <[email protected]>\n" ,MICROCODE_VERSION ); +return 0 ; -out: +fail_deregister: +misc_deregister (µcode_dev); +fail:return error; } static void __exit microcode_exit(void) {misc_deregister (µcode_dev); -devfs_unregister (devfs_handle); -if (mc_applied) -kfree (mc_applied); +devfs_remove ("cpu/microcode" ); +kfree (mc_applied);printk (KERN_INFO "IA-32 Microcode Update Driver v%s unregistered\n" ,MICROCODE_VERSION ); }
arch/i386/kernel/microcode.c line 131
Quoted 1 line · Christoph Hellwig
arch/i386/kernel/microcode.c +1
-0+ error =devfs_mk_symlink ("cpu/microcode" ,"../misc/microcode" );
Where did ../misc/microcode come from? That sounds horribly generic compared to /dev/cpu/microcode
Dave
Quoted 5 lines · Dave Jones
arch/i386/kernel/microcode.c line 131
Quoted 1 line · Christoph Hellwig
arch/i386/kernel/microcode.c +1
-0+ error =devfs_mk_symlink ("cpu/microcode" ,"../misc/microcode" );Where did ../misc/microcode come from? That sounds horribly generic compared to
/dev/cpu/microcode
devfs automatically registers /dev/misc/<name> entries for any minor registered by misc_register.
Quoted 6 lines · Christoph Hellwig
Quoted 3 lines
arch/i386/kernel/microcode.c line 131
Quoted 1 line
arch/i386/kernel/microcode.c +1
-0+ error =devfs_mk_symlink ("cpu/microcode" ,"../misc/microcode" );Where did ../misc/microcode come from? That sounds horribly generic compared to
/dev/cpu/microcodedevfs automatically registers /dev/misc/<name> entries for any minor registered by
misc_register.
That's pretty fucked up IMO. Is it feasable that we could one day have /dev/$otherhardware/microcode, and that would completely screw up this devfs 'feature' ?
Dave