Skip to contentSkip to conversation

Linux 2.4.21-pre7

PATCH In review Marcelo Tosatti 15 participants 40 messages Apr 4, 2003 – Apr 21, 2003

Subsystems (3)
Network drivers VFS exec and binfmt
lore
Share & tools
lore

Marcelo Tosatti

author
#0 lore raw

So here goes -pre7. Hopefully the last -pre.

Please try it.

Summary of changes from v2.4.21-pre6 to v2.4.21-pre7 v2.4.2-pre7
============================================

<[email protected]>:
o PPC64 update

<[email protected]>:
o [E1000] Documentation/networking/e1000.txt updates
o [E1000] Version, copyright, changelog and MAINTAINERS
o [E1000] Spd/dplx abstraction; eeprom size changes
o [E1000] IRQ registration fix
o [E1000] Added 82541 & 82547 support
o [E1000] Added MII support
o [E1000] Modulus math removed
o [E1000] Perform single PCI read per interrupt
o [E1000] Tx Descriptor cleanup
o [E1000] Read/Write register macro optimizations
o [E1000] Compaq to HP branding change
o [E1000] Whitespace changes
o [E1000] Added Tx FIFO flush routine
o [E1000] Added Interrupt Throttle Rate tuning support
o [E1000] Controller wake-up thru ASF fix
o [E1000] whitespace fix from previous patches

<[email protected]>:
o Memleak in KOBIL USB Smart Card Terminal Driver
o USB: more Edgeport USB Serial Converter driver stuff
o USB: Memleak in drivers/usb/hub.c::usb_reset_device
o USB: memleak in Edgeport USB Serial Converter driver

<[email protected]>:
o USB: New ids for scanner driver

<[email protected]>:
o fix e1000 C99 initializer
o fix pcnet32 multicast fix

<[email protected]>:
o USB HID: Ignore P5 Data Glove

<[email protected]>:
o [SPARC64]: Define IDE MAX_HWIFS like x86

<[email protected]>:
o USB: Patch for DSBR-100 driver

<[email protected]>:
o USB: MTU patch for kaweth

Adam Radford <[email protected]>:
o 3ware driver update: Backport 2.5 fixes

Adrian Bunk <[email protected]>:
o trident 1/1 fix operator precedence bug

Alan Cox <[email protected]>:
o arm typo fix
o Update DMI
o later VIA apic
o PCI layer bits for 440GX
o identify SiS 550 SoC
o warning fix
o mips config syntax fix
o iphase fixes
o update char Config.help
o fix char Makefile
o fix mem handling of high areas
o sx memory leak fix
o ibm hot plug driver fix
o resync IDE with -ac
o small isdn fixe
o i2o fixes
o 3c501 typo fix
o dgrs clean
o use ulong for timers
o update pc.ids
o pcmcia oops fix
o config syntax for S/390
o status must be signed
o add aic79xx to makefile
o more megaraid fixups
o dpt_i2o memory leak comments
o fix pcmcia shared irq on qlogicfas
o fix time abuse in qlogicfc
o more AC97 codec support
o leaks brackets and ;s for audio
o forte update from maintainer
o gus fixes
o make i810_audio use ac97 updates
o ixj leak fixes
o aic7xxx updates/aic79xx
o USB HCD deadlock fix
o setup bits for intelfb
o handle radeons that report 0 ram
o ldm leak fix
o ufs leak fix
o Add SIS CPU family ident
o fix time types for tty
o HP now owns compaq, maintainers shipft
o add syskonnect maintainer
o vlan leak fix
o irda leak fix

Alan Stern <[email protected]>:
o USB: Belkin Compact Flash card reader fix

Andrew Morton <[email protected]>:
o /proc/sysrq-trigger: trigger sysrq functions via

Andries E. Brouwer <[email protected]>:
o USB: add better sddr09 support

Arjan van de Ven <[email protected]>:
o usb storage horkage fix

Ben Collins <[email protected]>:
o [SPARC64]: Add image target and fixup archclean

Brad Hards <[email protected]>:
o USB: CDC Ethernet maintainer transfer

Christoph Hellwig <[email protected]>:
o SGI SCSI blacklist entries for 2.4.21-pre6

Christoph Hellwig <[email protected]>:
o fix drm-4.0 compile failure

David Brownell <[email protected]>:
o USB: ehci-hcd, prink tweaks

David S. Miller <[email protected]>:
o [SPARC64]: Use GFP_ATOMIC in request_irq
o [SPARC64]: Fix interrupt enabling on trap return
o [SPARC64]: Update defconfig
o [SPARC64]: Do not define special strip, sparc64-linux-strip is actually normal strip
o [SPARC64]: Get ALI trident sound working again
o [SPARC64]: 2 timer handling fixes

David S. Miller <[email protected]>:
o USB: fix for host controler build

David Woodhouse <[email protected]>:
o Fix erase suspend for write on Intel flash chips
o Fix prototype of jffs2_get_ino_cache() to take unsigned argument

Erik Andersen <[email protected]>:
o missing -ac merge in include/linux/ide.h

Greg Kroah-Hartman <[email protected]>:
o USB: added support for the palm M100
o USB: Added support for the Sony Clie NZ90V device
o USB: add support for Treo devices to the visor driver
o USB: fixup from previous io_ti.c patch
o USB: added support for Ericsson data cable to pl2303 driver
o USB: usb-storage bugfix
o USB: fix up zero packet issues with CDCEther driver

Ivan Kokshaysky <[email protected]>:
o alpha: misc cleanups and fixes
o fix PCI bridge memory sizing

Jay Vosburgh <[email protected]>:
o [bonding] fixes, cleanups, and minor feature addition

Jeff Garzik <[email protected]>:
o [netdrvr tg3] fix memleak in DMA test
o [via-rhine] note that Roger is maintainer, in MAINTAINERS
o [netdrvr pcnet32] revert to 2.4.19 version
o [netdrvr pcnet32] fix multicast on big endian

Johannes Erdfelt <[email protected]>:
o USB: uhci.c 2.4 finish completions in the correct order

Maksim Krasnyanskiy <[email protected]>:
o [Bluetooth] Use very short disconnect timeout for SCO connections.
o [Bluetooth] Kill incoming SCO connection when SCO socket is closed.
o [Bluetooth] Support for SCO (voice) over HCI USB
o [Bluetooth] Do not submit more than one usb bulk rx request. It crashes uhci.o driver.
o [Bluetooth] Use atomic allocations in HCI USB functions called under spinlock

Marcel Holtmann <[email protected]>:

  o Cset exclude: [email protected]|ChangeSet|20030208185812|16161
  o Cset exclude: [email protected]|ChangeSet|20030122214259|16085

o [Bluetooth] Add support for the Ultraport Module from IBM
o [Bluetooth] Use R1 for default value of pscan_rep_mode
o [Bluetooth] Add help entry for CONFIG_BLUEZ_USB_SCO

Marcelo Tosatti <[email protected]>:
o Changed EXTRAVERSION to -pre7
o Add missing PCI ID's from -ac merge
o Add more missing PCI IDS from -ac merge

Matthew Wilcox <[email protected]>:
o Reduce random.c stack usage

Pete Zaitcev <[email protected]>:
o [SPARC64]: Kill ELF_FLAGS_INIT

Roger Luethi <[email protected]>:
o [via-rhine] fix races
o [via-rhine] reset logic
o [via-rhine] changelog

Scott Feldman <[email protected]>:
o [E100] Update Documentation/networking/e100.txt
o [E100] Update version(2.2.21-k1), copyright, changelog
o [E100] spelling corrections from 2.5
o [E100] Add support for VLAN hw offload
o [E100] Cleanup #include order
o [E100] OS already calcs pseudo-hdr [[email protected]]
o [E100] interurpt handler free fix
o [E100] Validate updates to MAC address
o [E100] ethtool EEPROM and GSTRINGS fix
o [E100] ASF wakeup enabled, but only if set in EEPROM
o [E100] Remove strong branded marketing strings
o [E100] forced speed/duplex link recover
o [E100] Honor WOL settings in EEPROM
o [E1000] Increase default Rx descriptors to 256

Stephen C. Tweedie <[email protected]>:
o Add less-severe assert-failure form for ext3
o Fix ext3 panic due to ll_rw_block behaviour after illegal block access
o Fix duplicate #include in journal.c
o Fix jbd assert failure on IO error
o Minor build fix for ext3 (2.4 and 2.5)
o Throttle ENOMEM warnings more aggressively
o Fix flushtime ordering on BUF_DIRTY list

Tom Rini <[email protected]>:
o PPC32: Pass in the memory size on PReP machines

Wolfgang Muees <[email protected]>:
o USB: Memory leak in auerswald driver

#1 lore raw
Quoted 5 lines · Marcelo Tosatti

So here goes -pre7. Hopefully the last -pre.

Alan Cox <[email protected]>:
o PCI layer bits for 440GX

Any pointer for info on this ?

TIA

Signature · 4 lines
J.A. Magallon <[email protected]>      \                 Software is like sex:
werewolf.able.es                         \           It's better when it's free
Mandrake Linux release 9.2 (Bamboo) for i586
Linux 2.4.21-pre6-jam1 (gcc 3.2.2 (Mandrake Linux 9.1 3.2.2-3mdk))
#2 lore raw
Quoted 8 lines · J.A. Magallon
Quoted 5 lines · Marcelo Tosatti

So here goes -pre7. Hopefully the last -pre.

Alan Cox <[email protected]>:
o PCI layer bits for 440GX

Any pointer for info on this ?

The changes to arch/i386/kernel/pci and dmi_scan.c should be fairly self explanatory. We muse use BIOS routing not $PIR routing

#3 lore raw
In reply to Marcelo Tosatti

2.4.21-pre7, same problem Jonathan Vardy described yesterday Promise controllers are not working :

ICH3: IDE controller at PCI slot 00:1f.1
ICH3: chipset revision 2
ICH3: not 100% native mode: will probe irqs later

    ide0: BM-DMA at 0x7040-0x7047, BIOS settings: hda:pio, hdb:pio
    ide1: BM-DMA at 0x7048-0x704f, BIOS settings: hdc:pio, hdd:pio

PDC20270: IDE controller at PCI slot 03:01.0
PDC20270: chipset revision 2
PDC20270: not 100% native mode: will probe irqs later
PDC20270: neither IDE port enabled (BIOS)
PDC20270: neither IDE port enabled (BIOS)
PDC20267: IDE controller at PCI slot 05:06.0
PCI: Found IRQ 11 for device 05:06.0
PDC20267: chipset revision 2
PDC20267: not 100% native mode: will probe irqs later
PDC20267: neither IDE port enabled (BIOS)

(PDC20270= fasttrak tx4/ PDC20267= onboard ultra100)

works ok in 2.4.20

]$ cat /proc/interrupts
CPU0 CPU1 CPU2 CPU3

  0:      34480          0          0          0          XT-PIC  timer
  1:          3          0          0          0          XT-PIC  keyboard
  2:          0          0          0          0          XT-PIC  cascade
  5:       2762          0          0          0          XT-PIC  aic7xxx
  8:          1          0          0          0          XT-PIC  rtc
 10:       4180          0          0          0          XT-PIC  3ware
Storage Controller, eth0
 12:          0          0          0          0          XT-PIC  PS/2
Mouse
 14:         18          0          0          0          XT-PIC  ide0
 15:         18          0          0          0          XT-PIC  ide1
NMI:          0          0          0          0
LOC:      34354      34363      34364      34364
ERR:          0
MIS:          0

]$ cat /proc/pci
PCI devices found:
Bus 0, device 0, function 0:
Host bridge: Intel Corp. e7500 [Plumas] DRAM Controller (rev 3).
Bus 0, device 0, function 1:
Class ff00: Intel Corp. e7500 [Plumas] DRAM Controller Error Reporting
(rev 3).
Bus 0, device 2, function 0:
PCI bridge: Intel Corp. e7500 [Plumas] HI_B Virtual PCI Bridge (F0)
(rev 3).
Master Capable. Latency=64. Min Gnt=6.
Bus 0, device 29, function 0:

    USB Controller: Intel Corp. 82801CA/CAM USB (Hub #1) (rev 2).
      IRQ 10.
      I/O at 0x7000 [0x701f].
  Bus  0, device  29, function  1:
    USB Controller: Intel Corp. 82801CA/CAM USB (Hub #2) (rev 2).
      IRQ 5.
      I/O at 0x7020 [0x703f].
  Bus  0, device  30, function  0:
    PCI bridge: Intel Corp. 82801BA/CA/DB PCI Bridge (rev 66).
      Master Capable.  No bursts.  Min Gnt=14.
  Bus  0, device  31, function  0:
    ISA bridge: Intel Corp. 82801CA ISA Bridge (LPC) (rev 2).
  Bus  0, device  31, function  1:
    IDE interface: Intel Corp. 82801CA IDE U100 (rev 2).
      I/O at 0x7040 [0x704f].
      Non-prefetchable 32 bit memory at 0x20000000 [0x200003ff].
  Bus  0, device  31, function  3:
    SMBus: Intel Corp. 82801CA/CAM SMBus (rev 2).
      IRQ 11.
      I/O at 0x7060 [0x707f].
  Bus  1, device  28, function  0:
    PIC: Intel Corp. 82870P2 P64H2 I/OxAPIC (rev 3).
      Non-prefetchable 32 bit memory at 0xfb100000 [0xfb100fff].
  Bus  1, device  30, function  0:
    PIC: Intel Corp. 82870P2 P64H2 I/OxAPIC (#2) (rev 3).
      Non-prefetchable 32 bit memory at 0xfb101000 [0xfb101fff].
  Bus  1, device  29, function  0:
    PCI bridge: Intel Corp. 82870P2 P64H2 Hub PCI Bridge (rev 3).
      Master Capable.  Latency=64.  Min Gnt=38.
  Bus  1, device  31, function  0:
    PCI bridge: Intel Corp. 82870P2 P64H2 Hub PCI Bridge (#2) (rev 3).
      Master Capable.  Latency=64.  Min Gnt=38.
  Bus  2, device   1, function  0:
    RAID bus controller: 3ware Inc 3ware 7000-series ATA-RAID (rev 1).
      IRQ 10.
      Master Capable.  Latency=72.  Min Gnt=9.
      I/O at 0x8000 [0x800f].
      Non-prefetchable 32 bit memory at 0xfb200000 [0xfb20000f].
      Non-prefetchable 32 bit memory at 0xfb800000 [0xfbffffff].
  Bus  2, device   2, function  0:
    PCI bridge: Digital Equipment Corporation DECchip 21150 (rev 6).
      Master Capable.  Latency=64.  Min Gnt=4.
  Bus  3, device   1, function  0:
    RAID bus controller: Promise Technology, Inc. 20268R (rev 2).
      IRQ 10.
      Master Capable.  Latency=64.  Min Gnt=4.Max Lat=18.
      I/O at 0x9000 [0x9007].
      I/O at 0x9010 [0x9013].
      I/O at 0x9020 [0x9027].
      I/O at 0x9030 [0x9033].
      I/O at 0x9040 [0x904f].
      Non-prefetchable 32 bit memory at 0xfc000000 [0xfc00ffff].
  Bus  3, device   2, function  0:
    RAID bus controller: Promise Technology, Inc. 20268R (#2) (rev 2).
      IRQ 10.
      Master Capable.  Latency=64.  Min Gnt=4.Max Lat=18.
      I/O at 0x9080 [0x9087].
      I/O at 0x9090 [0x9093].
      I/O at 0x90a0 [0x90a7].
      I/O at 0x90b0 [0x90b3].
      I/O at 0x90c0 [0x90cf].
      Non-prefetchable 32 bit memory at 0xfc010000 [0xfc01ffff].
  Bus  4, device   1, function  0:
    Ethernet controller: Intel Corp. 82545EM Gigabit Ethernet Controller
(rev 1).
      IRQ 10.
      Master Capable.  Latency=64.  Min Gnt=255.
      Non-prefetchable 64 bit memory at 0xfc100000 [0xfc11ffff].
      I/O at 0xa000 [0xa03f].
  Bus  5, device   2, function  0:
    SCSI storage controller: Adaptec AHA-2940U/UW/D / AIC-7881U (rev 0).
      IRQ 5.
      Master Capable.  Latency=64.  Min Gnt=8.Max Lat=8.
      I/O at 0xb000 [0xb0ff].
      Non-prefetchable 32 bit memory at 0xfc220000 [0xfc220fff].
  Bus  5, device   3, function  0:
    VGA compatible controller: ATI Technologies Inc Rage XL (rev 39).
      IRQ 11.
      Master Capable.  Latency=66.  Min Gnt=8.
      Non-prefetchable 32 bit memory at 0xfd000000 [0xfdffffff].
      I/O at 0xb400 [0xb4ff].
      Non-prefetchable 32 bit memory at 0xfc221000 [0xfc221fff].
  Bus  5, device   6, function  0:
    RAID bus controller: Promise Technology, Inc. 20267 (rev 2).
      IRQ 11.
      Master Capable.  Latency=64.
      I/O at 0xb850 [0xb857].
      I/O at 0xb844 [0xb847].
      I/O at 0xb848 [0xb84f].
      I/O at 0xb840 [0xb843].
      I/O at 0xb800 [0xb83f].
      Non-prefetchable 32 bit memory at 0xfc200000 [0xfc21ffff].
#4 lore raw
In reply to Marcelo Tosatti
Quoted 5 lines · Marcelo Tosatti

So here goes -pre7. Hopefully the last -pre.

Please try it.

make config/dep bugs. Sorry for not inlining the patch, a new version of balsa has begun to wrap the mail body even if I say it to don't do so...

Signature · 4 lines
J.A. Magallon <[email protected]>        \        Software is like sex:
werewolf.able.es                           \  It's better when it's free
Mandrake Linux release 9.2 (Bamboo) for i586
Linux 2.4.21-pre6-jam1 (gcc 3.2.2 (Mandrake Linux 9.1 3.2.2-3mdk))
#5 lore raw
Quoted 10 lines · J.A. Magallon
Quoted 5 lines · Marcelo Tosatti

So here goes -pre7. Hopefully the last -pre.

Please try it.

make config/dep bugs. Sorry for not inlining the patch, a new version of balsa has begun to wrap the mail body even if I say it to don't do so...

Attach it plain text then most mailers show it happily. I also discovered the wonderful habit evolution now has of wrapping inserts. Ah well another for bugzilla

#6 lore raw
In reply to Marcelo Tosatti
Quoted 5 lines · Marcelo Tosatti

So here goes -pre7. Hopefully the last -pre.

Please try it.

I still have som patches that could go in 2.4.21... Some will follow to this mail, the more obvious. There are other things that do not look so critical.

Could you take a look ?

Signature · 4 lines
J.A. Magallon <[email protected]>        \        Software is like sex:
werewolf.able.es                           \  It's better when it's free
Mandrake Linux release 9.2 (Bamboo) for i586
Linux 2.4.21-pre6-jam1 (gcc 3.2.2 (Mandrake Linux 9.1 3.2.2-3mdk))
#7 lore raw

PATCH 1/1 AT_PLATFORM on HT-P4

Quoted 7 lines · J.A. Magallon
Quoted 5 lines · Marcelo Tosatti

So here goes -pre7. Hopefully the last -pre.

Please try it.

This makes P4 Xeon to report correct i686 platform. Without this, all those people that think its ld.so automatically picks i686 libs are wrong...

Signature · 4 lines
J.A. Magallon <[email protected]>        \        Software is like sex:
werewolf.able.es                           \  It's better when it's free
Mandrake Linux release 9.2 (Bamboo) for i586
Linux 2.4.21-pre6-jam1 (gcc 3.2.2 (Mandrake Linux 9.1 3.2.2-3mdk))
#8 lore raw

Re: [PATCH] AT_PLATFORM on HT-P4

Quoted 3 lines · J.A. Magallon

This makes P4 Xeon to report correct i686 platform. Without this, all those people that think its ld.so automatically picks i686 libs are wrong...

Uhm, why are you posting a really tiny patch as a bzip2 that nobody can read or quote inline?

-ben

Signature · 1 line
Junk email?  <a href="mailto:[email protected]">[email protected]</a>
#9 lore raw

Re: [PATCH] AT_PLATFORM on HT-P4

Quoted 6 lines · Benjamin LaHaise
Quoted 1 line · J.A. Magallon

This makes P4 Xeon to report correct i686 platform. Without this, >

all those people that think its ld.so automatically picks i686 libs

Quoted 1 line

are wrong...

Uhm, why are you posting a really tiny patch as a bzip2 that nobody

can

Quoted 2 lines

read or quote inline?

Sorry, I said it in other post...
I use balsa-cvs as mailer, and I have just discovered that it wraps the mail body at 72 columns even if I say it to don't do any wrapping.

Signature · 6 lines
J.A. Magallon <[email protected]>      \                 Software is
like sex:
werewolf.able.es                         \           It's better when
it's free
Mandrake Linux release 9.2 (Bamboo) for i586
Linux 2.4.21-pre7-jam1 (gcc 3.2.2 (Mandrake Linux 9.2 3.2.2-5mdk))
#10 lore raw

Re: [PATCH] AT_PLATFORM on HT-P4

Quoted 3 lines · J.A. Magallon

Sorry, I said it in other post...
I use balsa-cvs as mailer, and I have just discovered that it wraps the mail body at 72 columns even if I say it to don't do any wrapping.

You have the source, and you know that people like to read patches on l-k... Don't you remember the numerous lectures from Linus et al about unquotable patches being bad? I think there's even an entry in the lkml FAQ on this very topic.

-ben

Signature · 1 line
Junk email?  <a href="mailto:[email protected]">[email protected]</a>
#11 lore raw

PATCH 1/1 redundant printk decl

In reply to J.A. Magallon
Quoted 8 lines · J.A. Magallon
Quoted 5 lines · Marcelo Tosatti

So here goes -pre7. Hopefully the last -pre.

Please try it.

Signature · 4 lines
J.A. Magallon <[email protected]>        \        Software is like sex:
werewolf.able.es                           \  It's better when it's free
Mandrake Linux release 9.2 (Bamboo) for i586
Linux 2.4.21-pre6-jam1 (gcc 3.2.2 (Mandrake Linux 9.1 3.2.2-3mdk))
#12 lore raw

PATCH 1/1 thread signaling

In reply to J.A. Magallon
Quoted 8 lines · J.A. Magallon
Quoted 5 lines · Marcelo Tosatti

So here goes -pre7. Hopefully the last -pre.

Please try it.

Fix bad signaling between threads when ancestor dies.
Author: Zeuner, Axel <[email protected]>

Signature · 4 lines
J.A. Magallon <[email protected]>        \        Software is like sex:
werewolf.able.es                           \  It's better when it's free
Mandrake Linux release 9.2 (Bamboo) for i586
Linux 2.4.21-pre6-jam1 (gcc 3.2.2 (Mandrake Linux 9.1 3.2.2-3mdk))
#13 lore raw

Re: [PATCH] thread signaling

Quoted 3 lines · J.A. Magallon

Fix bad signaling between threads when ancestor dies.
Author: Zeuner, Axel <[email protected]>

Could you send these plain text instead of bzip2 so we can actually review them

#14 lore raw

PATCH 1/1 detached clone

In reply to J.A. Magallon
Quoted 8 lines · J.A. Magallon
Quoted 5 lines · Marcelo Tosatti

So here goes -pre7. Hopefully the last -pre.

Please try it.

Fix a crash that can be caused by a CLONE_DETACHED thread.
Author: Ingo Molnar <[email protected]>

Signature · 4 lines
J.A. Magallon <[email protected]>        \        Software is like sex:
werewolf.able.es                           \  It's better when it's free
Mandrake Linux release 9.2 (Bamboo) for i586
Linux 2.4.21-pre6-jam1 (gcc 3.2.2 (Mandrake Linux 9.1 3.2.2-3mdk))
#15 lore raw

PATCH 1/1 e1000 close

In reply to J.A. Magallon
Quoted 6 lines · J.A. Magallon
Quoted 4 lines · Marcelo Tosatti

So here goes -pre7. Hopefully the last -pre.

Please try it.

Not sure if this is still needed. Mr Feldman, plz ?

Signature · 4 lines
J.A. Magallon <[email protected]>        \        Software is like sex:
werewolf.able.es                           \  It's better when it's free
Mandrake Linux release 9.2 (Bamboo) for i586
Linux 2.4.21-pre6-jam1 (gcc 3.2.2 (Mandrake Linux 9.1 3.2.2-3mdk))
author
#16 lore raw
In reply to J.A. Magallon
Quoted 5 lines · J.A. Magallon
Quoted 3 lines · Marcelo Tosatti

So here goes -pre7. Hopefully the last -pre.

Quoted 8 lines
Quoted 2 lines

Please try it.

I still have som patches that could go in 2.4.21... Some will follow to this mail, the more obvious. There are other things that do not look so critical.

Could you take a look ?

Sure.

#17 lore raw
In reply to Marcelo Tosatti

Thus spake Marcelo Tosatti:

Quoted 1 line

o more AC97 codec support

It looks like something didn't make it in with this, drivers/sound/ac97_codec.c now fails to compile.

gcc -D__KERNEL__ -I/usr/src/linux-2.4.21-pre7/include -Wall -Wstrict-prototypes -Wno-trigraphs -O2 -fno-strict-aliasing -fno-common -fomit-frame-pointer -pipe -mpreferred-stack-boundary=2 -march=athlon -DMODULE -nostdinc -iwithprefix include -DKBUILD_BASENAME=ac97_codec -DEXPORT_SYMTAB -c ac97_codec.c

ac97_codec.c:131: `AC97_NO_PCM_VOLUME' undeclared here (not in a function)
ac97_codec.c:131: initializer element is not constant ac97_codec.c:131: (near initialization for ac97_codec_ids[12].flags') ac97_codec.c:131: initializer element is not constant ac97_codec.c:131: (near initialization for ac97_codec_ids[12]') ac97_codec.c:132: `AC97_NO_PCM_VOLUME' undeclared here (not in a function)
ac97_codec.c:132: initializer element is not constant ac97_codec.c:132: (near initialization for ac97_codec_ids[13].flags') ac97_codec.c:132: initializer element is not constant ac97_codec.c:132: (near initialization for ac97_codec_ids[13]') ac97_codec.c:133: `AC97_NO_PCM_VOLUME' undeclared here (not in a function)
ac97_codec.c:133: initializer element is not constant ac97_codec.c:133: (near initialization for ac97_codec_ids[14].flags') ac97_codec.c:133: initializer element is not constant ac97_codec.c:133: (near initialization for ac97_codec_ids[14]') ac97_codec.c:134: initializer element is not constant ac97_codec.c:134: (near initialization for ac97_codec_ids[15]') ac97_codec.c:135: initializer element is not constant ac97_codec.c:135: (near initialization for ac97_codec_ids[16]') ac97_codec.c:136: initializer element is not constant ac97_codec.c:136: (near initialization for ac97_codec_ids[17]') ac97_codec.c:137: initializer element is not constant ac97_codec.c:137: (near initialization for ac97_codec_ids[18]') ac97_codec.c:138: initializer element is not constant ac97_codec.c:138: (near initialization for ac97_codec_ids[19]') ac97_codec.c:139: initializer element is not constant ac97_codec.c:139: (near initialization for ac97_codec_ids[20]') ac97_codec.c:140: initializer element is not constant ac97_codec.c:140: (near initialization for ac97_codec_ids[21]') ac97_codec.c:141: initializer element is not constant ac97_codec.c:141: (near initialization for ac97_codec_ids[22]') ac97_codec.c:142: initializer element is not constant ac97_codec.c:142: (near initialization for ac97_codec_ids[23]') ac97_codec.c:143: initializer element is not constant ac97_codec.c:143: (near initialization for ac97_codec_ids[24]') ac97_codec.c:144: `AC97_DELUDED_MODEM' undeclared here (not in a function)
ac97_codec.c:144: initializer element is not constant ac97_codec.c:144: (near initialization for ac97_codec_ids[25].flags') ac97_codec.c:144: initializer element is not constant ac97_codec.c:144: (near initialization for ac97_codec_ids[25]') ac97_codec.c:145: initializer element is not constant ac97_codec.c:145: (near initialization for ac97_codec_ids[26]') ac97_codec.c:146: initializer element is not constant ac97_codec.c:146: (near initialization for ac97_codec_ids[27]') ac97_codec.c:147: initializer element is not constant ac97_codec.c:147: (near initialization for ac97_codec_ids[28]') ac97_codec.c:148: initializer element is not constant ac97_codec.c:148: (near initialization for ac97_codec_ids[29]') ac97_codec.c:149: initializer element is not constant ac97_codec.c:149: (near initialization for ac97_codec_ids[30]') ac97_codec.c:150: initializer element is not constant ac97_codec.c:150: (near initialization for ac97_codec_ids[31]') ac97_codec.c:151: initializer element is not constant ac97_codec.c:151: (near initialization for ac97_codec_ids[32]') ac97_codec.c:152: initializer element is not constant ac97_codec.c:152: (near initialization for ac97_codec_ids[33]') ac97_codec.c:153: initializer element is not constant ac97_codec.c:153: (near initialization for ac97_codec_ids[34]') ac97_codec.c:154: initializer element is not constant ac97_codec.c:154: (near initialization for ac97_codec_ids[35]') ac97_codec.c:155: initializer element is not constant ac97_codec.c:155: (near initialization for ac97_codec_ids[36]') ac97_codec.c:156: initializer element is not constant ac97_codec.c:156: (near initialization for ac97_codec_ids[37]') ac97_codec.c:157: initializer element is not constant ac97_codec.c:157: (near initialization for ac97_codec_ids[38]') ac97_codec.c:158: initializer element is not constant ac97_codec.c:158: (near initialization for ac97_codec_ids[39]') ac97_codec.c:159: initializer element is not constant ac97_codec.c:159: (near initialization for ac97_codec_ids[40]') ac97_codec.c:160: initializer element is not constant ac97_codec.c:160: (near initialization for ac97_codec_ids[41]') ac97_codec.c:161: initializer element is not constant ac97_codec.c:161: (near initialization for ac97_codec_ids[42]') ac97_codec.c:162: initializer element is not constant ac97_codec.c:162: (near initialization for ac97_codec_ids[43]') ac97_codec.c:163: initializer element is not constant ac97_codec.c:163: (near initialization for ac97_codec_ids[44]') ac97_codec.c:164: initializer element is not constant ac97_codec.c:164: (near initialization for ac97_codec_ids[45]') ac97_codec.c:165: initializer element is not constant ac97_codec.c:165: (near initialization for ac97_codec_ids[46]') ac97_codec.c:166: initializer element is not constant ac97_codec.c:166: (near initialization for ac97_codec_ids[47]') ac97_codec.c:167: initializer element is not constant ac97_codec.c:167: (near initialization for ac97_codec_ids[48]') ac97_codec.c:168: initializer element is not constant ac97_codec.c:168: (near initialization for ac97_codec_ids[49]') ac97_codec.c:169: initializer element is not constant ac97_codec.c:169: (near initialization for ac97_codec_ids[50]') ac97_codec.c: In function ac97_probe_codec':
ac97_codec.c:763: structure has no member named modem' ac97_codec.c:774: structure has no member named flags' ac97_codec.c:780: structure has no member named flags' ac97_codec.c:780: AC97_DELUDED_MODEM' undeclared (first use in this function)
ac97_codec.c:780: (Each undeclared identifier is reported only once ac97_codec.c:780: for each function it appears in.) ac97_codec.c:781: structure has no member named modem' ac97_codec.c:786: structure has no member named modem' ac97_codec.c: In function `ac97_init_mixer':
ac97_codec.c:808: structure has no member named flags' ac97_codec.c:808: AC97_NO_PCM_VOLUME' undeclared (first use in this function)
ac97_codec.c:839: structure has no member named `flags' make[3]: *** [ac97_codec.o] Error 1
make[3]: Leaving directory `/usr/src/linux-2.4.21-pre7/drivers/sound' make[2]: *** [_modsubdir_sound] Error 2
make[2]: Leaving directory `/usr/src/linux-2.4.21-pre7/drivers' make[1]: *** [_mod_drivers] Error 2
make[1]: Leaving directory `/usr/src/linux-2.4.21-pre7'

Signature · 3 lines
Nathan Poznick <[email protected]>

"A fishfinder -- in a hospital??" -Tom Servo. #405
#18 lore raw

Re: Linux 2.4.21-pre7 - hpt366.c does not build

In reply to Marcelo Tosatti
Quoted 4 lines · Marcelo Tosatti

So here goes -pre7. Hopefully the last -pre.

Please try it.

gcc -D__KERNEL__ -I/data2/usr/local/src/linux-2.4-pre/include -Wall -Wstrict-pro
totypes -Wno-trigraphs -O2 -fno-strict-aliasing -fno-common -fomit-frame-pointer
-pipe -mpreferred-stack-boundary=2 -march=i686 -malign-functions=4
-I../ -nost
dinc -iwithprefix include -DKBUILD_BASENAME=hpt366 -c -o hpt366.o hpt366.c
In file included from hpt366.c:70:
hpt366.h:517: `PCI_DEVICE_ID_TTI_HPT372N' undeclared here (not in a function)
hpt366.h:517: initializer element is not constant hpt366.h:517: (near initialization for hpt366_chipsets[5].device') hpt366.c: In function hpt_revision':
hpt366.c:183: `PCI_DEVICE_ID_TTI_HPT372N' undeclared (first use in this function
)
hpt366.c:183: (Each undeclared identifier is reported only once hpt366.c:183: for each function it appears in.) hpt366.c:184: warning: unreachable code at beginning of switch statement hpt366.c: In function `init_setup_hpt366':
hpt366.c:1227: `PCI_DEVICE_ID_TTI_HPT372N' undeclared (first use in this functio
n)
hpt366.c: At top level:
hpt366.c:1289: `PCI_DEVICE_ID_TTI_HPT372N' undeclared here (not in a function)
hpt366.c:1289: initializer element is not constant hpt366.c:1289: (near initialization for `hpt366_pci_tbl[5].device') make[4]: *** [hpt366.o] Error 1
make[4]: Leaving directory `/data2/usr/local/src/linux-2.4-pre/drivers/ide/pci'

--
Eyal Lebedinsky ([email protected]) <http://samba.org/eyal/>

author
#19 lore raw

Re: Linux 2.4.21-pre7 - hpt366.c does not build

Quoted 8 lines · Eyal Lebedinsky

hpt366.c: At top level:
hpt366.c:1289: `PCI_DEVICE_ID_TTI_HPT372N' undeclared here (not in a function)
hpt366.c:1289: initializer element is not constant hpt366.c:1289: (near initialization for `hpt366_pci_tbl[5].device') make[4]: *** [hpt366.o] Error 1
make[4]: Leaving directory `/data2/usr/local/src/linux-2.4-pre/drivers/ide/pci'

Fixed in -BK tree.

#20 lore raw
In reply to Marcelo Tosatti

On Fri, 4 Apr 2003 18:15:52 -0300 (BRT) Marcelo Tosatti (MT) wrote:

MT> So here goes -pre7. Hopefully the last -pre.
MT>
MT> Please try it.

Hi Marcelo et al,

-pre7 (and possibly earlier versions) don't build with IPv6-Netfilter. My .config is attached.

Best regards,
-Udo.

ld -m elf_i386 -r -o netfilter.o ip6_tables.o ip6t_limit.o ip6t_mac.o ip6t_rt.o ip6t_hbh.o ip6t_dst.o ip6t_ipv6header.o ip6t_multiport.o ip6table_filter.o ip6t_LOG.o
ip6t_hbh.o(.text+0x0): In function `ipv6_ext_hdr':
: multiple definition of ipv6_ext_hdr' ip6t_rt.o(.text+0x0): first defined here ip6t_dst.o(.text+0x0): In function ipv6_ext_hdr':
: multiple definition of ipv6_ext_hdr' ip6t_rt.o(.text+0x0): first defined here ip6t_ipv6header.o(.text+0x0): In function ipv6_ext_hdr':
: multiple definition of `ipv6_ext_hdr' ip6t_rt.o(.text+0x0): first defined here
make[3]: *** [netfilter.o] Error 1

#21 lore raw
In reply to Marcelo Tosatti
Quoted 4 lines · Marcelo Tosatti

So here goes -pre7. Hopefully the last -pre.

Please try it.

Hi.

It seems the 2.4.21-pre7 doesn't build without pci support.

***********

ld -m elf_i386 -T /usr/src/linux-2.4.21-pre7/arch/i386/vmlinux.lds -e stext arch/i386/kernel/head.o arch/i386/kernel/init_task.o init/main.o init/version.o init/do_mounts.o \
        --start-group \
        arch/i386/kernel/kernel.o arch/i386/mm/mm.o kernel/kernel.o mm/mm.o fs/fs.o ipc/ipc.o \
         drivers/char/char.o drivers/block/block.o drivers/misc/misc.o drivers/net/net.o drivers/ide/idedriver.o drivers/scsi/scsidrv.o drivers/cdrom/driver.o drivers/video/video.o drivers/media/media.o \
        net/network.o \
        /usr/src/linux-2.4.21-pre7/arch/i386/lib/lib.a /usr/src/linux-2.4.21-pre7/lib/lib.a /usr/src/linux-2.4.21-pre7/arch/i386/lib/lib.a \
        --end-group \
        -o vmlinux

arch/i386/kernel/kernel.o: In function `broken_pirq':
arch/i386/kernel/kernel.o(.text.init+0x32c4): undefined reference to broken_440gx_bios' arch/i386/kernel/kernel.o(.text.init+0x32ce): undefined reference to pci_probe'make: *** [vmlinux] Error 1
*************

My .config is attached.

A 2.4.21-pre6 with the same options builds.

Regards
--
Jerome Chantelauze

#
# Automatically generated by make menuconfig: don't edit #
CONFIG_X86=y
CONFIG_UID16=y

#
# Code maturity level options
#
# CONFIG_EXPERIMENTAL is not set

#
# Loadable module support
#
CONFIG_MODULES=y
CONFIG_KMOD=y

#
# Processor type and features
#
CONFIG_M486=y
CONFIG_X86_WP_WORKS_OK=y
CONFIG_X86_INVLPG=y
CONFIG_X86_CMPXCHG=y
CONFIG_X86_XADD=y
CONFIG_X86_BSWAP=y
CONFIG_X86_POPAD_OK=y
CONFIG_RWSEM_XCHGADD_ALGORITHM=y
CONFIG_X86_L1_CACHE_SHIFT=4
CONFIG_X86_USE_STRING_486=y
CONFIG_X86_ALIGNMENT_16=y
CONFIG_X86_PPRO_FENCE=y
CONFIG_NOHIGHMEM=y

#
# General setup
#
CONFIG_NET=y
CONFIG_ISA=y
CONFIG_SYSVIPC=y
CONFIG_SYSCTL=y
CONFIG_KCORE_ELF=y
CONFIG_BINFMT_AOUT=m
CONFIG_BINFMT_ELF=y
CONFIG_BINFMT_MISC=m

#
# Parallel port support
#
CONFIG_PARPORT=m
CONFIG_PARPORT_PC=m
CONFIG_PARPORT_PC_CML1=m

#
# Block devices
#
CONFIG_BLK_DEV_FD=y
CONFIG_BLK_DEV_LOOP=m
CONFIG_BLK_DEV_RAM=m
CONFIG_BLK_DEV_RAM_SIZE=4096

#
# Networking options
#
CONFIG_PACKET=y
CONFIG_NETFILTER=y
CONFIG_UNIX=y
CONFIG_INET=y
CONFIG_SYN_COOKIES=y

#
# IP: Netfilter Configuration
#
CONFIG_IP_NF_COMPAT_IPCHAINS=m
CONFIG_IP_NF_NAT_NEEDED=y

#
# ATA/IDE/MFM/RLL support
#
CONFIG_IDE=y

#
# IDE, ATA and ATAPI Block devices
#
CONFIG_BLK_DEV_HD_ONLY=y
CONFIG_BLK_DEV_HD=y
CONFIG_BLK_DEV_IDE_MODES=y

#
# SCSI support
#
CONFIG_SCSI=y
CONFIG_BLK_DEV_SD=y
CONFIG_SD_EXTRA_DEVS=40
CONFIG_BLK_DEV_SR=m
CONFIG_SR_EXTRA_DEVS=2
CONFIG_CHR_DEV_SG=m

#
# SCSI low-level drivers
#
CONFIG_SCSI_AHA1542=y

#
# Network device support
#
CONFIG_NETDEVICES=y
CONFIG_DUMMY=m

#
# Ethernet (10 or 100Mbit)
#
CONFIG_NET_ETHERNET=y
CONFIG_NET_ISA=y
CONFIG_NE2000=y

CONFIG_PPP=m
CONFIG_PPP_ASYNC=m
CONFIG_PPP_DEFLATE=m
CONFIG_PPP_BSDCOMP=m
CONFIG_SLIP=m
CONFIG_SLIP_COMPRESSED=y

#
# Character devices
#
CONFIG_VT=y
CONFIG_VT_CONSOLE=y
CONFIG_SERIAL=y
CONFIG_UNIX98_PTYS=y
CONFIG_UNIX98_PTY_COUNT=256
CONFIG_PRINTER=m

#
# Watchdog Cards
#
CONFIG_RTC=y

#
# File systems
#
CONFIG_AUTOFS4_FS=y
CONFIG_EXT3_FS=y
CONFIG_JBD=y
CONFIG_FAT_FS=m
CONFIG_MSDOS_FS=m
CONFIG_VFAT_FS=m
CONFIG_RAMFS=y
CONFIG_ISO9660_FS=m
CONFIG_JOLIET=y
CONFIG_PROC_FS=y
CONFIG_DEVPTS_FS=y
CONFIG_EXT2_FS=m

#
# Network File Systems
#
CONFIG_NFS_FS=y
CONFIG_NFS_V3=y
CONFIG_SUNRPC=y
CONFIG_LOCKD=y
CONFIG_LOCKD_V4=y

#
# Partition Types
#
CONFIG_MSDOS_PARTITION=y
CONFIG_NLS=y

#
# Native Language Support
#
CONFIG_NLS_DEFAULT="iso8859-1"
CONFIG_NLS_CODEPAGE_437=m
CONFIG_NLS_ISO8859_1=y
CONFIG_NLS_ISO8859_15=m
CONFIG_NLS_UTF8=m

#
# Console drivers
#
CONFIG_VGA_CONSOLE=y

#
# Sound
#
CONFIG_SOUND=m
CONFIG_SOUND_OSS=m
CONFIG_SOUND_DMAP=y
CONFIG_SOUND_SB=m

#
# Library routines
#
CONFIG_ZLIB_INFLATE=m
CONFIG_ZLIB_DEFLATE=m

#22 lore raw
In reply to Marcelo Tosatti
Quoted 3 lines · Marcelo Tosatti

So here goes -pre7. Hopefully the last -pre.

Well, my problem with wrapping is gone, so I will resubmit the things inlined...

Signature · 4 lines
J.A. Magallon <[email protected]>      \                 Software is like sex:
werewolf.able.es                         \           It's better when it's free
Mandrake Linux release 9.2 (Bamboo) for i586
Linux 2.4.21-pre7-jam1 (gcc 3.2.2 (Mandrake Linux 9.2 3.2.2-5mdk))
#23 lore raw

PATCH 1/1 AT_PLATFORM on HT-P4

Quoted 6 lines · J.A. Magallon
Quoted 3 lines · Marcelo Tosatti

So here goes -pre7. Hopefully the last -pre.

This makes P4 Xeon to report correct i686 platform. Without this, all those people that think its ld.so automatically picks i686 libs are wrong...

The original code takes u_platform for coyping ELF_PLATFORM, but also supposes it is the top of stack. This changes when we have siblings:

if(smp_num_siblings > 1)
u_platform = u_platform - ((current->pid % 64) << 7);

Later:

        NEW_AUX_ENT(0, AT_PLATFORM, (elf_addr_t)(unsigned long) u_platform);

that on HT cpus is broken, isn't it ?

This separates the two things, stack top and u_platform. It could be even cleaner, with something like

stack_top = p;
if (k_platform)
sz = strlen(k_platform)+1
u_platform = stack_top - sz
__copy_to_user(...)
stack_top -= sz
else
u_platform = NULL
...
if(smp_num_siblings > 1)

        stack_top = stack_top - ((current->pid % 64) << 7);
...
if (u_platform)
	NEW_AUX_ENT(...)

But I have not tested it. Current patch below.

fs/binfmt_elf.c renamed from fs/binfmt_elf.c.orig +7 -5
@@ -116,11 +116,14 @@
 	elf_caddr_t *argv;
 	elf_caddr_t *envp;
 	elf_addr_t *sp, *csp;
+	char *stack_top;
 	char *k_platform, *u_platform;
 	long hwcap;
 	size_t platform_len = 0;
 	size_t len;
 
+	stack_top = p;
+
 	/*
 	 * Get hold of platform and hardware capabilities masks for
 	 * the machine we are running on.  In some cases (Sparc), 

@@ -135,8 +138,8 @@
 		platform_len = strlen(k_platform) + 1;
 		u_platform = p - platform_len;
 		__copy_to_user(u_platform, k_platform, platform_len);
-	} else
-		u_platform = p;
+		stack_top = u_platform;
+	}
 
 #if defined(__i386__) && defined(CONFIG_SMP)
 	/*

@@ -149,15 +152,14 @@
 	 * processors. This keeps Mr Marcelo Person happier but should be
 	 * removed for 2.5
 	 */
-	 
 	if(smp_num_siblings > 1)
-		u_platform = u_platform - ((current->pid % 64) << 7);
+		stack_top -= ((current->pid % NR_CPUS) << 7);
 #endif	
 
 	/*
 	 * Force 16 byte _final_ alignment here for generality.
 	 */
-	sp = (elf_addr_t *)(~15UL & (unsigned long)(u_platform));
+	sp = (elf_addr_t *)(~15UL & (unsigned long)(stack_top));
 	csp = sp;
 	csp -= (1+DLINFO_ITEMS)*2 + (k_platform ? 2 : 0);
 #ifdef DLINFO_ARCH_ITEMS
Signature · 4 lines
J.A. Magallon <[email protected]>      \                 Software is like sex:
werewolf.able.es                         \           It's better when it's free
Mandrake Linux release 9.2 (Bamboo) for i586
Linux 2.4.21-pre7-jam1 (gcc 3.2.2 (Mandrake Linux 9.2 3.2.2-5mdk))
#24 lore raw
In reply to J.A. Magallon
Quoted 3 lines · J.A. Magallon
Quoted 1 line · Marcelo Tosatti

This kills a redundant printk declaration. AFAIR it broke some people's builds.

include/asm-i386/spinlock.h 2002-10-15 10:12:35.000000000 +0100 renamed from include/asm-i386/spinlock.h.orig 2002-10-15 10:12:25.000000000 +0100 +0 -3
@@ -6,9 +6,6 @@
 #include <asm/page.h>
 #include <linux/config.h>
 
-extern int printk(const char * fmt, ...)
-	__attribute__ ((format (printf, 1, 2)));
-
 /* It seems that people are forgetting to
  * initialize their spinlocks properly, tsk tsk.
  * Remember to turn this off in 2.4. -ben
Signature · 4 lines
J.A. Magallon <[email protected]>      \                 Software is like sex:
werewolf.able.es                         \           It's better when it's free
Mandrake Linux release 9.2 (Bamboo) for i586
Linux 2.4.21-pre7-jam1 (gcc 3.2.2 (Mandrake Linux 9.2 3.2.2-5mdk))
#25 lore raw

PATCH 1/1 config/dep bugs

In reply to J.A. Magallon
Quoted 5 lines · J.A. Magallon
Quoted 3 lines · Marcelo Tosatti

So here goes -pre7. Hopefully the last -pre.

drivers/net/Config.in renamed from drivers/net/Config.in.orig +1 -1
@@ -185,7 +185,7 @@
       dep_tristate '    Davicom DM910x/DM980x support' CONFIG_DM9102 $CONFIG_PCI
       dep_tristate '    EtherExpressPro/100 support (eepro100, original Becker driver)' CONFIG_EEPRO100 $CONFIG_PCI
       if [ "$CONFIG_VISWS" = "y" ]; then
-         define_mbool CONFIG_EEPRO100_PIO y
+         define_bool CONFIG_EEPRO100_PIO y
       else
          dep_mbool '      Use PIO instead of MMIO' CONFIG_EEPRO100_PIO $CONFIG_EEPRO100
       fi
drivers/ide/Config.in renamed from drivers/ide/Config.in.orig +1 -1
@@ -43,7 +43,7 @@
 	    define_bool CONFIG_BLK_DEV_IDEDMA $CONFIG_BLK_DEV_IDEDMA_PCI
 	    dep_bool '      ATA Work(s) In Progress (EXPERIMENTAL)' CONFIG_IDEDMA_PCI_WIP $CONFIG_BLK_DEV_IDEDMA_PCI $CONFIG_EXPERIMENTAL
 #	    dep_bool '      Good-Bad DMA Model-Firmware (WIP)' CONFIG_IDEDMA_NEW_DRIVE_LISTINGS $CONFIG_IDEDMA_PCI_WIP
-            dep_tristate '    Pacific Digital ADMA-100 basic support' CONFIG_BLK_DEV_ADMA100
+            dep_tristate '    Pacific Digital ADMA-100 basic support' CONFIG_BLK_DEV_ADMA100 $CONFIG_BLK_DEV_IDEDMA_PCI
 	    dep_tristate '    AEC62XX chipset support' CONFIG_BLK_DEV_AEC62XX $CONFIG_BLK_DEV_IDEDMA_PCI
 	    dep_tristate '    ALI M15x3 chipset support' CONFIG_BLK_DEV_ALI15X3 $CONFIG_BLK_DEV_IDEDMA_PCI
 	    dep_mbool    '      ALI M15x3 WDC support (DANGEROUS)' CONFIG_WDC_ALI15X3 $CONFIG_BLK_DEV_ALI15X3
Signature · 4 lines
J.A. Magallon <[email protected]>      \                 Software is like sex:
werewolf.able.es                         \           It's better when it's free
Mandrake Linux release 9.2 (Bamboo) for i586
Linux 2.4.21-pre7-jam1 (gcc 3.2.2 (Mandrake Linux 9.2 3.2.2-5mdk))
#26 lore raw

Re: [PATCH] config/dep bugs

Hi,

I found these bugs too, but only when I start "make xconfig". Using "make menuconfig" does not produce these errors. May this be considered a bug in "make menuconfig"?

Kind regards
Karl Weigel

Quoted 31 lines · J.A. Magallon
Quoted 2 lines · Marcelo Tosatti
Quoted 1 line

So here goes -pre7. Hopefully the last -pre.

drivers/net/Config.in renamed from drivers/net/Config.in.orig +0 -0
@@ -185,7 +185,7 @@
       dep_tristate '    Davicom DM910x/DM980x support' CONFIG_DM9102
 $CONFIG_PCI dep_tristate '    EtherExpressPro/100 support (eepro100,

original Becker driver)' CONFIG_EEPRO100 $CONFIG_PCI if [ "$CONFIG_VISWS" = "y" ]; then

drivers/net/Config.in renamed from drivers/net/Config.in.orig +1 -1
-         define_mbool CONFIG_EEPRO100_PIO y
+         define_bool CONFIG_EEPRO100_PIO y
       else
          dep_mbool '      Use PIO instead of MMIO' CONFIG_EEPRO100_PIO

$CONFIG_EEPRO100 fi

drivers/ide/Config.in renamed from drivers/ide/Config.in.orig +0 -0
@@ -43,7 +43,7 @@
 	    define_bool CONFIG_BLK_DEV_IDEDMA $CONFIG_BLK_DEV_IDEDMA_PCI
 	    dep_bool '      ATA Work(s) In Progress (EXPERIMENTAL)'

CONFIG_IDEDMA_PCI_WIP $CONFIG_BLK_DEV_IDEDMA_PCI $CONFIG_EXPERIMENTAL #
dep_bool ' Good-Bad DMA Model-Firmware (WIP)'
CONFIG_IDEDMA_NEW_DRIVE_LISTINGS $CONFIG_IDEDMA_PCI_WIP -
dep_tristate ' Pacific Digital ADMA-100 basic support'
CONFIG_BLK_DEV_ADMA100 + dep_tristate ' Pacific Digital
ADMA-100 basic support' CONFIG_BLK_DEV_ADMA100 $CONFIG_BLK_DEV_IDEDMA_PCI
dep_tristate ' AEC62XX chipset support' CONFIG_BLK_DEV_AEC62XX
$CONFIG_BLK_DEV_IDEDMA_PCI dep_tristate ' ALI M15x3 chipset support'
CONFIG_BLK_DEV_ALI15X3 $CONFIG_BLK_DEV_IDEDMA_PCI dep_mbool ' ALI
M15x3 WDC support (DANGEROUS)' CONFIG_WDC_ALI15X3 $CONFIG_BLK_DEV_ALI15X3

#27 lore raw

PATCH 1/1 thread signaling

In reply to J.A. Magallon
Quoted 6 lines · J.A. Magallon
Quoted 3 lines · Marcelo Tosatti

So here goes -pre7. Hopefully the last -pre.

Fix bad signaling between threads when ancestor dies.
Author: Zeuner, Axel <[email protected]>

I forwarded the author, if he wants to give some explanations...

kernel/exit.c renamed from kernel/exit.c.orig +1 -1
@@ -369,7 +369,7 @@
 	 *	
 	 */
 	
-	if(current->exit_signal != SIGCHLD &&
+	if(current->exit_signal != SIGCHLD && current->exit_signal != -1 &&
 	    ( current->parent_exec_id != t->self_exec_id  ||
 	      current->self_exec_id != current->parent_exec_id) 
 	    && !capable(CAP_KILL))
Signature · 4 lines
J.A. Magallon <[email protected]>      \                 Software is like sex:
werewolf.able.es                         \           It's better when it's free
Mandrake Linux release 9.2 (Bamboo) for i586
Linux 2.4.21-pre7-jam1 (gcc 3.2.2 (Mandrake Linux 9.2 3.2.2-5mdk))
#28 lore raw

PATCH 1/1 detached cloning

In reply to J.A. Magallon
Quoted 6 lines · J.A. Magallon
Quoted 3 lines · Marcelo Tosatti

So here goes -pre7. Hopefully the last -pre.

Fix a crash that can be caused by a CLONE_DETACHED thread.
Author: Ingo Molnar <[email protected]>

Does this still apply, Ingo ?

kernel/exit.c renamed from kernel/exit.c.orig +1 -1
@@ -369,7 +369,7 @@
 	 *	
 	 */
 	
-	if(current->exit_signal != SIGCHLD &&
+	if(current->exit_signal != SIGCHLD && current->exit_signal != -1 &&
 	    ( current->parent_exec_id != t->self_exec_id  ||
 	      current->self_exec_id != current->parent_exec_id) 
 	    && !capable(CAP_KILL))
Signature · 4 lines
J.A. Magallon <[email protected]>      \                 Software is like sex:
werewolf.able.es                         \           It's better when it's free
Mandrake Linux release 9.2 (Bamboo) for i586
Linux 2.4.21-pre7-jam1 (gcc 3.2.2 (Mandrake Linux 9.2 3.2.2-5mdk))
#29 lore raw

Re: [PATCH] detached cloning

Quoted 17 lines · J.A. Magallon
Quoted 6 lines · J.A. Magallon
Quoted 3 lines · Marcelo Tosatti

So here goes -pre7. Hopefully the last -pre.

Fix a crash that can be caused by a CLONE_DETACHED thread.
Author: Ingo Molnar <[email protected]>

Does this still apply, Ingo ?

kernel/exit.c line 375

Quoted 8 lines
kernel/exit.c renamed from kernel/exit.c.orig +1 -1
@@ -369,7 +369,7 @@
 	 *	
 	 */
 
-	if(current->exit_signal != SIGCHLD &&
+	if(current->exit_signal != SIGCHLD && current->exit_signal != -1 &&
 	    ( current->parent_exec_id != t->self_exec_id  ||
 	      current->self_exec_id != current->parent_exec_id) 
 	    && !capable(CAP_KILL))

CLONE_DETACHED isn't even in 2.4 except in Red Hat kernels.

Signature · 2 lines
Daniel Jacobowitz
MontaVista Software                         Debian GNU/Linux Developer
#30 lore raw

Re: [PATCH] detached cloning

Quoted 13 lines · Daniel Jacobowitz
Quoted 12 lines · J.A. Magallon
Quoted 6 lines · J.A. Magallon
Quoted 3 lines · Marcelo Tosatti

So here goes -pre7. Hopefully the last -pre.

Fix a crash that can be caused by a CLONE_DETACHED thread.
Author: Ingo Molnar <[email protected]>

[...]

Quoted 3 lines

CLONE_DETACHED isn't even in 2.4 except in Red Hat kernels.

But pthreads can spawn detached threads. Can this have any effect ?

Signature · 4 lines
J.A. Magallon <[email protected]>      \                 Software is like sex:
werewolf.able.es                         \           It's better when it's free
Mandrake Linux release 9.2 (Cooker) for i586
Linux 2.4.21-pre7-jam1 (gcc 3.2.2 (Mandrake Linux 9.2 3.2.2-5mdk))
#31 lore raw

Re: [PATCH] detached cloning

Quoted 15 lines · J.A. Magallon
Quoted 6 lines · Daniel Jacobowitz
Quoted 5 lines · J.A. Magallon
Quoted 3 lines · J.A. Magallon
Quoted 1 line · Marcelo Tosatti
Quoted 7 lines
Quoted 7 lines
Quoted 3 lines
Quoted 2 lines

So here goes -pre7. Hopefully the last -pre.

Fix a crash that can be caused by a CLONE_DETACHED thread.
Author: Ingo Molnar <[email protected]>

Quoted 6 lines

[...]

Quoted 3 lines

CLONE_DETACHED isn't even in 2.4 except in Red Hat kernels.

But pthreads can spawn detached threads. Can this have any effect ?

Detached threads actually have no relationship to CLONE_DETACHED. In NPTL all threads are CLONE_DETACHED whether they're detached or not; in LinuxThreads they never are, also regardless.

Signature · 2 lines
Daniel Jacobowitz
MontaVista Software                         Debian GNU/Linux Developer
#32 lore raw

PATCH 1/1 e1000 close

In reply to J.A. Magallon
Quoted 6 lines · J.A. Magallon
Quoted 3 lines · Marcelo Tosatti

So here goes -pre7. Hopefully the last -pre.

Supposed to cure a dev_close called without dev_open. Is this still needed ?

drivers/net/e1000/e1000_main.c renamed from drivers/net/e1000/e1000_main.c.orig +6 -0
@@ -997,6 +997,9 @@
 	unsigned long size;
 	int i;
 
+	if(!adapter->tx_ring.buffer_info)
+		return;
+
 	/* Free all the Tx ring sk_buffs */
 
 	for(i = 0; i < adapter->tx_ring.count; i++) {

@@ -1062,6 +1065,9 @@
 	unsigned long size;
 	int i;
 
+	if(!adapter->rx_ring.buffer_info)
+		return;
+
 	/* Free all the Rx ring sk_buffs */
 
 	for(i = 0; i < adapter->rx_ring.count; i++) {
Signature · 4 lines
J.A. Magallon <[email protected]>      \                 Software is like sex:
werewolf.able.es                         \           It's better when it's free
Mandrake Linux release 9.2 (Bamboo) for i586
Linux 2.4.21-pre7-jam1 (gcc 3.2.2 (Mandrake Linux 9.2 3.2.2-5mdk))
#33 lore raw

Re: [PATCH] e1000 close

Quoted 2 lines · J.A. Magallon

Supposed to cure a dev_close called without dev_open. Is this still needed ?

If ->close is called on a device that is not open then the fix is not the driver, the fix is the core code fix.

#34 lore raw
In reply to Marcelo Tosatti
Quoted 2 lines

So here goes -pre7. Hopefully the last -pre.

Won't compile for my PPC:
---
-o vmlinux
drivers/ide/idedriver.o(.text+0x1a544): In function `pmac_outbsync':
: undefined reference to io_flush' drivers/ide/idedriver.o(.text+0x1a544): In function pmac_outbsync':
: relocation truncated to fit: R_PPC_REL24 io_flush drivers/ide/idedriver.o(.text.pmac+0x118): In function `pmac_ide_selectproc':
: undefined reference to io_flush' drivers/ide/idedriver.o(.text.pmac+0x118): In function pmac_ide_selectproc':
: relocation truncated to fit: R_PPC_REL24 io_flush drivers/ide/idedriver.o(.text.pmac+0x1b4): In function `pmac_ide_kauai_selectproc':
: undefined reference to io_flush' drivers/ide/idedriver.o(.text.pmac+0x1b4): In function pmac_ide_kauai_selectproc':
: relocation truncated to fit: R_PPC_REL24 io_flush drivers/ide/idedriver.o(.text.pmac+0x2a4): In function `pmac_ide_do_setfeature':
: undefined reference to io_flush' drivers/ide/idedriver.o(.text.pmac+0x2a4): In function pmac_ide_do_setfeature':
: relocation truncated to fit: R_PPC_REL24 io_flush drivers/ide/idedriver.o(.text.pmac+0x1bcc): In function `pmac_ide_dma_read':
: undefined reference to io_flush' drivers/ide/idedriver.o(.text.pmac+0x1bcc): In function pmac_ide_dma_read':
: relocation truncated to fit: R_PPC_REL24 io_flush drivers/ide/idedriver.o(.text.pmac+0x1d48): more undefined references to `io_flush' follow
drivers/ide/idedriver.o(.text.pmac+0x1d48): In function `pmac_ide_dma_write':
: relocation truncated to fit: R_PPC_REL24 io_flush drivers/ide/idedriver.o(.text.pmac+0x1e70): In function `pmac_ide_dma_begin':
: relocation truncated to fit: R_PPC_REL24 io_flush drivers/ide/idedriver.o(.text.pmac+0x2088): In function `idepmac_sleep_device':
: relocation truncated to fit: R_PPC_REL24 io_flush
make: *** [vmlinux] Error 1

#35 lore raw
Quoted 9 lines · Kaj-Michael Lang
Quoted 2 lines

So here goes -pre7. Hopefully the last -pre.

Won't compile for my PPC:
---
-o vmlinux
drivers/ide/idedriver.o(.text+0x1a544): In function `pmac_outbsync':
: undefined reference to io_flush' drivers/ide/idedriver.o(.text+0x1a544): In function pmac_outbsync':
: relocation truncated to fit: R_PPC_REL24 io_flush

Someone updated pmac.c without testing it: io_flush() doesn't exist in 2.4.21-pre. Based on the diff from -pre6 to -pre7, I'd say the following is a reasonable approximation. My PM4400 runs with this patch right now.

/Mikael

drivers/ide/ppc/pmac.c renamed from drivers/ide/ppc/pmac.c.~1~ +2 -0
@@ -50,6 +50,8 @@
 #undef IDE_PMAC_DEBUG
 #define DMA_WAIT_TIMEOUT	500
 
+#define io_flush(x) (void)(x)
+
 typedef struct pmac_ide_hwif {
 	ide_ioreg_t			regbase;
 	unsigned long			mapbase;
#36 lore raw
Quoted 11 lines · On Wed, 2003-04-09 at 11:55, [email protected] wrote:
Quoted 9 lines · Kaj-Michael Lang
Quoted 2 lines

So here goes -pre7. Hopefully the last -pre.

Won't compile for my PPC:
---
-o vmlinux
drivers/ide/idedriver.o(.text+0x1a544): In function `pmac_outbsync':
: undefined reference to io_flush' drivers/ide/idedriver.o(.text+0x1a544): In function pmac_outbsync':
: relocation truncated to fit: R_PPC_REL24 io_flush

Quoted 4 lines

Someone updated pmac.c without testing it: io_flush() doesn't exist in 2.4.21-pre. Based on the diff from -pre6 to -pre7, I'd say the following is a reasonable approximation. My PM4400 runs with this patch right now.

Or just get my devel rsync.

Actually, what happened is that Marcelo took the version that was in -ac tree, which I sent to Alan a while ago and is now outdated. The io_flush macro was something I added to the arch includes and later removed as I fixed the problem differently.

Marcelo: I sent you a fixed version, please do not apply this patch but rather the one I sent you.

Ben.

#37 lore raw
Quoted 19 lines · Benjamin Herrenschmidt
Quoted 11 lines · On Wed, 2003-04-09 at 11:55, [email protected] wrote:
Quoted 9 lines · Kaj-Michael Lang
Quoted 2 lines

So here goes -pre7. Hopefully the last -pre.

Won't compile for my PPC:
---
-o vmlinux
drivers/ide/idedriver.o(.text+0x1a544): In function `pmac_outbsync':
: undefined reference to io_flush' drivers/ide/idedriver.o(.text+0x1a544): In function pmac_outbsync':
: relocation truncated to fit: R_PPC_REL24 io_flush

Quoted 4 lines

Someone updated pmac.c without testing it: io_flush() doesn't exist in 2.4.21-pre. Based on the diff from -pre6 to -pre7, I'd say the following is a reasonable approximation. My PM4400 runs with this patch right now.

Or just get my devel rsync.

Quoted 7 lines

Actually, what happened is that Marcelo took the version that was in -ac tree, which I sent to Alan a while ago and is now outdated. The io_flush macro was something I added to the arch includes and later removed as I fixed the problem differently.

Marcelo: I sent you a fixed version, please do not apply this patch but rather the one I sent you.

Ok, I can understand what happened, but shouldn't these fixes be cc:d to or at last announced on LKML as well? It could be a month before Marcelo does a -pre8 or -rc1.

#38 lore raw
Quoted 3 lines · On Wed, 2003-04-09 at 12:20, [email protected] wrote:

Ok, I can understand what happened, but shouldn't these fixes be cc:d to or at last announced on LKML as well? It could be a month before Marcelo does a -pre8 or -rc1.

Well.. Most PPC users use the PPC trees and most pmac users use mine, so I didn't bother, but here it is:

drivers/ide/ppc/pmac.c +11 -13
diff -urN linux-2.4/drivers/ide/ppc/pmac.c linuxppc_benh_devel/drivers/ide/ppc/pmac.c
@@ -1,5 +1,5 @@
 /*
- * linux/drivers/ide/ppc/ide-pmac.c
+ * linux/drivers/ide/ppc/pmac.c
  *
  * Support for IDE interfaces on PowerMacs.
  * These IDE interfaces are memory-mapped and have a DBDMA channel

@@ -408,7 +408,7 @@
 	else
 		writel(pmif->timings[0],
 			(unsigned *)(IDE_DATA_REG+IDE_TIMING_CONFIG));
-	io_flush(readl((unsigned *)(IDE_DATA_REG+IDE_TIMING_CONFIG)));
+	(void)readl((unsigned *)(IDE_DATA_REG+IDE_TIMING_CONFIG));
 }
 
 static void __pmac

@@ -430,7 +430,7 @@
 		writel(pmif->timings[2],
 		       (unsigned *)(IDE_DATA_REG + IDE_KAUAI_ULTRA_CONFIG));
 	}
-	io_flush(readl((unsigned *)(IDE_DATA_REG + IDE_KAUAI_PIO_CONFIG)));
+	(void)readl((unsigned *)(IDE_DATA_REG + IDE_KAUAI_PIO_CONFIG));
 }
 
 static void __pmac

@@ -454,7 +454,6 @@
 	
 	writeb(value, port);	
 	tmp = readl((unsigned *)(IDE_DATA_REG + IDE_TIMING_CONFIG));
-	io_flush(value);
 }
 
 static int __pmac

@@ -469,7 +468,7 @@
 	SELECT_MASK(drive, 0);
 	udelay(1);
 	/* Get rid of pending error state */
-	io_flush(hwif->INB(IDE_STATUS_REG));
+	(void)hwif->INB(IDE_STATUS_REG);
 	/* Timeout bumped for some powerbooks */
 	if (wait_for_ready(drive, 2000)) {
 		/* Timeout bumped for some powerbooks */

@@ -1139,7 +1138,7 @@
 		/* Tell common code _not_ to mess with resources */
 		hwif->mmio = 2;
 		hwif->hwif_data = pmif;
-		pmac_ide_init_hwif_ports(&hwif->hw, base, 0, &hwif->irq);
+		pmac_ide_init_hwif_ports(&hwif->hw, regbase, 0, &hwif->irq);
 		memcpy(hwif->io_ports, hwif->hw.io_ports, sizeof(hwif->io_ports));
 		hwif->chipset = ide_pmac;
 		hwif->noprobe = !hwif->io_ports[IDE_DATA_OFFSET] || in_bay;

@@ -1568,7 +1567,7 @@
 	if (ata4 && (pmif->timings[unit] & TR_66_UDMA_EN)) {
 		writel(pmif->timings[unit]+0x00800000UL,
 			(unsigned *)(IDE_DATA_REG+IDE_TIMING_CONFIG));
-		io_flush(readl((unsigned *)(IDE_DATA_REG + IDE_TIMING_CONFIG)));
+		(void)readl((unsigned *)(IDE_DATA_REG + IDE_TIMING_CONFIG));
 	}
 
 	drive->waiting_for_dma = 1;	

@@ -1624,7 +1623,7 @@
 	if (ata4 && (pmif->timings[unit] & TR_66_UDMA_EN)) {
 		writel(pmif->timings[unit],
 			(unsigned *)(IDE_DATA_REG+IDE_TIMING_CONFIG));
-		io_flush(readl((unsigned *)(IDE_DATA_REG + IDE_TIMING_CONFIG)));
+		(void)readl((unsigned *)(IDE_DATA_REG + IDE_TIMING_CONFIG));
 	}
 
 	drive->waiting_for_dma = 1;

@@ -1674,7 +1673,7 @@
 
 	writel((RUN << 16) | RUN, &dma->control);
 	/* Make sure it gets to the controller right now */
-	io_flush(readl(&dma->control));
+	(void)readl(&dma->control);
 	return 0;
 }
 

@@ -1791,11 +1790,10 @@
 			printk(KERN_ERR "ide-pmac(%s): can't request DMA resource !\n", np->name);
 			return;
 		}
+		pmif->dma_regs =
+			(volatile struct dbdma_regs*)ioremap(np->addrs[1].address, 0x200);
 	}
 
-	pmif->dma_regs =
-		(volatile struct dbdma_regs*)ioremap(np->addrs[1].address, 0x200);
-
 	/*
 	 * Allocate space for the DBDMA commands.
 	 * The +2 is +1 for the stop command and +1 to allow for

@@ -1863,7 +1861,7 @@
 		SELECT_DRIVE(drive);
 		SELECT_MASK(drive, 0);
 		hwif->OUTB(drive->select.all, IDE_SELECT_REG);
-		io_flush(hwif->INB(IDE_SELECT_REG));
+		(void) hwif->INB(IDE_SELECT_REG);
 		udelay(100);
 		hwif->OUTB(0x00, IDE_SECTOR_REG);
 		hwif->OUTB(0x00, IDE_NSECTOR_REG);
#39 lore raw
In reply to [email protected]
Quoted 3 lines · At 11:20 09/04/2003, [email protected] wrote:

Ok, I can understand what happened, but shouldn't these fixes be cc:d to or at last announced on LKML as well? It could be a month before Marcelo does a -pre8 or -rc1.

Please, given the number of compile failures in pre7 can we have pre8 in the next few days?

Thanks

Ruth