Skip to contentSkip to conversation

make devpts filesystem mandatory even for CONFIG_DEVFS

PATCH New Christoph Hellwig 1 participant 1 message Apr 6, 2003 Char and misc drivers

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 make devpts filesystem mandatory even for CONFIG_DEVFS

This patch rips out handling of UNIX98 ptys from devfs. We already have a special small filesystem to handle it (devpts) that's always compiled in anyway. This allows to get rid of all DEVFS_FL* flags and some gunk in devfs.

Please add a sentence about this in your relnotes, to avoid confusion for devfs users who don't mount devfspts and don't get unix98 pty support anymore (traditional ptys still work fine so there shouldn't be any real problems even if they forget it)

drivers/char/pty.c +0 -8
@@ -305,7 +305,6 @@
 	}
 }
 
-extern void tty_register_devfs (struct tty_driver *driver, unsigned int flags, unsigned minor);
 static int pty_open(struct tty_struct *tty, struct file * filp)
 {
 	int	retval;
@@ -333,13 +332,6 @@
 	wake_up_interruptible(&pty->open_wait);
 	set_bit(TTY_THROTTLED, &tty->flags);
 	set_bit(TTY_DO_WRITE_WAKEUP, &tty->flags);
-
-	/*  Register a slave for the master  */
-	if (tty->driver.major == PTY_MASTER_MAJOR)
-		tty_register_devfs(&tty->link->driver,
-				   DEVFS_FL_CURRENT_OWNER | DEVFS_FL_WAIT,
-				   tty->link->driver.minor_start +
-				   minor(tty->device)-tty->driver.minor_start);
 	retval = 0;
 out:
 	return retval;

===== drivers/char/tty_io.c 1.67 vs edited =====

drivers/char/tty_io.c +32 -43

129 lines not on this page · raw message