Old hard disk (MFM/RLL/IDE) driver not build.

Hi.

I applied Stephane Ouellette's patch on my linux 2.4.21-pre7. Now, the kernel builds.

But, there's a problem with the IDE support (problem also present in 2.4.21-pre6, but not in 2.4.20).

I configure the kernel to use the "Old hard disk (MFM/RLL/IDE)" driver:

#
# IDE, ATA and ATAPI Block devices
#
# CONFIG_BLK_DEV_IDE is not set
CONFIG_BLK_DEV_HD_ONLY=y
CONFIG_BLK_DEV_HD=y
...

drivers/ide/Makefile does not compile the drivers/ide/legacy/ subdir and generates an empty idedriver.o because CONFIG_BLK_DEV_IDE is not set. Setting this option would result in a driver not compatible with my old hardware.

The following patch fixes the problem, but is it ok ?

*** linux-2.4.21-pre7/drivers/ide/Makefile.orig Sat Apr 5 18:57:07 2003
--- linux-2.4.21-pre7/drivers/ide/Makefile Sat Apr 5 19:16:48 2003
***************
*** 21,26 ****
--- 21,28 ----

  subdir-$(CONFIG_BLK_DEV_IDE) += legacy ppc arm raid pci

+ subdir-$(CONFIG_BLK_DEV_HD_ONLY) += legacy
+
# First come modules that register themselves with the core

ifeq ($(CONFIG_BLK_DEV_IDE),y)
***************
*** 48,53 ****
--- 50,59 ----

    obj-y               += legacy/idedriver-legacy.o
    obj-y               += ppc/idedriver-ppc.o
    obj-y               += arm/idedriver-arm.o

+ endif
+
+ ifeq ($(CONFIG_BLK_DEV_HD_ONLY),y)
+ obj-y += legacy/idedriver-legacy.o
endif

  ifeq ($(CONFIG_BLK_DEV_IDE),y)

Regards.
--
Jerome Chantelauze.