Skip to contentSkip to conversation

ALSA: some missing pnp_unregister_card_driver

PATCH New Daniel Ritz 1 participant 1 message Apr 10, 2003 Sound

lore
Share & tools
lore

Daniel Ritz

author
#0 lore raw

PATCH 1/1 ALSA: some missing pnp_unregister_card_driver

hi jaroslav

this patch fixes some missing pnp_unregister_card_driver. w/o it a second modprobe causes a crash in kobject_add when the first modprobe failed... (tested only with opl3sa2...it didn't see my chip, modprobe opl3sa2 (the working oss one) -> boom, same for 2x modprobe snd-opl3sa2)

against 2.5.67-bk.

rgds
-daniel

===== sound/isa/als100.c 1.13 vs edited =====

sound/isa/als100.c +3 -0
@@ -329,7 +329,10 @@
 	cards += pnp_register_card_driver(&als100_pnpc_driver);
 #ifdef MODULE
 	if (!cards)
+	{
+		pnp_unregister_card_driver(&als100_pnpc_driver);
 		snd_printk(KERN_ERR "no ALS100 based soundcards found\n");
+	}
 #endif
 	return cards ? 0 : -ENODEV;
 }

===== sound/isa/azt2320.c 1.10 vs edited =====

sound/isa/azt2320.c +3 -0
@@ -366,7 +366,10 @@
 	cards += pnp_register_card_driver(&azt2320_pnpc_driver);
 #ifdef MODULE
 	if (!cards)
+	{
+		pnp_unregister_card_driver(&azt2320_pnpc_driver);
 		snd_printk(KERN_ERR "no AZT2320 based soundcards found\n");
+	}
 #endif
 	return cards ? 0 : -ENODEV;
 }

===== sound/isa/cmi8330.c 1.14 vs edited =====

sound/isa/cmi8330.c +3 -0
@@ -613,6 +613,9 @@
 #endif
 
 	if (!cards) {
+#ifdef CONFIG_PNP
+		pnp_unregister_card_driver(&cmi8330_pnpc_driver);
+#endif
 #ifdef MODULE
 		snd_printk(KERN_ERR "CMI8330 not found or device busy\n");
 #endif

===== sound/isa/es18xx.c 1.16 vs edited =====

sound/isa/es18xx.c +3 -0
@@ -2243,6 +2243,9 @@
 	cards += pnp_register_card_driver(&es18xx_pnpc_driver);
 #endif
 	if(!cards) {
+#ifdef CONFIG_PNP
+		pnp_unregister_card_driver(&es18xx_pnpc_driver);
+#endif
 #ifdef MODULE
 		snd_printk(KERN_ERR "ESS AudioDrive ES18xx soundcard not found or device busy\n");
 #endif

===== sound/isa/opl3sa2.c 1.16 vs edited =====

sound/isa/opl3sa2.c +3 -0
@@ -894,6 +894,9 @@
 #ifdef MODULE
 		snd_printk(KERN_ERR "Yamaha OPL3-SA soundcard not found or device busy\n");
 #endif
+#ifdef CONFIG_PNP
+		pnp_unregister_card_driver(&opl3sa2_pnpc_driver);
+#endif
 		return -ENODEV;
 	}
 	return 0;

===== sound/isa/ad1816a/ad1816a.c 1.8 vs edited =====

sound/isa/ad1816a/ad1816a.c +3 -0
@@ -308,7 +308,10 @@
 	cards += pnp_register_card_driver(&ad1816a_pnpc_driver);
 #ifdef MODULE
 	if (!cards)
+	{
+		pnp_unregister_card_driver(&ad1816a_pnpc_driver);
 		printk(KERN_ERR "no AD1816A based soundcards found.\n");
+	}
 #endif	/* MODULE */
 	return cards ? 0 : -ENODEV;
 }

===== sound/isa/cs423x/cs4236.c 1.14 vs edited =====

sound/isa/cs423x/cs4236.c +3 -0
@@ -590,6 +590,9 @@
 	cards += pnp_register_card_driver(&cs423x_pnpc_driver);
 #endif
 	if (!cards) {
+#ifdef CONFIG_PNP
+		pnp_unregister_card_driver(&cs423x_pnpc_driver);
+#endif
 #ifdef MODULE
 		printk(KERN_ERR IDENT " soundcard not found or device busy\n");
 #endif

===== sound/isa/opti9xx/opti92x-ad1848.c 1.13 vs edited =====

sound/isa/opti9xx/opti92x-ad1848.c +3 -0
@@ -2202,6 +2202,9 @@
 
 	cards = pnp_register_card_driver(&opti9xx_pnpc_driver);
 	if (cards == 0 && (error = snd_card_opti9xx_probe(NULL, NULL)) < 0) {
+#ifdef CONFIG_PNP
+		pnp_unregister_card_driver(&opti9xx_pnpc_driver);
+#endif
 #ifdef MODULE
 #ifdef OPTi93X
 		printk(KERN_ERR "no OPTi 82C93x soundcard found\n");

===== sound/isa/sb/es968.c 1.12 vs edited =====

sound/isa/sb/es968.c +4 -1
@@ -224,10 +224,13 @@
 static int __init alsa_card_es968_init(void)
 {
 	int res = pnp_register_card_driver(&es968_pnpc_driver);
-#ifdef MODULE
 	if (res == 0)
+	{
+		pnp_unregister_card_driver(&es968_pnpc_driver);
+#ifdef MODULE
 		snd_printk(KERN_ERR "no ES968 based soundcards found\n");
 #endif
+	}
 	return res < 0 ? res : 0;
 }

===== sound/isa/sb/sb16.c 1.15 vs edited =====

sound/isa/sb/sb16.c +3 -0
@@ -625,6 +625,9 @@
 #endif
 
 	if (!cards) {
+#ifdef CONFIG_PNP
+		pnp_unregister_card_driver(&sb16_pnpc_driver);
+#endif
 #ifdef MODULE
 		snd_printk(KERN_ERR "Sound Blaster 16 soundcard not found or device busy\n");
 #ifdef SNDRV_SBAWE_EMU8000

===== sound/isa/wavefront/wavefront.c 1.11 vs edited =====

sound/isa/wavefront/wavefront.c +5 -0
@@ -709,6 +709,9 @@
 	cards += pnp_register_card_driver(&wavefront_pnpc_driver);
 #endif
 	if (!cards) {
+#ifdef CONFIG_PNP
+		pnp_unregister_card_driver(&wavefront_pnpc_driver);
+#endif
 #ifdef MODULE
 		printk (KERN_ERR "No WaveFront cards found or devices busy\n");
 #endif

@@ -721,7 +724,9 @@
 {
 	int idx;
 
+#ifdef CONFIG_PNP
 	pnp_unregister_card_driver(&wavefront_pnpc_driver);
+#endif
 	for (idx = 0; idx < SNDRV_CARDS; idx++)
 		snd_card_free(snd_wavefront_legacy[idx]);
 }