Skip to contentSkip to conversation

Fix CPU Names in Kconfig

PATCH In review Andi Kleen 4 participants 5 messages Apr 21, 2003 – Apr 22, 2003

lore
Share & tools
lore

Andi Kleen

author
#0 lore raw

PATCH 1/1 Fix CPU Names in Kconfig

Add Xeon Names to Kconfig.

OldXeon for the P3 based Xeons is a bit confusing, but we cannot fix the Intel marchitecture here.

-Andi

arch/i386/Kconfig renamed from arch/i386/Kconfig-o +2 -2
diff -u linux-2.5.68-gencpu/arch/i386/Kconfig-o linux-2.5.68-gencpu/arch/i386/Kconfig
@@ -183,7 +183,7 @@
 	  optimizations.
 
 config MPENTIUMIII
-	bool "Pentium-III/Celeron(Coppermine)"
+	bool "Pentium-III/Celeron(Coppermine)/OldXeon"
 	help
 	  Select this for Intel chips based on the Pentium-III and
 	  Celeron-Coppermine core.  This option enables use of some
@@ -191,7 +191,7 @@
 	  extensions.
 
 config MPENTIUM4
-	bool "Pentium-4/Celeron(P4-based)"
+	bool "Pentium-4/Celeron(P4-based)/Xeon(P4-based)"
 	help
 	  Select this for Intel Pentium 4 chips.  This includes both
 	  the Pentium 4 and P4-based Celeron chips.  This option
#1 lore raw
Quoted 3 lines · Andi Kleen

OldXeon for the P3 based Xeons is a bit confusing, but we cannot fix the Intel marchitecture here.

That's wrong. The P4-based Xeons are just "Xeon". The PIII-based Xeons are "Pentium III Xeon".

Linus

#2 lore raw
In reply to Andi Kleen
Quoted 2 lines · Andi Kleen

OldXeon for the P3 based Xeons is a bit confusing, but we cannot fix the Intel marchitecture here.

"Pentium II/III Xeon" v "Pentium IV Xeon"

At least thats what ebay user seem to use to distinguish 8)

author
#3 lore raw
Quoted 7 lines · Alan Cox
Quoted 2 lines · Andi Kleen

OldXeon for the P3 based Xeons is a bit confusing, but we cannot fix the Intel marchitecture here.

"Pentium II/III Xeon" v "Pentium IV Xeon"

At least thats what ebay user seem to use to distinguish 8)

The reason I didn't do it is that it cannot be easily typed in make oldconfig / make config

(but it probably should offer an numeric menu for these cases I guess...)

Fixed version for Linus.

arch/i386/Kconfig renamed from arch/i386/Kconfig-o +2 -2
diff -u linux-2.5.68-gencpu/arch/i386/Kconfig-o linux-2.5.68-gencpu/arch/i386/Kconfig
@@ -183,7 +183,7 @@
 	  optimizations.
 
 config MPENTIUMIII
-	bool "Pentium-III/Celeron(Coppermine)"
+	bool "Pentium-III/Celeron(Coppermine)/Pentium III Xeon"
 	help
 	  Select this for Intel chips based on the Pentium-III and
 	  Celeron-Coppermine core.  This option enables use of some
@@ -191,7 +191,7 @@
 	  extensions.
 
 config MPENTIUM4
-	bool "Pentium-4/Celeron(P4-based)"
+	bool "Pentium-4/Celeron(P4-based)/Pentium IV Xeon"
 	help
 	  Select this for Intel Pentium 4 chips.  This includes both
 	  the Pentium 4 and P4-based Celeron chips.  This option
#4 lore raw
Quoted 9 lines · Andi Kleen
Quoted 7 lines · Alan Cox
Quoted 2 lines · Andi Kleen

OldXeon for the P3 based Xeons is a bit confusing, but we cannot fix the Intel marchitecture here.

"Pentium II/III Xeon" v "Pentium IV Xeon"

At least thats what ebay user seem to use to distinguish 8)

Quoted 7 lines

The reason I didn't do it is that it cannot be easily typed in make oldconfig / make config

(but it probably should offer an numeric menu for these cases I guess...)

Fixed version for Linus.
...

There were also Pentium II Xeons.