meye driver update
PATCH 1/1 meye driver update
Hi,
The attached patch:
* replaces the pci_alloc_consistent calls with dma_alloc_coherent because we want to do the allocations at GFP_KERNEL priority and not GFP_ATOMIC because we request quite a bit of memory and the allocation fails quite frequently.
It would be better to have a pci_alloc_consistent with an extra parameter (priority) but since we haven't, and the meye driver is supposed to work only on ix86 platforms we can safely do the change.
* fixes the DMA engine stop request. The hard freezes encountered when using this driver and repeatedly opening/closing the device have been tracked down to this particular piece of code. The new version seems to work way better, I haven't had a single freeze since the change.
* fixes the irq handler prototype (irqreturn_t changes).
Linus, please apply.
Stelian.
===== drivers/media/video/meye.h 1.7 vs edited =====
drivers/media/video/meye.h +1 -1
@@ -31,7 +31,7 @@#define _MEYE_PRIV_H_#define MEYE_DRIVER_MAJORVERSION 1 -#define MEYE_DRIVER_MINORVERSION 6 +#define MEYE_DRIVER_MINORVERSION 7#include <linux/config.h> #include <linux/types.h>
===== drivers/media/video/meye.c 1.15 vs edited =====
drivers/media/video/meye.c +35 -32
141 lines not on this page · raw message
Signature · 1 line
Stelian Pop <[email protected]>