Skip to contentSkip to conversation

unchecked_isa_dma on sparcv9

DISCUSSION Christoph Hellwig 2 participants 3 messages Apr 29, 2003 SCSI

lore
Share & tools
lore
#0 lore raw

drivers/scsi/pluto.c contains the following code:

#ifdef __sparc_v9__
			host->unchecked_isa_dma = 1;

#endif

The only thing host->unchecked_isa_dma = 1 does is to add a __GFP_DMA flag to certain memory allocations, but IIRC __GFP_DMA is a noop on sparcv9. So what is this supposed to do?

#1 lore raw

From: Christoph Hellwig <[email protected]>
Date: Tue, 29 Apr 2003 10:19:25 +0200

drivers/scsi/pluto.c contains the following code:

   #ifdef __sparc_v9__
   			host->unchecked_isa_dma = 1;
   #endif

The only thing host->unchecked_isa_dma = 1 does is to add a __GFP_DMA flag to certain memory allocations, but IIRC __GFP_DMA is a noop on sparcv9. So what is this supposed to do?

It's bogus, delete it.

#2 lore raw
Quoted 5 lines · David S. Miller

The only thing host->unchecked_isa_dma = 1 does is to add a __GFP_DMA flag to certain memory allocations, but IIRC __GFP_DMA is a noop on sparcv9. So what is this supposed to do?

It's bogus, delete it.

James, could you please apply the following patch?

drivers/scsi/pluto.c +0 -5
@@ -246,11 +246,6 @@
 				host->max_channel = inq->channels;
 				host->irq = fc->irq;
 
-#ifdef __sparc_v9__
-				host->unchecked_isa_dma = 1;
-#endif
-
-
 				fc->channels = inq->channels + 1;
 				fc->targets = inq->targets;
 				fc->ages = ages;