MPCFADS860T -- any active uboot developers?

U-Boot-Users Nye Liu 2 participants 3 messages May 1, 2003

Share & tools

Nye Liu

author

2003-05-01 00:47 UTC #0 lore raw

I have u-boot up and running on a MPC860T-FADS eval board, but it is extremely unstable... are there active FADS developers using this board currently?

Also, Wolfgang, I have one or two minor patches for this board, but I'm not sure if the differences are intentional. One of the patches adds a FLASH_ internal define to flash.h; last time I did this (in ppc-boot) you indicated not to add any more of those.. what is the policy for adding those in u-boot?

Signature · 6 lines

Nye Liu
nliu at mrv.com
(818) 772-6235x248

"Who would be stupid enough to quote a fictitious character?"
	-- Don Quixote

Wolfgang Denk

2003-05-01 10:18 UTC #1 lore raw

Quoted 3 lines · In message <[email protected]> you wrote:

I have u-boot up and running on a MPC860T-FADS eval board, but it is extremely unstable... are there active FADS developers using this board currently?

I guess you see just what many people experienced on the FADS: the board itself is unstable.

Quoted 5 lines

Also, Wolfgang, I have one or two minor patches for this board, but I'm not sure if the differences are intentional. One of the patches adds a FLASH_ internal define to flash.h; last time I did this (in ppc-boot) you indicated not to add any more of those.. what is the policy for adding those in u-boot?

I don't remember which sort of modifications you mean, but the policy is the same: include/flash.h is a global header file and should not contain board-specific data.

Best regards,

Wolfgang Denk

Signature · 3 lines

Software Engineering:  Embedded and Realtime Systems,  Embedded Linux
Phone: (+49)-8142-4596-87  Fax: (+49)-8142-4596-88  Email: wd at denx.de
People have one thing in common: they are all different.

Nye Liu

author

2003-05-01 19:33 UTC #2 lore raw

Quoted 7 lines · Wolfgang Denk

Quoted 3 lines · In message <[email protected]> you wrote:
I have u-boot up and running on a MPC860T-FADS eval board, but it is extremely unstable... are there active FADS developers using this board currently?
I guess you see just what many people experienced on the FADS: the board itself is unstable.

I am in the process of getting a 866ADS - are those any better, or is that just a daughter board for the FADS?

also, here are the minor patches for the FADS; im not sure why the original config file calls for max flash banks 4, when only 1 is (apparently) supported:

Index: board/fads/fads.c
===================================================================
RCS file: /cvsroot/u-boot/u-boot/board/fads/fads.c,v retrieving revision 1.1.1.1

fads/fads.c +1 -0

diff -u -b -B -w -p -r1.1.1.1 fads.c
@@ -208,6 +208,7 @@ int checkboard (void)
 	case 0x22 :
 	case 0x23 :
 	case 0x24 :
+	case 0x2a :
 	case 0x3f :
 		puts ("FADS");
 		break;

Index: board/fads/flash.c
===================================================================
RCS file: /cvsroot/u-boot/u-boot/board/fads/flash.c,v retrieving revision 1.1.1.1

fads/flash.c +9 -1

diff -u -b -B -w -p -r1.1.1.1 flash.c
@@ -147,7 +147,7 @@ static void flash_get_offsets (ulong bas
 	int i;
 
 	/* set up sector start address table */
-	if ((info->flash_id & FLASH_TYPEMASK) == FLASH_AM040) {
+	if ((info->flash_id & FLASH_TYPEMASK) == FLASH_AM040 || (info->flash_id & FLASH_TYPEMASK) == FLASH_AM080 ) {
 		/* set sector offsets for uniform sector type	*/
 		for (i = 0; i < info->sector_count; i++) {
 			info->start[i] = base + (i * 0x00040000);

@@ -179,6 +179,8 @@ void flash_print_info  (flash_info_t *in
 	{
 		case FLASH_AM040:	printf ("29F040 or 29LV040 (4 Mbit, uniform sectors)\n");
 			break;
+		case FLASH_AM080:	printf ("29F080 or 29LV080 (8 Mbit, uniform sectors)\n");
+		                	break;
 		case FLASH_AM400B:	printf ("AM29LV400B (4 Mbit, bottom boot sect)\n");
 					break;
 		case FLASH_AM400T:	printf ("AM29LV400T (4 Mbit, top boot sector)\n");

@@ -277,6 +279,12 @@ static ulong flash_get_size (vu_long *ad
 			info->sector_count = 8;
 			info->size = 0x00200000;
 			break;				/* => 2 MB		*/
+
+		case AMD_ID_F080B:
+			info->flash_id += FLASH_AM080;
+			info->sector_count =16;
+			info->size = 0x00400000;
+			break;				/* => 4 MB		*/
 
 		case AMD_ID_LV400T:
 			info->flash_id += FLASH_AM400T;

Index: include/flash.h
===================================================================
RCS file: /cvsroot/u-boot/u-boot/include/flash.h,v retrieving revision 1.4

flash.h +11 -7

diff -u -b -B -w -p -r1.4 flash.h
@@ -129,6 +129,8 @@ extern int flash_real_protect(flash_info
 					/* 4 Mbit, 512K x 8,			*/
 					/* 8 64K x 8 uniform sectors		*/
 #define AMD_ID_F080B	0xD5		/* 29F080  ID  ( 1 M)			*/
+					/* 8 Mbit, 512K x 16,			*/
+					/* 8 64K x 16 uniform sectors		*/
 #define AMD_ID_F016D	0xAD		/* 29F016  ID  ( 2 M x 8)		*/
 #define AMD_ID_F032B	0x41		/* 29F032  ID  ( 4 M x 8)		*/
 #define AMD_ID_LV116DT	0xC7		/* 29LV116DT   ( 2 M x 8, top boot sect) */

@@ -219,13 +221,12 @@ extern int flash_real_protect(flash_info
  * Be careful when adding new type! Odd numbers are "bottom boot sector" types!
  */
 
-#define FLASH_AM040	0x0001		/* AMD Am29F040B, Am29LV040B
-					 * Bright Micro BM29F040
-					 * Fujitsu MBM29F040A
-					 * STM M29W040B
-					 * SGS Thomson M29F040B
-					 * 8 64K x 8 uniform sectors
-					 */
+#define FLASH_AM040	0x0001		/* AMD Am29F040B, Am29LV040B            */
+					/* Bright Micro BM29F040                */
+					/* Fujitsu MBM29F040A                   */
+					/* STM M29W040B                         */
+					/* SGS Thomson M29F040B                 */
+					/* 8 64K x 8 uniform sectors            */
 #define FLASH_AM400T	0x0002		/* AMD AM29LV400			*/
 #define FLASH_AM400B	0x0003
 #define FLASH_AM800T	0x0004		/* AMD AM29LV800			*/

@@ -236,6 +237,9 @@ extern int flash_real_protect(flash_info
 #define FLASH_AM160B	0x0007
 #define FLASH_AM320T	0x0008		/* AMD AM29LV320			*/
 #define FLASH_AM320B	0x0009
+
+#define FLASH_AM080	0x000A		/* AMD Am29F080B                        */
+					/* 16 64K x 8 uniform sectors           */
 
 #define FLASH_AMDL322T	0x0010		/* AMD AM29DL322			*/
 #define FLASH_AMDL322B	0x0011

Index: include/configs/FADS860T.h
===================================================================
RCS file: /cvsroot/u-boot/u-boot/include/configs/FADS860T.h,v retrieving revision 1.1.1.1

configs/FADS860T.h +2 -2

diff -u -b -B -w -p -r1.1.1.1 FADS860T.h
@@ -159,8 +159,8 @@
 /*-----------------------------------------------------------------------
  * FLASH organization
  */
-#define CFG_MAX_FLASH_BANKS	4	/* max number of memory banks		*/
-#define CFG_MAX_FLASH_SECT	8	/* max number of sectors on one chip	*/
+#define CFG_MAX_FLASH_BANKS	1	/* max number of memory banks		*/
+#define CFG_MAX_FLASH_SECT	16      /* max number of sectors on one chip	*/
 
 #define CFG_FLASH_ERASE_TOUT	120000	/* Timeout for Flash Erase (in ms)	*/
 #define CFG_FLASH_WRITE_TOUT	500		/* Timeout for Flash Write (in ms)	*/

Signature · 6 lines

Nye Liu
nliu at mrv.com
(818) 772-6235x248

"Who would be stupid enough to quote a fictitious character?"
	-- Don Quixote