Skip to contentSkip to conversation

Linux 2.5.68 - Fix module_put after return statement

PATCH In review Gabriel Devenyi 2 participants 2 messages Apr 30, 2003

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 Linux 2.5.68 - Fix module_put after return statement

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

This patch applies to 2.5.68. Its listed on kbugs.org. The function module_put is never called because it is after return.

Please CC me with any discussion.
- --
Building the Future,
Gabriel Devenyi
[email protected]

- ---FILE---

- --- linux-2.5.68/drivers/net/wan/c101.c 2003-04-19 22:50:34.000000000 -0400
+++ linux-2.5.68-changed/drivers/net/wan/c101.c 2003-05-01 15:04:23.000000000 -0400
@@ -161,8 +161,8 @@

int result = hdlc_open(hdlc);
if (result) {
- - return result;
module_put(THIS_MODULE);
+ return result;
}

writeb(1, port->win0base + C101_DTR);

- ---ENDFILE---
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.2.1 (GNU/Linux)

iD8DBQE+sXn/7I5UBdiZaF4RAitxAJ9UHBL/iO7nuElsJkIBTqivnGoGDQCfQYbj 6ZrVhEXv1ir82/V/KKHjEQI=
=xOsM
-----END PGP SIGNATURE-----