Skip to contentSkip to conversation

DECNET in latest BK

DISCUSSION Larry McVoy 4 participants 5 messages May 3, 2003 – May 4, 2003 Networking

lore
Share & tools
lore
#0 lore raw

Doesn't build, I didn't config it out by mistake. Dunno if anyone uses decnet.

net/decnet/dn_route.c: In function `dn_route_output_slow':
net/decnet/dn_route.c:1058: `flp' undeclared (first use in this function) net/decnet/dn_route.c:1058: (Each undeclared identifier is reported only once net/decnet/dn_route.c:1058: for each function it appears in.) net/decnet/dn_route.c: In function `dn_route_input_slow':
net/decnet/dn_route.c:1183: structure has no member named `fwmark' make[2]: *** [net/decnet/dn_route.o] Error 1
make[1]: *** [net/decnet] Error 2
make: *** [net] Error 2

Signature · 2 lines
---
Larry McVoy              lm at bitmover.com          http://www.bitmover.com/lm
#1 lore raw
Quoted 5 lines · Larry McVoy

Doesn't build, I didn't config it out by mistake. Dunno if anyone uses decnet.

net/decnet/dn_route.c: In function `dn_route_output_slow':
net/decnet/dn_route.c:1058: `flp' undeclared (first use in this function)

Turn off CONFIG_DECNET_ROUTE_FWMARK, aparently even the maintainer doesn't even enable this option :-)

Signature · 2 lines
David S. Miller <[email protected]>
D
#2 lore raw

David S. Miller <[email protected]> :
[...]

Quoted 2 lines

Turn off CONFIG_DECNET_ROUTE_FWMARK, aparently even the maintainer doesn't even enable this option :-)

Does the attached patch make sense ?

 net/decnet/dn_route.c |    4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)
net/decnet/dn_route.c renamed from net/decnet/dn_route.c~decnet-compile-fix +2 -2
diff -puN net/decnet/dn_route.c~decnet-compile-fix net/decnet/dn_route.c
@@ -1055,7 +1055,7 @@ make_route:
 	rt->fl.oif        = oldflp->oif;
 	rt->fl.iif        = 0;
 #ifdef CONFIG_DECNET_ROUTE_FWMARK
-	rt->fl.fld_fwmark = flp->fld_fwmark;
+	rt->fl.fld_fwmark = oldflp->fld_fwmark;
 #endif
 
 	rt->rt_saddr      = fl.fld_src;
@@ -1180,7 +1180,7 @@ static int dn_route_input_slow(struct sk
 				       .saddr = cb->src,
 				       .scope = RT_SCOPE_UNIVERSE,
 #ifdef CONFIG_DECNET_ROUTE_FWMARK
-				       .fwmark = skb->fwmark
+				       .fwmark = skb->nfmark
 #endif
 				    } },
 			    .iif = skb->dev->ifindex };
#3 lore raw

From: Francois Romieu <[email protected]>
Date: Sat, 3 May 2003 20:39:08 +0200

David S. Miller <[email protected]> :
[...]

Quoted 2 lines

Turn off CONFIG_DECNET_ROUTE_FWMARK, aparently even the maintainer doesn't even enable this option :-)

Does the attached patch make sense ?

Looks good, applied.

Thanks.

#4 lore raw
In reply to Francois Romieu

Hi,

Quoted 8 lines

David S. Miller <[email protected]> :
[...]

Quoted 2 lines

Turn off CONFIG_DECNET_ROUTE_FWMARK, aparently even the maintainer doesn't even enable this option :-)

Does the attached patch make sense ?

Yes, I can confirm thats the right fix. I was a bit busy last week and my fix didn't make it in time, but I'm back now and so the rest of my pending DECnet patches will be submitted shortly. Thanks for the patch,

Steve.