Skip to contentSkip to conversation

Help dummies configure QoS

PATCH In review Dave Maietta 2 participants 2 messages May 4, 2003 – May 5, 2003

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 Help dummies configure QoS

In the packet schedulers section of the config scripts, neither the Ingress Qdisc nor any comment about its existence are displayed in Menuconfig if some dependencies are not met in other places. To help dummies like me know that it's there, please consider the following patch:

net/sched/Config.in renamed from net/sched/Config.in.orig +0 -3
@@ -16,9 +16,6 @@
 tristate '  TBF queue' CONFIG_NET_SCH_TBF
 tristate '  GRED queue' CONFIG_NET_SCH_GRED
 tristate '  Diffserv field marker' CONFIG_NET_SCH_DSMARK
-if [ "$CONFIG_NETFILTER" = "y" ]; then
-   tristate '  Ingress Qdisc' CONFIG_NET_SCH_INGRESS
-fi
 bool '  QoS support' CONFIG_NET_QOS
 if [ "$CONFIG_NET_QOS" = "y" ]; then
    bool '    Rate estimator' CONFIG_NET_ESTIMATOR
@@ -38,4 +35,12 @@
       bool '    Traffic policing (needed for in/egress)'

CONFIG_NET_CLS_POLICE
fi
fi
+if [ "$CONFIG_NETFILTER" = "n" -o "$CONFIG_NET_QOS" = "n" -o \

+   "$CONFIG_NET_CLS" = "n" -o "$CONFIG_NET_CLS_POLICE" = "n" ]; then
+   comment '  Ingress Qdisc:  To enable, please include'
+   comment '    Network Packet Filtering, QoS Support,'
+   comment '    and Packet Classifier API/Traffic Policing'

+else
+ tristate ' Ingress Qdisc' CONFIG_NET_SCH_INGRESS
+fi

Thanks,
Dave Maietta
dave$qix,net

#1 lore raw

In message <1052092397.5844.33.camel@hell> you write:

Quoted 5 lines

In the packet schedulers section of the config scripts, neither the Ingress Qdisc nor any comment about its existence are displayed in Menuconfig if some dependencies are not met in other places. To help dummies like me know that it's there, please consider the following patch:

Better is to put comments in CONFIG_NETFILTER, I think.

Rusty.
--
Anyone who quotes me in their sig is an idiot. -- Rusty Russell.