Skip to contentSkip to conversation

move memsetup.S to CPU directory

U-Boot-Users Robert Schwebel 3 participants 7 messages May 6, 2003

lore
Share & tools
lore
#0 lore raw

Hi,

I would like to propose that we move the memsetup.S code from the board directories for the Innokom and CSB226 (soon also Gealog) plattform to the cpu/xscale directory.

- the code is absolutely generic, can be configured via CFG_ values
- it has been cleaned up
- I see no reason why it should not work on every PXA250 plattform
- it would avoid code quadruplication ;)
- the other board maintainers probably had to test it

Comments? Shall I submit a patch?

Robert

Signature · 5 lines
 Dipl.-Ing. Robert Schwebel | http://www.pengutronix.de
 Pengutronix - Linux Solutions for Science and Industry
   Braunschweiger Str. 79,  31134 Hildesheim, Germany
   Handelsregister:  Amtsgericht Hildesheim, HRA 2686
    Phone: +49-5121-28619-0 |  Fax: +49-5121-28619-4
#1 lore raw
Quoted 4 lines · In message <[email protected]> you wrote:

I would like to propose that we move the memsetup.S code from the board directories for the Innokom and CSB226 (soon also Gealog) plattform to the cpu/xscale directory.

OK.

Quoted 1 line

Comments? Shall I submit a patch?

Yes, please.

Best regards,

Wolfgang Denk

Signature · 5 lines
Software Engineering:  Embedded and Realtime Systems,  Embedded Linux
Phone: (+49)-8142-4596-87  Fax: (+49)-8142-4596-88  Email: wd at denx.de
That said, there may be good reasons for what you did beyond obsequi-
ous sycophantic parody. Perhaps you might be so kind as to elucidate.
         -- Tom Christiansen in <[email protected]>
#2 lore raw
In reply to Robert Schwebel
Quoted 5 lines · Robert Schwebel

Hi,

I would like to propose that we move the memsetup.S code from the board directories for the Innokom and CSB226 (soon also Gealog) plattform to the cpu/xscale directory.

There are other Xscale CPUs. Is the memsetup.S generic enough to support them as well. I don't know the answer to this yet. I will be porting u-boot to IXP420 in the next few weeks and will have a better idea. Maybe someone else already knows.

Kyle.

#3 lore raw
Quoted 4 lines · Kyle Harris

There are other Xscale CPUs. Is the memsetup.S generic enough to support them as well. I don't know the answer to this yet. I will be porting u-boot to IXP420 in the next few weeks and will have a better idea. Maybe someone else already knows.

My impression is that at the moment everything that's labled "XScale" in u-boot is "PXA" in reality, so an audit has to be done anyway.

Do you have information about how the memory controller of the IXP is different from the PXAs?

Robert

Signature · 5 lines
 Dipl.-Ing. Robert Schwebel | http://www.pengutronix.de
 Pengutronix - Linux Solutions for Science and Industry
   Braunschweiger Str. 79,  31134 Hildesheim, Germany
   Handelsregister:  Amtsgericht Hildesheim, HRA 2686
    Phone: +49-5121-28619-0 |  Fax: +49-5121-28619-4
#4 lore raw
Quoted 11 lines · Robert Schwebel
Quoted 4 lines · Kyle Harris

There are other Xscale CPUs. Is the memsetup.S generic enough to support them as well. I don't know the answer to this yet. I will be porting u-boot to IXP420 in the next few weeks and will have a better idea. Maybe someone else already knows.

My impression is that at the moment everything that's labled "XScale" in u-boot is "PXA" in reality, so an audit has to be done anyway.

Do you have information about how the memory controller of the IXP is different from the PXAs?

Actually, the mem controller is completely different. The IXP has separate SDRAM and expansion buses. Most other parts of cpu/xscale will be different as well (e.g., interrupt.c, serial.c). It may be that we need to have ixp and pxa subdirs. We can leave xscale (really pxa) as is, move memsetup there, and create a new ixp.

Kyle.

#5 lore raw
Quoted 6 lines · In message <[email protected]> you wrote:

Actually, the mem controller is completely different. The IXP has separate SDRAM and expansion buses. Most other parts of cpu/xscale will be different as well (e.g., interrupt.c, serial.c). It may be that we need to have ixp and pxa subdirs. We can leave xscale (really pxa) as is, move memsetup there, and create a new ixp.

Then let's rename xscale ==> pxa and add a new ixp directory

Wolfgang Denk

Signature · 6 lines
Software Engineering:  Embedded and Realtime Systems,  Embedded Linux
Phone: (+49)-8142-4596-87  Fax: (+49)-8142-4596-88  Email: wd at denx.de
Abstainer: A weak person who yields to the temptation of denying him-
self a pleasure. A total abstainer is one who  abstains  from  every-
thing  but  abstention, and especially from inactivity in the affairs
of others.                                           - Ambrose Bierce
#6 lore raw
Quoted 9 lines · Wolfgang Denk
Quoted 5 lines · In message <[email protected]> you wrote:

Actually, the mem controller is completely different. The IXP has separate SDRAM and expansion buses. Most other parts of cpu/xscale will be different as well (e.g., interrupt.c, serial.c). It may be that we need to have ixp and pxa subdirs. We can leave xscale (really pxa) as is, move memsetup there, and create a new ixp.

Then let's rename xscale ==> pxa and add a new ixp directory

Yes, renaming xscale to pxa is the correct thing to do. It will be 2-3 weeks before I start the ixp port, though.

Kyle.