Skip to contentSkip to conversation

2.5.69: Missing logo?

DISCUSSION Russell King 4 participants 8 messages May 6, 2003 – May 14, 2003

lore
Share & tools
lore
#0 lore raw

Hi,

I seem to have a penguin missing in action, somewhere between 2.5.68 and 2.5.69. Has anyone else lost a penguin under similar circumstances?

$ grep LOGO linux-sa1100/.config
CONFIG_LOGO=y
# CONFIG_LOGO_LINUX_MONO is not set
CONFIG_LOGO_LINUX_VGA16=y
CONFIG_LOGO_LINUX_CLUT224=y

Other than the missing logo, the fb display looks as it did under 2.5.68.

assabet$ fbset

mode "320x240-60"

        geometry 320 240 320 240 16
        timings 171521 61 9 3 0 5 1
        accel false
        rgba 5/11,6/5,5/0,0/0

endmode

Signature · 2 lines
Russell King ([email protected])                The developer of ARM Linux
             http://www.arm.linux.org.uk/personal/aboutme.html
#1 lore raw
Quoted 4 lines · Russell King

Hi,

I seem to have a penguin missing in action, somewhere between 2.5.68 and 2.5.69. Has anyone else lost a penguin under similar circumstances?

Tux is AWOL for me, too.

bk/linux-2.5.69+kexec2> grep LOGO .config
CONFIG_LOGO=y
CONFIG_LOGO_LINUX_MONO=y
CONFIG_LOGO_LINUX_VGA16=y
CONFIG_LOGO_LINUX_CLUT224=y
bk/linux-2.5.69+kexec2> grep CONFIG_FB .config | grep =y CONFIG_FB=y
CONFIG_FB_VESA=y
CONFIG_FB_I810=y
CONFIG_FB_I810_GTF=y
bk/linux-2.5.69+kexec2> lspci | grep -i VGA
01:00.0 VGA compatible controller: Matrox Graphics, Inc. MGA G400 AGP (rev 85)
bk/linux-2.5.69+kexec2>

Quoted 7 lines
$ grep LOGO linux-sa1100/.config
CONFIG_LOGO=y
# CONFIG_LOGO_LINUX_MONO is not set
CONFIG_LOGO_LINUX_VGA16=y
CONFIG_LOGO_LINUX_CLUT224=y

Other than the missing logo, the fb display looks as it did under 2.5.68.

#2 lore raw

It is the reversal of the changes of cfbimgblit.c. It brought back this bug :-(

Quoted 39 lines · Russell King
Quoted 4 lines

Hi,

I seem to have a penguin missing in action, somewhere between 2.5.68 and 2.5.69. Has anyone else lost a penguin under similar circumstances?

Tux is AWOL for me, too.

bk/linux-2.5.69+kexec2> grep LOGO .config
CONFIG_LOGO=y
CONFIG_LOGO_LINUX_MONO=y
CONFIG_LOGO_LINUX_VGA16=y
CONFIG_LOGO_LINUX_CLUT224=y
bk/linux-2.5.69+kexec2> grep CONFIG_FB .config | grep =y CONFIG_FB=y
CONFIG_FB_VESA=y
CONFIG_FB_I810=y
CONFIG_FB_I810_GTF=y
bk/linux-2.5.69+kexec2> lspci | grep -i VGA
01:00.0 VGA compatible controller: Matrox Graphics, Inc. MGA G400 AGP (rev 85)
bk/linux-2.5.69+kexec2>

Quoted 7 lines
$ grep LOGO linux-sa1100/.config
CONFIG_LOGO=y
# CONFIG_LOGO_LINUX_MONO is not set
CONFIG_LOGO_LINUX_VGA16=y
CONFIG_LOGO_LINUX_CLUT224=y

Other than the missing logo, the fb display looks as it did under 2.5.68.

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

#3 lore raw
In reply to Russell King
Quoted 13 lines · Russell King

Hi,

I seem to have a penguin missing in action, somewhere between 2.5.68 and 2.5.69. Has anyone else lost a penguin under similar circumstances?

$ grep LOGO linux-sa1100/.config
CONFIG_LOGO=y
# CONFIG_LOGO_LINUX_MONO is not set
CONFIG_LOGO_LINUX_VGA16=y
CONFIG_LOGO_LINUX_CLUT224=y

Other than the missing logo, the fb display looks as it did under 2.5.68.

Quoted 18 lines

assabet$ fbset

mode "320x240-60"

        geometry 320 240 320 240 16
        timings 171521 61 9 3 0 5 1
        accel false
        rgba 5/11,6/5,5/0,0/0

endmode

Signature · 8 lines
Russell King ([email protected])                The developer of ARM Linux
             http://www.arm.linux.org.uk/personal/aboutme.html

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Me too. I think it happens with all configs. The empty space is there for the penguin but I guess it gets eaten somewhere on the way.

#4 lore raw
Quoted 3 lines

Me too. I think it happens with all configs. The empty space is there for the penguin but I guess it gets eaten somewhere on the way.

Hm. Someone submitted a patch without testing it fully. This time it wasn't me :-/ Hey we are all human.

#5 lore raw
In reply to Russell King
Quoted 12 lines

I seem to have a penguin missing in action, somewhere between 2.5.68 and 2.5.69. Has anyone else lost a penguin under similar circumstances?

$ grep LOGO linux-sa1100/.config
CONFIG_LOGO=y
# CONFIG_LOGO_LINUX_MONO is not set
CONFIG_LOGO_LINUX_VGA16=y
CONFIG_LOGO_LINUX_CLUT224=y

Other than the missing logo, the fb display looks as it did under 2.5.68.

Quoted 8 lines

assabet$ fbset

mode "320x240-60"

        geometry 320 240 320 240 16
        timings 171521 61 9 3 0 5 1
        accel false
        rgba 5/11,6/5,5/0,0/0

endmode

At the very bottom of cfbimgblt.c change

} else if (image->depth == bpp)

to

} else if (image->depth <= bpp)

and tell me if this works.

P.S
Is it possible we could move the irq code for the acorn driver from
fbcon.c to the acorn driver itself.

#6 lore raw
Quoted 9 lines · James Simmons

At the very bottom of cfbimgblt.c change

} else if (image->depth == bpp)

to

} else if (image->depth <= bpp)

and tell me if this works.

Will report later.

Quoted 3 lines

P.S
Is it possible we could move the irq code for the acorn driver from
fbcon.c to the acorn driver itself.

I don't see why not. Do you have a patch for this?

Signature · 2 lines
Russell King ([email protected])                The developer of ARM Linux
             http://www.arm.linux.org.uk/personal/aboutme.html
#7 lore raw
Quoted 5 lines · Russell King
Quoted 4 lines · James Simmons

At the very bottom of cfbimgblt.c change

} else if (image->depth == bpp)

Quoted 7 lines
Quoted 5 lines

to

} else if (image->depth <= bpp)

and tell me if this works.

Will report later.

This change makes it work. Thanks.

Signature · 2 lines
Russell King ([email protected])                The developer of ARM Linux
             http://www.arm.linux.org.uk/personal/aboutme.html