Skip to contentSkip to conversation

IA64 sn mod_timer fixes for kernel/mca.c

PATCH In review Vinay K Nallamothu 4 participants 4 messages May 7, 2003

lore
Share & tools
lore

Vinay K Nallamothu

author
#0 lore raw

PATCH 1/1 IA64 sn mod_timer fixes for kernel/mca.c

mca.c: Trivial {del,add}_timer to mod_timer conversion.

Thanks
vinay

arch/ia64/sn/kernel/mca.c +2 -6
@@ -246,9 +246,7 @@
 void
 sn_cpei_timer_handler(unsigned long dummy) {
         sn_cpei_handler(-1, NULL, NULL);
-        del_timer(&sn_cpei_timer);
-        sn_cpei_timer.expires = jiffies + CPEI_INTERVAL;
-        add_timer(&sn_cpei_timer);
+        mod_timer(&sn_cpei_timer, jiffies + CPEI_INTERVAL);
 }
 
 void

@@ -267,9 +265,7 @@
         unsigned long *pi_ce_error_inject_reg = 0xc00000092fffff00;
 
         *pi_ce_error_inject_reg = 0x0000000000000100;
-        del_timer(&sn_ce_timer);
-        sn_ce_timer.expires = jiffies + CPEI_INTERVAL;
-        add_timer(&sn_ce_timer);
+        mod_timer(&sn_ce_timer, jiifies + CPEI_INTERVAL);
 }
 
 sn_init_ce_timer() {
#1 lore raw
Quoted 2 lines · Vinay K Nallamothu

mca.c: Trivial {del,add}_timer to mod_timer conversion.

Please just roll all these up into one big patch.

#2 lore raw
Quoted 5 lines · Andrew Morton
Quoted 2 lines · Vinay K Nallamothu

mca.c: Trivial {del,add}_timer to mod_timer conversion.

Please just roll all these up into one big patch.

Please also Cc: me on SN changes (and the big patch when you send it out).

Thanks,
Jesse

#3 lore raw
Quoted 9 lines · Jesse Barnes
Quoted 5 lines · Andrew Morton
Quoted 2 lines · Vinay K Nallamothu

mca.c: Trivial {del,add}_timer to mod_timer conversion.

Please just roll all these up into one big patch.

Please also Cc: me on SN changes (and the big patch when you send it out).

You want to go through them one by one. Some are a bit less obvious and a couple Im not sure about. Most are in my test -ac tree and seem fine