Fix support for SiS5581/5582/5596 IDE
PATCH 1/1 Fix support for SiS5581/5582/5596 IDE
Hi!
The last patch for SiS96* also added support for SiS5581, SiS5582 and SiS5596. However, the PCI IDs for these three chips were incorrect by mistake (cut and paste problem). This patch, on top of the previous one fixes it, and thus adds proper support for these old chips.
Signature · 2 lines
Vojtech Pavlik SuSE Labs, SuSE CR
[email protected], 2003-05-16 15:52:40+02:00, [email protected]
sis5513.c: Fix newly added SiS55** PCI IDs.
drivers/ide/pci/sis5513.c | 9 ++++----- include/linux/pci_ids.h | 3 +++ 2 files changed, 7 insertions(+), 5 deletions(-)
drivers/ide/pci/sis5513.c +4 -5
@@ -105,12 +105,11 @@ { "SiS5600", PCI_DEVICE_ID_SI_5600, ATA_33 }, { "SiS5598", PCI_DEVICE_ID_SI_5598, ATA_33 }, { "SiS5597", PCI_DEVICE_ID_SI_5597, ATA_33 }, - { "SiS5592", PCI_DEVICE_ID_SI_5591, ATA_33 }, - { "SiS5591", PCI_DEVICE_ID_SI_5591, ATA_33 }, - { "SiS5581", PCI_DEVICE_ID_SI_5571, ATA_33 }, - { "SiS5582", PCI_DEVICE_ID_SI_5571, ATA_33 }, + { "SiS5591/2", PCI_DEVICE_ID_SI_5591, ATA_33 }, + { "SiS5582", PCI_DEVICE_ID_SI_5582, ATA_33 }, + { "SiS5581", PCI_DEVICE_ID_SI_5581, ATA_33 }, - { "SiS5596", PCI_DEVICE_ID_SI_5597, ATA_16 }, + { "SiS5596", PCI_DEVICE_ID_SI_5596, ATA_16 }, { "SiS5571", PCI_DEVICE_ID_SI_5571, ATA_16 }, { "SiS551x", PCI_DEVICE_ID_SI_5511, ATA_16 }, };
include/linux/pci_ids.h +3 -0
@@ -521,7 +521,10 @@#define PCI_DEVICE_ID_SI_5513 0x5513#define PCI_DEVICE_ID_SI_5518 0x5518#define PCI_DEVICE_ID_SI_5571 0x5571 +#define PCI_DEVICE_ID_SI_5581 0x5581 +#define PCI_DEVICE_ID_SI_5582 0x5582#define PCI_DEVICE_ID_SI_5591 0x5591 +#define PCI_DEVICE_ID_SI_5596 0x5596#define PCI_DEVICE_ID_SI_5597 0x5597#define PCI_DEVICE_ID_SI_5598 0x5598#define PCI_DEVICE_ID_SI_5600 0x5600
[email protected], 2003-05-16 15:54:27+02:00, [email protected]
sis5513.c: Fix newly added SiS55** PCI IDs.
drivers/ide/pci/sis5513.c | 9 ++++----- include/linux/pci_ids.h | 3 +++ 2 files changed, 7 insertions(+), 5 deletions(-)
drivers/ide/pci/sis5513.c +4 -5
@@ -105,12 +105,11 @@ { "SiS5600", PCI_DEVICE_ID_SI_5600, ATA_33 }, { "SiS5598", PCI_DEVICE_ID_SI_5598, ATA_33 }, { "SiS5597", PCI_DEVICE_ID_SI_5597, ATA_33 }, - { "SiS5592", PCI_DEVICE_ID_SI_5591, ATA_33 }, - { "SiS5591", PCI_DEVICE_ID_SI_5591, ATA_33 }, - { "SiS5581", PCI_DEVICE_ID_SI_5571, ATA_33 }, - { "SiS5582", PCI_DEVICE_ID_SI_5571, ATA_33 }, + { "SiS5591/2", PCI_DEVICE_ID_SI_5591, ATA_33 }, + { "SiS5582", PCI_DEVICE_ID_SI_5582, ATA_33 }, + { "SiS5581", PCI_DEVICE_ID_SI_5581, ATA_33 }, - { "SiS5596", PCI_DEVICE_ID_SI_5597, ATA_16 }, + { "SiS5596", PCI_DEVICE_ID_SI_5596, ATA_16 }, { "SiS5571", PCI_DEVICE_ID_SI_5571, ATA_16 }, { "SiS551x", PCI_DEVICE_ID_SI_5511, ATA_16 }, };
include/linux/pci_ids.h +3 -0
@@ -577,7 +577,10 @@#define PCI_DEVICE_ID_SI_5513 0x5513#define PCI_DEVICE_ID_SI_5518 0x5518#define PCI_DEVICE_ID_SI_5571 0x5571 +#define PCI_DEVICE_ID_SI_5581 0x5581 +#define PCI_DEVICE_ID_SI_5582 0x5582#define PCI_DEVICE_ID_SI_5591 0x5591 +#define PCI_DEVICE_ID_SI_5596 0x5596#define PCI_DEVICE_ID_SI_5597 0x5597#define PCI_DEVICE_ID_SI_5598 0x5598#define PCI_DEVICE_ID_SI_5600 0x5600
Quoted 8 lines · Vojtech Pavlik
Hi!
The last patch for SiS96* also added support for SiS5581, SiS5582 and SiS5596. However, the PCI IDs for these three chips were incorrect by mistake (cut and paste problem). This patch, on top of the previous one fixes it, and thus adds proper support for these old chips.
Thanks for the work.
I've yet to read carefully each change (will do this week-end), but I agree on the principles.
The only thing that disturbed me was the removal of the DEBUG code (as it often helped me find out bugs and understand new chips' behavior) but I think it's best for me to maintain a patch which adds this code in the very rare cases where it can be usefull.
LB.
Quoted 8 lines · Lionel Bouton
Quoted 4 lines
The last patch for SiS96* also added support for SiS5581, SiS5582 and SiS5596. However, the PCI IDs for these three chips were incorrect by mistake (cut and paste problem). This patch, on top of the previous one fixes it, and thus adds proper support for these old chips.
Thanks for the work.
I've yet to read carefully each change (will do this week-end), but I agree on the principles.
Great. And thanks for veryfing the patch.
Quoted 4 lines
The only thing that disturbed me was the removal of the DEBUG code (as it often helped me find out bugs and understand new chips' behavior) but I think it's best for me to maintain a patch which adds this code in the very rare cases where it can be usefull.
I sort of expected that when I was removing it. ;) Debugging code comes very handy when one runs into problems, but clutters up the source in all other cases. So the final decision to keep it or have a separate debug patch is of course in your hands.
Signature · 2 lines
Vojtech Pavlik SuSE Labs, SuSE CR