Skip to contentSkip to conversation

Fix for dell inspiron 8100 maestro3

PATCH Javier Conti 2 participants 6 messages May 16, 2003 – May 20, 2003 Kbuild

lore
Share & tools
lore
#0 lore raw

Hi, after a long and painful investigation on the maestro3 vs. irda problem on the dell inspiron 8100 notebook, I found the FIXME tag in the maestro3 sources and, inspired by the 8000 fix right above, I applied the same fix for 8100.

I'm no develper, but I think this should't break anything, and for me fixed the problem on my 8100. Maybe someone will find this useful.

Patch attached, bye, Javier

Signature · 2 lines
Javier Conti - Labcc
http://www.labcc.ch/
usr/src/modules/alsa-driver/alsa-kernel/pci/maestro3.c renamed from maestro3.c +7 -0
@@ -949,6 +949,13 @@
 	},
 	/* FIXME: Inspiron 8100 id should probably be here, too
 	 * (8200 irrelevant: has intel8x0 with CS4205) */
+	{
+		.name = "Dell Inspiron 8100",
+		.vendor = 0x1028,
+		.device = 0x00a4,
+		.amp_gpio = -1,
+		.irda_workaround = 1,
+	},
 	/* NEC LM800J/7 */
 	{
 		.name = "NEC LM800J/7",
#1 lore raw

Hi,

At Fri, 16 May 2003 16:32:46 +0200,

Quoted 11 lines · Javier Conti

[1 <text/plain; iso-8859-15 (7bit)>]
Hi, after a long and painful investigation on the maestro3 vs. irda problem on the dell inspiron 8100 notebook, I found the FIXME tag in the maestro3 sources and, inspired by the 8000 fix right above, I applied the same fix for 8100.

I'm no develper, but I think this should't break anything, and for me fixed the problem on my 8100. Maybe someone will find this useful.

Patch attached, bye, Javier

are you sure that the patch is correct?
your patch adds the same vendor an device id with the existing inspiron 8000 (1028:00a4).

Takashi

Quoted 10 lines
Signature · 3 lines
Javier Conti - Labcc
http://www.labcc.ch/
[2 maestro3.patch <text/x-diff; iso-8859-15 (7bit)>]
usr/src/modules/alsa-driver/alsa-kernel/pci/maestro3.c renamed from maestro3.c +0 -0
@@ -949,6 +949,13 @@
 	},
 	/* FIXME: Inspiron 8100 id should probably be here, too
 	 * (8200 irrelevant: has intel8x0 with CS4205) */

usr/src/modules/alsa-driver/alsa-kernel/pci/maestro3.c line 961

Quoted 10 lines
usr/src/modules/alsa-driver/alsa-kernel/pci/maestro3.c renamed from maestro3.c +7 -0
+	{
+		.name = "Dell Inspiron 8100",
+		.vendor = 0x1028,
+		.device = 0x00a4,
+		.amp_gpio = -1,
+		.irda_workaround = 1,
+	},
 	/* NEC LM800J/7 */
 	{
 		.name = "NEC LM800J/7",

-------------------------------------------------------
Enterprise Linux Forum Conference & Expo, June 4-6, 2003, Santa Clara The only event dedicated to issues related to Linux enterprise solutions www.enterpriselinuxforum.com

#2 lore raw
Quoted 3 lines · Takashi Iwai

are you sure that the patch is correct?
your patch adds the same vendor an device id with the existing inspiron 8000 (1028:00a4).

I'm not sure. As stated in my previous posting, I'm not a developer. The only thing I'm sure of, is that without that patch, I can't use irda and the soundcard together, with this patch, I can.

I suppose the FIXME tag is there because nobody in the alsa team has a dell inspiron 8100 to test the driver on. If this is the case, and if my patch is not correct (which is more than possible) I'd be happy to cooperate to test other solutions (maybe someone could tell me how to spot the right device id?).

Having to reboot with a soundless kernel just to update my calendar and addressbook is very frustrating...

Thanks, Javier

Signature · 11 lines
Javier Conti - Labcc
Tel: +41(0)91 690 0703
Fax: +41(0)91 690 0702



-------------------------------------------------------
This SF.net email is sponsored by: If flattening out C++ or Java
code to make your application fit in a relational database is painful, 
don't do it! Check out ObjectStore. Now part of Progress Software.
http://www.objectstore.net/sourceforge
#3 lore raw
In reply to Takashi Iwai
Quoted 3 lines · Takashi Iwai

are you sure that the patch is correct?
your patch adds the same vendor an device id with the existing inspiron 8000 (1028:00a4).

Ok, I found the correct values, repatched and now the modules tells me the hack is enabled. With the other values, that didn't happen. Seen that, I tried to recompile a vanilla alsa-driver version, to see if my previous patch was doing some difference. The weird thing is that it still didn't work! I'm puzzled, since the wrong patch fixed the problem anyway...

I'm sorry for the "noise" but hope to be helpful by sending this patch which includes the correct values.

Bye, Javier

Signature · 3 lines
Javier Conti - Labcc
Tel: +41(0)91 690 0703
Fax: +41(0)91 690 0702
usr/src/modules/alsa-driver/alsa-kernel/pci/maestro3.c renamed from maestro3.c +8 -2
@@ -947,8 +947,14 @@
 		.amp_gpio = -1,
 		.irda_workaround = 1,
 	},
-	/* FIXME: Inspiron 8100 id should probably be here, too
-	 * (8200 irrelevant: has intel8x0 with CS4205) */
+	/* Dell Inspiron 8100 */
+	{
+		.name = "Dell Inspiron 8100",
+		.vendor = 0x1028,
+		.device = 0x00e6,
+		.amp_gpio = -1,
+		.irda_workaround = 1,
+	},
 	/* NEC LM800J/7 */
 	{
 		.name = "NEC LM800J/7",
#4 lore raw

At Sat, 17 May 2003 04:45:12 +0200,

Quoted 7 lines · Javier Conti

[1 <text/plain; iso-8859-1 (7bit)>]

Quoted 3 lines · Takashi Iwai

are you sure that the patch is correct?
your patch adds the same vendor an device id with the existing inspiron 8000 (1028:00a4).

Quoted 5 lines

Ok, I found the correct values, repatched and now the modules tells me the hack is enabled. With the other values, that didn't happen. Seen that, I tried to recompile a vanilla alsa-driver version, to see if my previous patch was doing some difference. The weird thing is that it still didn't work! I'm puzzled, since the wrong patch fixed the problem anyway...

ok, i'll add your patch.

the irda_workaround field specifies that the workaround for touching the bit 0x10 of GPIO direction. depending on the device, the GPIO direction for the same purpose might be different.

about debugging this problem:

please check the register GPIO_DIRECTION by adding printk() around line 1922 of maestro3.c, such as

	for (i = 0; i < 5; i++) {
		dir = inw(io + GPIO_DIRECTION);
==>		printk("GPIO_DIRECTION = 0x%x\n", dir);
		if (! chip->quirk || ! chip->quirk->irda_workaround)

and compare the values between the working and non-working states.

Takashi

-------------------------------------------------------
This SF.net email is sponsored by: If flattening out C++ or Java code to make your application fit in a relational database is painful, don't do it! Check out ObjectStore. Now part of Progress Software.
http://www.objectstore.net/sourceforge

#5 lore raw
In reply to Javier Conti

At Sat, 17 May 2003 04:45:12 +0200,

Quoted 7 lines · Javier Conti

[1 <text/plain; iso-8859-1 (7bit)>]

Quoted 3 lines · Takashi Iwai

are you sure that the patch is correct?
your patch adds the same vendor an device id with the existing inspiron 8000 (1028:00a4).

Quoted 5 lines

Ok, I found the correct values, repatched and now the modules tells me the hack is enabled. With the other values, that didn't happen. Seen that, I tried to recompile a vanilla alsa-driver version, to see if my previous patch was doing some difference. The weird thing is that it still didn't work! I'm puzzled, since the wrong patch fixed the problem anyway...

hmm, weird.
anyway i applied the patch now. thanks.

Takashi

-------------------------------------------------------
This SF.net email is sponsored by: ObjectStore.
If flattening out C++ or Java code to make your application fit in a relational database is painful, don't do it! Check out ObjectStore. Now part of Progress Software. http://www.objectstore.net/sourceforge