Skip to contentSkip to conversation

ioctl32 cleanups: kill code duplication

DISCUSSION Applied Milton Miller 2 participants 2 messages May 19, 2003

lore
Share & tools
lore
#0 lore raw
Quoted 2 lines

+#include "../../../fs/compat_ioctl.c"

I think the kbuild people would rather you do this in the Makefile with something like

CFLAGS_ioctl32.o += -Ifs/

and then

#include "compat_ioctl.c"

instead. I know the seperate source/obj dir people will.

milton

Applied
#1 lore raw

Hi!

Quoted 5 lines
Quoted 1 line

+#include "../../../fs/compat_ioctl.c"

I think the kbuild people would rather you do this in the Makefile with something like

Quoted 7 lines

CFLAGS_ioctl32.o += -Ifs/

and then

#include "compat_ioctl.c"

instead. I know the seperate source/obj dir people will.

Applied, thanx. [Milton, you have some severe misconfiguration in your mail system... watch your from address.]

Patch now looks like [attached]. If there are no protests I'll send it to Linus.
Pavel

Signature · 2 lines
When do you have a heart between your knees?
[Johanka's followup: and *two* hearts?]