Skip to contentSkip to conversation

2.5.70: CODA breaks boot

DISCUSSION Pavel Machek 5 participants 5 messages May 28, 2003 Coda file system

lore
Share & tools
lore

Pavel Machek

author
#0 lore raw

Hi!

...it oopses in kmem_cache_create, called from release_console_sem and coda_init_inodecache.
Pavel

Signature · 2 lines
When do you have a heart between your knees?
[Johanka's followup: and *two* hearts?]
#1 lore raw
Quoted 3 lines · Pavel Machek

...it oopses in kmem_cache_create, called from release_console_sem and
coda_init_inodecache.

You'll be needing this one.

 fs/coda/inode.c |    6 +++---
 1 files changed, 3 insertions(+), 3 deletions(-)
fs/coda/inode.c renamed from fs/coda/inode.c~coda-typo-fix +3 -3
diff -puN fs/coda/inode.c~coda-typo-fix fs/coda/inode.c
@@ -69,9 +69,9 @@ static void init_once(void * foo, kmem_c
 int coda_init_inodecache(void)
 {
 	coda_inode_cachep = kmem_cache_create("coda_inode_cache",
-					     sizeof(struct coda_inode_info),
-					     0, SLAB_HWCACHE_ALIGN||SLAB_RECLAIM_ACCOUNT,
-					     init_once, NULL);
+				sizeof(struct coda_inode_info),
+				0, SLAB_HWCACHE_ALIGN|SLAB_RECLAIM_ACCOUNT,
+				init_once, NULL);
 	if (coda_inode_cachep == NULL)
 		return -ENOMEM;
 	return 0;

_

#2 lore raw

Hi Andrew.

Quoted 14 lines
Quoted 2 lines

...it oopses in kmem_cache_create, called from release_console_sem and
coda_init_inodecache.

You'll be needing this one.

 fs/coda/inode.c |    6 +++---
 1 files changed, 3 insertions(+), 3 deletions(-)

diff -puN fs/coda/inode.c~coda-typo-fix fs/coda/inode.c

fs/coda/inode.c renamed from fs/coda/inode.c~coda-typo-fix +0 -0
@@ -69,9 +69,9 @@ static void init_once(void * foo, kmem_c
 int coda_init_inodecache(void)
 {

fs/coda/inode.c static void init_once(void * foo, kmem_c · line 77

Quoted 10 lines
fs/coda/inode.c renamed from fs/coda/inode.c~coda-typo-fix +3 -3
 	coda_inode_cachep = kmem_cache_create("coda_inode_cache",
-					     sizeof(struct coda_inode_info),
+				sizeof(struct coda_inode_info),
-					     0, SLAB_HWCACHE_ALIGN||SLAB_RECLAIM_ACCOUNT,
+				0, SLAB_HWCACHE_ALIGN|SLAB_RECLAIM_ACCOUNT,
-					     init_once, NULL);
+				init_once, NULL);
 	if (coda_inode_cachep == NULL)
 		return -ENOMEM;
 	return 0;

That patch has me puzzled. Other than changing the white space, what actual change to the code does it make? I can't see any.

Best wishes from Riley.
---
* Nothing as pretty as a smile, nothing as ugly as a frown.

---
Outgoing mail is certified Virus Free.
Checked by AVG anti-virus system (http://www.grisoft.com).
Version: 6.0.484 / Virus Database: 282 - Release Date: 27-May-2003

#3 lore raw
|  >  fs/coda/inode.c |    6 +++---
|  >  1 files changed, 3 insertions(+), 3 deletions(-)
|  > 
|  > diff -puN fs/coda/inode.c~coda-typo-fix fs/coda/inode.c
|  > --- 25/fs/coda/inode.c~coda-typo-fix	2003-05-27 22:27:11.000000000 -0700
|  > +++ 25-akpm/fs/coda/inode.c	2003-05-27 22:27:27.000000000 -0700
|  > @@ -69,9 +69,9 @@ static void init_once(void * foo, kmem_c
|  >  int coda_init_inodecache(void)
|  >  {
|  >  	coda_inode_cachep = kmem_cache_create("coda_inode_cache",
|  > -					     sizeof(struct coda_inode_info),
|  > +				sizeof(struct coda_inode_info),
|  > -					     0, SLAB_HWCACHE_ALIGN||SLAB_RECLAIM_ACCOUNT,
                  ^^ change to |
|  > +				0, SLAB_HWCACHE_ALIGN|SLAB_RECLAIM_ACCOUNT,
|  > -					     init_once, NULL);
|  > +				init_once, NULL);
|  >  	if (coda_inode_cachep == NULL)
|  >  		return -ENOMEM;
|  >  	return 0;
| 
| That patch has me puzzled. Other than changing the white space, what actual
| change to the code does it make? I can't see any.

See above.
Yes, I understand. :)

--
~Randy

#4 lore raw
In reply to Riley Williams

Em Wed, May 28, 2003 at 10:00:06PM +0100, Riley Williams escreveu:

Quoted 10 lines

Hi Andrew.

Quoted 8 lines
Quoted 2 lines

...it oopses in kmem_cache_create, called from release_console_sem and
coda_init_inodecache.

You'll be needing this one.

 fs/coda/inode.c |    6 +++---
 1 files changed, 3 insertions(+), 3 deletions(-)
Quoted 10 lines

fs/coda/inode.c static void init_once(void * foo, kmem_c · line 73

Quoted 10 lines

diff -puN fs/coda/inode.c~coda-typo-fix fs/coda/inode.c

fs/coda/inode.c renamed from fs/coda/inode.c~coda-typo-fix +1 -2
@@ -69,9 +69,9 @@ static void init_once(void * foo, kmem_c
 int coda_init_inodecache(void)
 {
 	coda_inode_cachep = kmem_cache_create("coda_inode_cache",
-					     sizeof(struct coda_inode_info),
+				sizeof(struct coda_inode_info),
-					     0, SLAB_HWCACHE_ALIGN||SLAB_RECLAIM_ACCOUNT,

                                                                  ^^
                                                             logical OR
Quoted 1 line

fs/coda/inode.c static void init_once(void * foo, kmem_c · line 73

Quoted 1 line
fs/coda/inode.c renamed from fs/coda/inode.c~coda-typo-fix +1 -0
+				0, SLAB_HWCACHE_ALIGN|SLAB_RECLAIM_ACCOUNT,

                                                     ^
                                                 bit or
Quoted 8 lines

fs/coda/inode.c static void init_once(void * foo, kmem_c · line 77

Quoted 5 lines
fs/coda/inode.c renamed from fs/coda/inode.c~coda-typo-fix +1 -1
-					     init_once, NULL);
+				init_once, NULL);
 	if (coda_inode_cachep == NULL)
 		return -ENOMEM;
 	return 0;

That patch has me puzzled. Other than changing the white space, what actual change to the code does it make? I can't see any.

gotcha? 8)

- Arnaldo