Skip to contentSkip to conversation

don't allow utime()/utimes() on immutable/append-only files

PATCH New Ethan Benson 1 participant 1 message Jun 8, 2003 VFS

lore
Share & tools
lore

Ethan Benson

author
#0 lore raw

PATCH 1/1 don't allow utime()/utimes() on immutable/append-only files

Hi,

I recently noticed that utime() and utimes() is allowed on immutable or append-only files. I believe this should not be permitted.

Attached is a patch which returns -EPERM on attempts to set timestamps explicitly (utime[s]() with a timebuf arg), and which returns EACCES when these are called with a NULL time arg for immutable files.

utime/utimes with a NULL time arg is allowed on an append-only file. Since timestamps are updated when append-only files are written to, it seems acceptable to allow the timestamp to be updated to the current time.

I am not subscribed to linux-kernel, so please CC any replies, thanks.

fs/open.c +13 -0
@@ -272,6 +272,9 @@
 	/* Don't worry, the checks are done in inode_change_ok() */
 	newattrs.ia_valid = ATTR_CTIME | ATTR_MTIME | ATTR_ATIME;
 	if (times) {
+		error = -EPERM;
+		if (IS_APPEND(inode) || IS_IMMUTABLE(inode))
+			goto dput_and_out;
 		error = get_user(newattrs.ia_atime, &times->actime);
 		if (!error) 
 			error = get_user(newattrs.ia_mtime, &times->modtime);

@@ -280,6 +283,9 @@
 
 		newattrs.ia_valid |= ATTR_ATIME_SET | ATTR_MTIME_SET;
 	} else {
+		error = -EACCES;
+		if (IS_IMMUTABLE(inode))
+			goto dput_and_out;
 		if (current->fsuid != inode->i_uid &&
 		    (error = permission(inode,MAY_WRITE)) != 0)
 			goto dput_and_out;

@@ -318,6 +324,9 @@
 	newattrs.ia_valid = ATTR_CTIME | ATTR_MTIME | ATTR_ATIME;
 	if (utimes) {
 		struct timeval times[2];
+		error = -EPERM;
+		if (IS_APPEND(inode) || IS_IMMUTABLE(inode))
+			goto dput_and_out;
 		error = -EFAULT;
 		if (copy_from_user(&times, utimes, sizeof(times)))
 			goto dput_and_out;

@@ -325,6 +334,10 @@
 		newattrs.ia_mtime = times[1].tv_sec;
 		newattrs.ia_valid |= ATTR_ATIME_SET | ATTR_MTIME_SET;
 	} else {
+		error = -EACCES;
+		if (IS_IMMUTABLE(inode))
+			goto dput_and_out;
+
 		if (current->fsuid != inode->i_uid &&
 		    (error = permission(inode,MAY_WRITE)) != 0)
 			goto dput_and_out;
Signature · 2 lines
Ethan Benson
http://www.alaska.net/~erbenson/