Linux 2.5.72: ixgb_ethtool: strange SUPPORTED_10000baseT_Full

<-- snip -->

...
CC drivers/net/ixgb/ixgb_ethtool.o
drivers/net/ixgb/ixgb_ethtool.c:53:1: warning: "SUPPORTED_10000baseT_Full" redefined In file included from drivers/net/ixgb/ixgb.h:60,
from drivers/net/ixgb/ixgb_ethtool.c:30:
include/linux/ethtool.h:302:1: warning: this is the location of the previous definition
...

<-- snip -->

ixgb_ethtool.c says:
#define SUPPORTED_10000baseT_Full (1 << 11)

ethtool.h says:
#define SUPPORTED_BNC (1 << 11)
#define SUPPORTED_10000baseT_Full (1 << 12)

The correct solution seems to be to remove the #define from ixgb_ethtool.c ?

cu
Adrian

       "Is there not promise of rain?" Ling Tan asked suddenly out
        of the darkness. There had been need of rain for many days.
       "Only a promise," Lao Er said.
                                       Pearl S. Buck - Dragon Seed

correct.

wanna send a patch? ;-)

Jeff

Yup. :-)

Compilation tested with 2.5.72.

@@ -50,7 +50,6 @@
 	return (IXGB_EEPROM_SIZE << 1);
 }
 
-#define SUPPORTED_10000baseT_Full (1 << 11)
 #define SPEED_10000 10000
 
 static void

cu
Adrian

       "Is there not promise of rain?" Ling Tan asked suddenly out
        of the darkness. There had been need of rain for many days.
       "Only a promise," Lao Er said.
                                       Pearl S. Buck - Dragon Seed