remove two unused variables from mxser.c
Subsystems (2)
PATCH 1/1 remove two unused variables from mxser.c
The patch below removes two unused variables from drivers/char/mxser.c .
I've tested the compilation with 2.5.72 and 2.5.72-mm2.
Please apply
Adrian
drivers/char/mxser.c renamed from drivers/char/mxser.c.old +0 -1
@@ -498,7 +498,6 @@ {int i, m, retval, b;int n, index; -int ret1, ret2;struct mxser_hwconf hwconf; mxvar_sdriver =alloc_tty_driver (MXSER_PORTS +1 );
In message <[email protected]> you write:
Quoted 1 line
The patch below removes two unused variables from
drivers/char/mxser.c.
While you're there, would you fix the init returning "-1" for no good reason at the bottom, too? (I don't think they really meant EPERM).
Thanks,
Rusty.
--
Anyone who quotes me in their sig is an idiot. -- Rusty Russell.
Quoted 5 lines · Rusty Russell
In message <[email protected]> you write:
Quoted 1 line
The patch below removes two unused variables from
drivers/char/mxser.c.While you're there, would you fix the init returning "-1" for no good reason at the bottom, too? (I don't think they really meant EPERM).
There is at least one other driver under drivers/char/ doing the same...
Which return code do you suggest?
Quoted 2 lines
Thanks,
Rusty.
cu
Adrian
Signature · 4 lines
"Is there not promise of rain?" Ling Tan asked suddenly out
of the darkness. There had been need of rain for many days.
"Only a promise," Lao Er said.
Pearl S. Buck - Dragon SeedIn message <[email protected]> you write:
Quoted 11 lines · Rusty Russell
Quoted 5 lines
In message <[email protected]> you write:
Quoted 1 line
The patch below removes two unused variables from
drivers/char/mxser.c.While you're there, would you fix the init returning "-1" for no good reason at the bottom, too? (I don't think they really meant EPERM).
There is at least one other driver under
drivers/char/doing the same...Which return code do you suggest?
Looking at the code, there are other problems.
The last thing to fail (which triggers this -1 return) is tty_register_driver(mxvar_sdriver): so keep that return code and use it.
But they do put_tty_driver(mxvar_sdriver) in the failure path, which seems wrong, too...
Good luck!
Rusty.
--
Anyone who quotes me in their sig is an idiot. -- Rusty Russell.