remove an unused variable from xirc2ps_cs.c
PATCH 1/1 remove an unused variable from xirc2ps_cs.c
The platch below removes an unused variable fromdrivers/net/pcmcia/xirc2ps_cs.c .
Please apply
Adrian
drivers/net/pcmcia/xirc2ps_cs.c renamed from drivers/net/pcmcia/xirc2ps_cs.c.old +1 -3
@@ -225,9 +225,7 @@#else #define DEBUG(n, args...)#endif -static char *version = -"xirc2ps_cs.c 1.31 1998/12/09 19:32:55 (dd9jn+kvh)" ; -/* !--- CVS revision */ +#define KDBG_XIRC KERN_DEBUG "xirc2ps_cs: "#define KERR_XIRC KERN_ERR "xirc2ps_cs: "#define KWRN_XIRC KERN_WARNING "xirc2ps_cs: "
In message <[email protected]> you write:
Quoted 2 lines
The platch below removes an unused variable from
drivers/net/pcmcia/xirc2ps_cs.c.
Please add __attribute_used__ instead, since the author presumably wants the string left in.
Cheers,
Rusty.
drivers/net/pcmcia/xirc2ps_cs.c line 231
Quoted 13 lines
drivers/net/pcmcia/xirc2ps_cs.c renamed from drivers/net/pcmcia/xirc2ps_cs.c.old +1
-3@@ -225,9 +225,7 @@#else #define DEBUG(n, args...)#endif -static char *version = -"xirc2ps_cs.c 1.31 1998/12/09 19:32:55 (dd9jn+kvh)" ; -/* !--- CVS revision */ +#define KDBG_XIRC KERN_DEBUG "xirc2ps_cs: "#define KERR_XIRC KERN_ERR "xirc2ps_cs: "#define KWRN_XIRC KERN_WARNING "xirc2ps_cs: "
--
Anyone who quotes me in their sig is an idiot. -- Rusty Russell.
Quoted 6 lines · Rusty Russell
In message <[email protected]> you write:
Quoted 2 lines
The platch below removes an unused variable from
drivers/net/pcmcia/xirc2ps_cs.c.Please add
__attribute_used__instead, since the author presumably wants the string left in.
I'd agree if the author was still active. All the changes to this driver in the near past weren't done by Werner Koch (dd9jn). Since the version isn't updated when the driver is updated and this string is no longer used in 2.5 (it was displayed in 2.4) I consider it quite obsolete.
Quoted 18 lines
Cheers,
Rusty.drivers/net/pcmcia/xirc2ps_cs.c line 231
Quoted 13 lines
drivers/net/pcmcia/xirc2ps_cs.c renamed from drivers/net/pcmcia/xirc2ps_cs.c.old +1
-3@@ -225,9 +225,7 @@#else #define DEBUG(n, args...)#endif -static char *version = -"xirc2ps_cs.c 1.31 1998/12/09 19:32:55 (dd9jn+kvh)" ; -/* !--- CVS revision */ +#define KDBG_XIRC KERN_DEBUG "xirc2ps_cs: "#define KERR_XIRC KERN_ERR "xirc2ps_cs: "#define KWRN_XIRC KERN_WARNING "xirc2ps_cs: "--
Anyone who quotes me in their sig is an idiot. -- Rusty Russell.
cu
Adrian
Signature · 4 lines
"Is there not promise of rain?" Ling Tan asked suddenly out
of the darkness. There had been need of rain for many days.
"Only a promise," Lao Er said.
Pearl S. Buck - Dragon Seed