Skip to contentSkip to conversation

3c359.c: remove comparison that is always true

PATCH New Adrian Bunk 1 participant 1 message Jun 20, 2003 Network drivers

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 3c359.c: remove comparison that is always true

The patch below removes a comparison that is always true.

i is defined as u16, IOW it obviously can't be > 0xffff.

I don't know whether this patch is correct. The correct fix might be different but the current code is definitely broken.

cu
Adrian

drivers/net/tokenring/3c359.c renamed from drivers/net/tokenring/3c359.c.old +1 -1
@@ -464,7 +464,7 @@
 		
 		printk(KERN_INFO "3C359: Uploading Microcode: "); 
 		
-		for (i = start,j=0; (j < mc_size && i <= 0xffff) ; i++,j++) { 
+		for (i = start,j=0; j < mc_size; i++,j++) { 
 			writel(MEM_BYTE_WRITE | 0XD0000 | i, xl_mmio + MMIO_MAC_ACCESS_CMD) ; 
 			writeb(microcode[j],xl_mmio + MMIO_MACDATA) ; 
 			if (j % 1024 == 0)