yam.c: return IRQ_NONE in error case
PATCH 1/1 yam.c: return IRQ_NONE in error case
Please check whether the following patch to return IRQ_NONE in case of errors is correct:
drivers/net/hamradio/yam.c renamed from drivers/net/hamradio/yam.c.old +1 -1
@@ -742,7 +742,7 @@if (--counter <=0 ) {printk (KERN_ERR "%s: too many irq iir=%d\n" , dev->name, iir); -return ; +return IRQ_NONE ; }if (msr &TX_RDY ) { ++yp->nb_mdint;
TIA
Adrian
Signature · 4 lines
"Is there not promise of rain?" Ling Tan asked suddenly out
of the darkness. There had been need of rain for many days.
"Only a promise," Lao Er said.
Pearl S. Buck - Dragon SeedIn message <[email protected]> you write:
drivers/net/hamradio/yam.c line 746
Quoted 12 lines
Please check whether the following patch to return
IRQ_NONEin case of errors is correct:drivers/net/hamradio/yam.c renamed from drivers/net/hamradio/yam.c.old +1
-1@@ -742,7 +742,7 @@if (--counter <=0 ) {printk (KERN_ERR "%s: too many irq iir=%d\n" , dev->name, iir); -return ; +return IRQ_NONE ; }
IRQ_HANDLED, I think: it did handle them, but decided it was livelocked and exited.
Cheers,
Rusty.
--
Anyone who quotes me in their sig is an idiot. -- Rusty Russell.
Quoted 8 lines · Rusty Russell
In message <[email protected]> you write:
Quoted 7 lines
Please check whether the following patch to return
IRQ_NONEin case of errors is correct:drivers/net/hamradio/yam.c renamed from drivers/net/hamradio/yam.c.old +0
-0@@ -742,7 +742,7 @@
Quoted 8 lines
drivers/net/hamradio/yam.c line 746
Quoted 5 lines
drivers/net/hamradio/yam.c renamed from drivers/net/hamradio/yam.c.old +1
-1if (--counter <=0 ) {printk (KERN_ERR "%s: too many irq iir=%d\n" , dev->name, iir); -return ; +return IRQ_NONE ; }
IRQ_HANDLED, I think: it did handle them, but decided it was livelocked and exited.
akpm already sent a better fix to Linus.
Quoted 2 lines
Cheers,
Rusty.
Thanks
Adrian
Signature · 4 lines
"Is there not promise of rain?" Ling Tan asked suddenly out
of the darkness. There had been need of rain for many days.
"Only a promise," Lao Er said.
Pearl S. Buck - Dragon Seed