Warning message during linux kernel 2.4.21 compilation (ymfpci.c)
Quoted 6 lines
Date: Sun, 22 Jun 2003 05:10:13 +0900
From: Ishikawa <[email protected]>It certainly looks that something is wrong with the code. (Maybe some masking of the eid and the immediate value is missing?)
Quoted 8 lines
u16 eid;
...
2462 eid = ymfpci_codec_read(codec, AC97_EXTENDED_ID);
-->2463 if (eid==0xFFFFFF) {
printk(KERN_WARNING "ymfpci: no codec attached ?\n");
goto out_kfree;
}This is indeed a bug, and ymfpci inherits it from cs46xx.c. I wonder why cs46xx.c does not trigger a warning.
Since the check never worked and nobody ever complained, I think the best fix is to remove the "if" statement with its block. If we repair the comparison to "eid == 0xFFFF", then we run a risk of breaking previously working systems.
-- Pete