Skip to contentSkip to conversation

[[email protected]: stac9708 additions]

[email protected]: stac9708 additions Ryan Underwood 2 participants 3 messages Jun 18, 2003 – Jun 22, 2003

lore
Share & tools
lore
#0 lore raw

Hi,

Did anyone have a chance to look at this?

----- Forwarded message from Ryan Underwood <[email protected]> -----

From: Ryan Underwood <[email protected]>
Date: Tue, 17 Jun 2003 05:49:04 -0500
Subject: [Alsa-devel] stac9708 additions
To: [email protected]
User-Agent: Mutt/1.5.4i

Hi,

Attached patch adds some stac9708 features that I found missing. The name of the 4-speaker stereo probably does not conform to policy, but I couldn't figure out what to name it. :) Any suggestions?

These options were found while working on the upcoming au88x0 driver currently on savannah.

Signature · 44 lines
Ryan Underwood, <nemesis at icequake.net>, icq=10317253

diff -ur /home/nemesis/src/linux/aureal/alsa/alsa-driver-0.9.4/sound/pci/ac97/ac97_codec.c sound/pci/ac97/ac97_codec.c
--- /home/nemesis/src/linux/aureal/alsa/alsa-driver-0.9.4/sound/pci/ac97/ac97_codec.c	2003-05-31 09:15:01.000000000 -0500
+++ sound/pci/ac97/ac97_codec.c	2003-06-15 06:42:33.000000000 -0500
@@ -743,6 +743,12 @@
 AC97_DOUBLE("Sigmatel Surround Playback Volume", AC97_HEADPHONE, 8, 0, 31, 1)
 };
 
+static const snd_kcontrol_new_t snd_ac97_sigmatel_4speaker =
+AC97_SINGLE("Sigmatel 4-Speaker Stereo Playback Switch", AC97_SIGMATEL_DAC2INVERT, 2, 1, 0);
+
+static const snd_kcontrol_new_t snd_ac97_sigmatel_phaseinvert =
+AC97_SINGLE("Sigmatel Surround Phase Inversion Playback Switch", AC97_SIGMATEL_DAC2INVERT, 3, 1, 0);
+
 static const snd_kcontrol_new_t snd_ac97_sigmatel_controls[] = {
 AC97_SINGLE("Sigmatel DAC 6dB Attenuate", AC97_SIGMATEL_ANALOG, 1, 1, 0),
 AC97_SINGLE("Sigmatel ADC 6dB Attenuate", AC97_SIGMATEL_ANALOG, 0, 1, 0)
@@ -1872,6 +1878,12 @@
 		if (snd_ac97_try_bit(ac97, AC97_SIGMATEL_ANALOG, 0))
 			if ((err = snd_ctl_add(card, snd_ac97_cnew(&snd_ac97_sigmatel_controls[1], ac97))) < 0)
 				return err;
+		if (snd_ac97_try_bit(ac97, AC97_SIGMATEL_DAC2INVERT, 2))
+			if ((err = snd_ctl_add(card, snd_ac97_cnew(&snd_ac97_sigmatel_4speaker, ac97))) < 0)
+				return err;
+		if (snd_ac97_try_bit(ac97, AC97_SIGMATEL_DAC2INVERT, 3))
+			if ((err = snd_ctl_add(card, snd_ac97_cnew(&snd_ac97_sigmatel_phaseinvert, ac97))) < 0)
+				return err;
 		break;
 	case AC97_ID_ALC650:
 		/* detect ALC650 rev.E of later */


----- End forwarded message -----

-- 
Ryan Underwood, <nemesis at icequake.net>, icq=10317253


-------------------------------------------------------
This SF.Net email is sponsored by: INetU
Attention Web Developers & Consultants: Become An INetU Hosting Partner.
Refer Dedicated Servers. We Manage Them. You Get 10% Monthly Commission!
INetU Dedicated Managed Hosting http://www.inetu.net/partner/index.php
#1 lore raw

At Wed, 18 Jun 2003 15:12:14 -0500,

Quoted 5 lines · Ryan Underwood

Hi,

Did anyone have a chance to look at this?

it seems that Jaroslav already included it to cvs. thanks!

Takashi

-------------------------------------------------------
This SF.Net email is sponsored by: INetU
Attention Web Developers & Consultants: Become An INetU Hosting Partner. Refer Dedicated Servers. We Manage Them. You Get 10% Monthly Commission! INetU Dedicated Managed Hosting http://www.inetu.net/partner/index.php

#2 lore raw

Hi,

Quoted 10 lines · Takashi Iwai

At Wed, 18 Jun 2003 15:12:14 -0500,

Quoted 5 lines · Ryan Underwood

Hi,

Did anyone have a chance to look at this?

it seems that Jaroslav already included it to cvs. thanks!

Cool, were the names okay for the mixer entities? I couldn't figure out how to name them the "standard" ALSA way, since they are rather odd controls. If the ones I choose were no problem, then everything is good.

Thanks!

Signature · 8 lines
Ryan Underwood, <nemesis at icequake.net>, icq=10317253


-------------------------------------------------------
This SF.Net email is sponsored by: INetU
Attention Web Developers & Consultants: Become An INetU Hosting Partner.
Refer Dedicated Servers. We Manage Them. You Get 10% Monthly Commission!
INetU Dedicated Managed Hosting http://www.inetu.net/partner/index.php