Skip to contentSkip to conversation

"Will be removed in 2.4"

DISCUSSION Justin Pryzby 4 participants 6 messages Jul 3, 2003 – Mar 29, 2004

lore
Share & tools
lore
#0 lore raw

Linux 2.4.21, include/asm/io.h:51 says "Will be removed in 2.4". Its there in 2.5.74 as well.

I can understand why it would be in 2.5; the comment should say 2.6, though.

Justin

#1 lore raw
Quoted 5 lines · Justin Pryzby

Linux 2.4.21, include/asm/io.h:51 says "Will be removed in 2.4". Its there in 2.5.74 as well.

I can understand why it would be in 2.5; the comment should say 2.6, though.

Actually there is a larger issue too:

I would love it if someone (kernel janitors?) went through the kernel code and dug out all the comments like this. "should be gone by 1.3" :)
"should be removed in 2.5". etc. This should be a pretty easy, but
time consuming job that even newbies could sink their teeth into.

Then we can go through the list and kill the issues, or the comments.

Jeff

#2 lore raw

2.5isms

In reply to Justin Pryzby

It seems I've found another 2.5ism. 2.6.0, arch/i386/kernel/dmi_scan.c has

#ifdef CONFIG_SIMNOW
        /*
         *      Skip on x86/64 with simnow. Will eventually go away
         *      If you see this ifdef in 2.6pre mail me !
         */
        return -1;

#endif

I don't know whose file this is ..

Also, 2.6.0 still has the previously mentioned problem in include/asm/io.h.

Not subscribed, CC me.

Justin

Quoted 7 lines · pryzbyj

Linux 2.4.21, include/asm/io.h:51 says "Will be removed in 2.4". Its there in 2.5.74 as well.

I can understand why it would be in 2.5; the comment should say 2.6, though.

Justin

#3 lore raw

Re: 2.5isms

Hi!

Quoted 9 lines

It seems I've found another 2.5ism. 2.6.0, arch/i386/kernel/dmi_scan.c has

#ifdef CONFIG_SIMNOW
        /*
         *      Skip on x86/64 with simnow. Will eventually go away
         *      If you see this ifdef in 2.6pre mail me !
         */
        return -1;
Quoted 8 lines

#endif

I don't know whose file this is ..

Also, 2.6.0 still has the previously mentioned problem in include/asm/io.h.

Not subscribed, CC me.

This is obsolete x86-64 code... Please apply,
Pavel

arch/i386/kernel/dmi_scan.c renamed from linux/arch/i386/kernel/dmi_scan.c +1 -9
@@ -108,15 +108,7 @@
 	u8 buf[15];
 	u32 fp=0xF0000;
 
-#ifdef CONFIG_SIMNOW
-	/*
- 	 *	Skip on x86/64 with simnow. Will eventually go away
- 	 *	If you see this ifdef in 2.6pre mail me !
- 	 */
-	return -1;
-#endif
- 	
-	while( fp < 0xFFFFF)
+	while (fp < 0xFFFFF)
 	{
 		isa_memcpy_fromio(buf, fp, 15);
 		if(memcmp(buf, "_DMI_", 5)==0 && dmi_checksum(buf))
Signature · 2 lines
When do you have a heart between your knees?
[Johanka's followup: and *two* hearts?]
#4 lore raw

Re: 2.5isms

In reply to Justin Pryzby

And again ;)

arch/i386/kernel/irq.c:
* (mostly architecture independent, will move to kernel/irq.c in 2.5.)

Justin

Quoted 28 lines · pryzbyj

It seems I've found another 2.5ism. 2.6.0, arch/i386/kernel/dmi_scan.c has

#ifdef CONFIG_SIMNOW
        /*
         *      Skip on x86/64 with simnow. Will eventually go away
         *      If you see this ifdef in 2.6pre mail me !
         */
        return -1;

#endif

I don't know whose file this is ..

Also, 2.6.0 still has the previously mentioned problem in include/asm/io.h.

Not subscribed, CC me.

Justin

Quoted 7 lines · pryzbyj

Linux 2.4.21, include/asm/io.h:51 says "Will be removed in 2.4". Its there in 2.5.74 as well.

I can understand why it would be in 2.5; the comment should say 2.6, though.

Justin

#5 lore raw

Re: 2.5isms

In reply to Justin Pryzby

Hi!

Quoted 9 lines

It seems I've found another 2.5ism. 2.6.0, arch/i386/kernel/dmi_scan.c has

#ifdef CONFIG_SIMNOW
        /*
         *      Skip on x86/64 with simnow. Will eventually go away
         *      If you see this ifdef in 2.6pre mail me !
         */
        return -1;
Quoted 8 lines

#endif

I don't know whose file this is ..

Also, 2.6.0 still has the previously mentioned problem in include/asm/io.h.

Not subscribed, CC me.

This is obsolete x86-64 code... Please apply,
Pavel

arch/i386/kernel/dmi_scan.c renamed from linux/arch/i386/kernel/dmi_scan.c +1 -9
@@ -108,15 +108,7 @@
 	u8 buf[15];
 	u32 fp=0xF0000;
 
-#ifdef CONFIG_SIMNOW
-	/*
- 	 *	Skip on x86/64 with simnow. Will eventually go away
- 	 *	If you see this ifdef in 2.6pre mail me !
- 	 */
-	return -1;
-#endif
- 	
-	while( fp < 0xFFFFF)
+	while (fp < 0xFFFFF)
 	{
 		isa_memcpy_fromio(buf, fp, 15);
 		if(memcmp(buf, "_DMI_", 5)==0 && dmi_checksum(buf))
Signature · 2 lines
When do you have a heart between your knees?
[Johanka's followup: and *two* hearts?]