Skip to contentSkip to conversation

fix return of compat_sys_sched_getaffinity

PATCH In review [email protected] 2 participants 2 messages Jul 6, 2003

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 fix return of compat_sys_sched_getaffinity

-EFAULT return got buggered when compat_sys_sched_getaffinity was added in 2.5.68.

kernel/compat.c renamed from kernel/compat.c.orig +2 -4
@@ -425,11 +425,9 @@
 				    &kernel_mask);
 	set_fs(old_fs);
 
-	if (ret > 0) {
+	if (ret > 0)
 		if (put_user(kernel_mask, user_mask_ptr))
-			ret = -EFAULT;
-		ret = sizeof(compat_ulong_t);
-	}
+			return -EFAULT;
 
 	return ret;
 }
Signature · 2 lines
Randy Hron
http://home.earthlink.net/~rwhron/kernel/bigbox.html
#1 lore raw
Quoted 3 lines

-EFAULT return got buggered when compat_sys_sched_getaffinity was added in 2.5.68.

but getaffinity returns sizeof(compat_ulong_t) on success...

Anton

Quoted 16 lines
kernel/compat.c renamed from kernel/compat.c.orig +2 -4
@@ -425,11 +425,9 @@
 				    &kernel_mask);
 	set_fs(old_fs);
 
-	if (ret > 0) {
+	if (ret > 0)
 		if (put_user(kernel_mask, user_mask_ptr))
-			ret = -EFAULT;
-		ret = sizeof(compat_ulong_t);
-	}
+			return -EFAULT;
 
 	return ret;
 }