Skip to contentSkip to conversation

2.5.75: parse error in pci.h if !CONFIG_PCI

DISCUSSION Adrian Bunk 2 participants 3 messages Jul 13, 2003 – Jul 14, 2003 PCI

lore
Share & tools
lore
#0 lore raw

I got the following compile error when trying to compile 2.5.75 with !CONFIG_PCI:

<-- snip -->

...
CC drivers/message/fusion/mptscsih.o
In file included from drivers/message/fusion/linux_compat.h:10,
from drivers/message/fusion/mptbase.h:58, from drivers/message/fusion/mptscsih.c:82:
include/linux/pci.h:718: error: syntax error before "int" drivers/message/fusion/mptscsih.c:6924: warning: `mptscsih_setup' defined but not used
make[3]: *** [drivers/message/fusion/mptscsih.o] Error 1

<-- snip -->

cu
Adrian

Signature · 4 lines
       "Is there not promise of rain?" Ling Tan asked suddenly out
        of the darkness. There had been need of rain for many days.
       "Only a promise," Lao Er said.
                                       Pearl S. Buck - Dragon Seed
#1 lore raw
Quoted 15 lines · Adrian Bunk

I got the following compile error when trying to compile 2.5.75 with !CONFIG_PCI:

<-- snip -->

...
CC drivers/message/fusion/mptscsih.o
In file included from drivers/message/fusion/linux_compat.h:10,
from drivers/message/fusion/mptbase.h:58, from drivers/message/fusion/mptscsih.c:82:
include/linux/pci.h:718: error: syntax error before "int" drivers/message/fusion/mptscsih.c:6924: warning: `mptscsih_setup' defined but not used
make[3]: *** [drivers/message/fusion/mptscsih.o] Error 1

Quoted 1 line

<-- snip -->

Thanks, the patch below should fix this problem. I'll send it on to Linus in a bit.

greg k-h

# PCI: fix up error for when CONFIG_PCI=n and scsi.h is included.

include/linux/pci.h +0 -1
diff -Nru a/include/linux/pci.h b/include/linux/pci.h
@@ -715,7 +715,6 @@
 static inline int pci_assign_resource(struct pci_dev *dev, int i) { return -EBUSY;}
 static inline int pci_register_driver(struct pci_driver *drv) { return 0;}
 static inline void pci_unregister_driver(struct pci_driver *drv) { }
-static inline int scsi_to_pci_dma_dir(unsigned char scsi_dir) { return scsi_dir; }
 static inline int pci_find_capability (struct pci_dev *dev, int cap) {return 0; }
 static inline const struct pci_device_id *pci_match_device(const struct pci_device_id *ids, const struct pci_dev *dev) { return NULL; }
 
#2 lore raw
Quoted 16 lines · Greg KH
Quoted 15 lines · Adrian Bunk

I got the following compile error when trying to compile 2.5.75 with !CONFIG_PCI:

<-- snip -->

...
CC drivers/message/fusion/mptscsih.o
In file included from drivers/message/fusion/linux_compat.h:10,
from drivers/message/fusion/mptbase.h:58, from drivers/message/fusion/mptscsih.c:82:
include/linux/pci.h:718: error: syntax error before "int" drivers/message/fusion/mptscsih.c:6924: warning: `mptscsih_setup' defined but not used
make[3]: *** [drivers/message/fusion/mptscsih.o] Error 1

Quoted 4 lines
Quoted 1 line

<-- snip -->

Thanks, the patch below should fix this problem. I'll send it on to Linus in a bit.

Thanks, this patch fixed it.

Quoted 2 lines

greg k-h
...

cu
Adrian

Signature · 4 lines
       "Is there not promise of rain?" Ling Tan asked suddenly out
        of the darkness. There had been need of rain for many days.
       "Only a promise," Lao Er said.
                                       Pearl S. Buck - Dragon Seed